Re: svn commit: r1506095 - /qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
This also seems like a change which should have a JIRA reference,
particularly if there was a patch.
Robbie
On 23 July 2013 16:03, raj...@apache.org wrote:
Author: rajith
Date: Tue Jul 23 15:03:38 2013
New Revision: 1506095
URL: http://svn.apache.org/r1506095
Log:
NO_JIRA Changed the exception thrown for an invalid destination from a
regular JMSException to an
InvalidDestinationException. This is patch from Pavel Morevec.
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java?rev=1506095r1=1506094r2=1506095view=diff
==
---
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
(original)
+++
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Tue Jul 23 15:03:38 2013
@@ -440,7 +440,7 @@ public abstract class BasicMessageProduc
{
if (!(destination instanceof AMQDestination))
{
-throw new JMSException(Unsupported destination class:
+throw new InvalidDestinationException(Unsupported
destination class:
+ ((destination != null) ?
destination.getClass() : null));
}
@@ -453,7 +453,7 @@ public abstract class BasicMessageProduc
}
catch(Exception e)
{
-JMSException ex = new JMSException(Error validating
destination);
+JMSException ex = new InvalidDestinationException(Error
validating destination);
ex.initCause(e);
ex.setLinkedException(e);
-
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org
Re: svn commit: r1506095 - /qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Sorry to pile on, but I second what Robbie said. Without a jira here,
we've missed some useful content for the release.
Justin
On Tue, Jul 23, 2013 at 12:10 PM, Robbie Gemmell
robbie.gemm...@gmail.com wrote:
This also seems like a change which should have a JIRA reference,
particularly if there was a patch.
Robbie
On 23 July 2013 16:03, raj...@apache.org wrote:
Author: rajith
Date: Tue Jul 23 15:03:38 2013
New Revision: 1506095
URL: http://svn.apache.org/r1506095
Log:
NO_JIRA Changed the exception thrown for an invalid destination from a
regular JMSException to an
InvalidDestinationException. This is patch from Pavel Morevec.
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java?rev=1506095r1=1506094r2=1506095view=diff
==
---
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
(original)
+++
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Tue Jul 23 15:03:38 2013
@@ -440,7 +440,7 @@ public abstract class BasicMessageProduc
{
if (!(destination instanceof AMQDestination))
{
-throw new JMSException(Unsupported destination class:
+throw new InvalidDestinationException(Unsupported
destination class:
+ ((destination != null) ?
destination.getClass() : null));
}
@@ -453,7 +453,7 @@ public abstract class BasicMessageProduc
}
catch(Exception e)
{
-JMSException ex = new JMSException(Error validating
destination);
+JMSException ex = new InvalidDestinationException(Error
validating destination);
ex.initCause(e);
ex.setLinkedException(e);
-
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Re: svn commit: r1506095 - /qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Sorry, there wasn't JIRA for this.
I should have created one.
The patch I mentioned was attached to an internal Bugzilla .
Rajith
On Tue, Jul 23, 2013 at 12:10 PM, Robbie Gemmell
robbie.gemm...@gmail.comwrote:
This also seems like a change which should have a JIRA reference,
particularly if there was a patch.
Robbie
On 23 July 2013 16:03, raj...@apache.org wrote:
Author: rajith
Date: Tue Jul 23 15:03:38 2013
New Revision: 1506095
URL: http://svn.apache.org/r1506095
Log:
NO_JIRA Changed the exception thrown for an invalid destination from a
regular JMSException to an
InvalidDestinationException. This is patch from Pavel Morevec.
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Modified:
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java?rev=1506095r1=1506094r2=1506095view=diff
==
---
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
(original)
+++
qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java
Tue Jul 23 15:03:38 2013
@@ -440,7 +440,7 @@ public abstract class BasicMessageProduc
{
if (!(destination instanceof AMQDestination))
{
-throw new JMSException(Unsupported destination class:
+throw new InvalidDestinationException(Unsupported
destination class:
+ ((destination != null) ?
destination.getClass() : null));
}
@@ -453,7 +453,7 @@ public abstract class BasicMessageProduc
}
catch(Exception e)
{
-JMSException ex = new JMSException(Error validating
destination);
+JMSException ex = new InvalidDestinationException(Error
validating destination);
ex.initCause(e);
ex.setLinkedException(e);
-
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org
