[GitHub] incubator-quickstep issue #50: Fixed the time measurement from milli to micr...

2016-07-02 Thread hakanmemisoglu
Github user hakanmemisoglu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/50
  
@hbdeshmukh, thank you for the notification.
I have already followed the instructions. Actually the branch is not in 
original Apache repo, however it is accessible from GitHub. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Comparing profile outputs

2016-07-02 Thread Navneet Potti
If, like me, you often find yourself struggling to compare two Google Profiler 
output graphs, you might find this 
little utility script I wrote helpful. It takes two dot files as input (Google 
profiler output files) and compares them using the cumulative_percentage 
attribute (or anything else you’d like). Functions whose cumulative_percentage 
has shown variation (positive or negative diffs) are colored red or green like 
a heatmap. As an added bonus, the script also does some heuristic hacks to 
improve readability of some long function names which break the standard 
demangler and pollute the profiler output with extra wide node boxes.

A sample diff output profile is attached. Take a look, try it out and let me 
know if you find it helpful or need some new features.

Here’s how to use it:
* Build quickstep with ENABLE_GOOGLE_PROFILER=true
* Run quickstep_cli_shell with -profile_name=“profile1.prof” and 
“profile2.prof” to get the two profile outputs. You often need/want to use two 
different binaries (like comparing feature_branch with master).
* Convert them to dot files using google-pprof.
google-pprof --dot /path/to/quickstep_cli_shell profile1.prof > profile1.dot
google-pprof --dot /path/to/quickstep_cli_shell profile2.prof > profile2.dot
* Run diff_profiles.
./diff_profiles.py profile1.dot profile2.dot -o profile_1vs2.dot
* Open the output.
dot -Tpdf profile_1vs2.dot -o profile_1vs2.pdf
open profile_1vs2.pdf

Cheers,
Nav




[GitHub] incubator-quickstep pull request #50: Fixed the time measurement from milli ...

2016-07-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/50


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #50: Fixed the time measurement from milli to micr...

2016-07-02 Thread hakanmemisoglu
Github user hakanmemisoglu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/50
  
It seems alright. I am merging it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep pull request #50: Fixed the time measurement from milli ...

2016-07-02 Thread hbdeshmukh
GitHub user hbdeshmukh opened a pull request:

https://github.com/apache/incubator-quickstep/pull/50

Fixed the time measurement from milli to microseconds in Worker



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep 
time-measurement-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit 040a511aad35cb958d9d532fabc002313952cb11
Author: Harshad Deshmukh 
Date:   2016-07-02T20:58:52Z

Fixed the time measurement from milli to microseconds.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---