Podling Report Reminder - August 2016

[johndament]

Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 17 August 2016, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, August 03).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.

This should be appended to the Incubator Wiki page at:

http://wiki.apache.org/incubator/August2016

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC

[GitHub] incubator-quickstep issue #73: Move hash join's probe and build node decisio...

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/73
  
LGTM except for some minor places. Also fix the style check issue then 
we're good to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/73#discussion_r73208331
  
--- Diff: query_optimizer/rules/SwapProbeBuild.hpp ---
@@ -0,0 +1,47 @@
+#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_
+#define QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_
+
+#include 
--- End diff --

Add `#include ` as `std::unique_ptr` is used in this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/73#discussion_r73207435
  
--- Diff: query_optimizer/rules/SwapProbeBuild.cpp ---
@@ -0,0 +1,64 @@
+#include "query_optimizer/rules/SwapProbeBuild.hpp"
+
+#include 
+#include 
+
+#include "query_optimizer/cost_model/StarSchemaSimpleCostModel.hpp"
+#include "query_optimizer/expressions/AttributeReference.hpp"
+#include "query_optimizer/physical/HashJoin.hpp"
+#include "query_optimizer/physical/PatternMatcher.hpp"
+#include "query_optimizer/physical/Physical.hpp"
+#include "query_optimizer/physical/TopLevelPlan.hpp"
+#include "query_optimizer/rules/Rule.hpp"
+
+
+namespace quickstep {
+namespace optimizer {
+
+P::PhysicalPtr SwapProbeBuild::applyToNode(const P::PhysicalPtr ) {
+  P::HashJoinPtr hash_join;
+
+  if (P::SomeHashJoin::MatchesWithConditionalCast(input, _join)
+  && hash_join->join_type() == P::HashJoin::JoinType::kInnerJoin) {
+P::PhysicalPtr left = hash_join->left();
+P::PhysicalPtr right = hash_join->right();
+
+
+
--- End diff --

Remove the extra blank lines here (at most 1 line).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/73#discussion_r73204750
  
--- Diff: query_optimizer/rules/BottomUpRule.hpp ---
@@ -80,6 +81,8 @@ class BottomUpRule : public Rule {
*/
   virtual TreeNodePtr applyToNode(const TreeNodePtr ) = 0;
 
+  virtual void init(const TreeNodePtr ) = 0;
--- End diff --

Let's provide a default no-op implementation for `init()` here (instead of 
pure virtual) so we don't have to implement it for every subclass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #75: QUICKSTEP-38. Add support for python3 ...

[cwelton]

GitHub user cwelton opened a pull request:

https://github.com/apache/incubator-quickstep/pull/75

QUICKSTEP-38. Add support for python3 to utility scripts

Three core changes:
- update from python2 print command, to python3 print function [1]
- switch from xrange to range [1]
- switch from dict.iteritems to iter(dict.items())  [2]

[1] http://python-future.org/compatible_idioms.html
[2] http://legacy.python.org/dev/peps/pep-0469/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cwelton/incubator-quickstep master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #75


commit 1c48650e21f7fa0fb7c0dda2b08512618cdc8c07
Author: Caleb Welton 
Date:   2016-08-02T17:44:41Z

QUICKSTEP-38. Add support for python3 to utility scripts




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Greetings

[Caleb Welton]

Cool, I created:
 - https://issues.apache.org/jira/browse/QUICKSTEP-38
 - https://issues.apache.org/jira/browse/QUICKSTEP-39

Looks like the correct procedure for a non-committer will be to send a
github pull request?

Regards,
  Caleb

On Mon, Aug 1, 2016 at 7:53 PM, J Patel  wrote:

> +1 from me.
>
> Zuyu is our resident expert on this, so would love to hear his input too.
>
> Thanks Caleb!
>
> Cheers,
> Jignesh
>
> On Monday, August 1, 2016, Caleb Welton  wrote:
>
> > Hello Quickstep team!
> >
> >
> > A. This list is a bit difficult to find.
> >
> > I'd like to suggest adding a link to it from
> > https://cwiki.apache.org/confluence/display/QUICKSTEP/Quickstep+Home or
> > http://quickstep.incubator.apache.org/
> >
> >
> > B. I'd like to propose two minor enhancements.
> >
> > 1. Update cyclic_dependency.py and validate_cmakelists.py to support both
> > Python2 and Python3.
> >
> > Reason, Python 3 is has reached a level of maturity that it can be
> > considered ready for prime time, adding support for Python 3 is a minimal
> > cost and increases both future readiness and availability on more
> systems.
> > The change to support both versions of the language is relatively small
> and
> > non-invasive.
> >
> > If the community is interested I have a patch.
> >
> >
> > 2. Update cyclic_dependency.py and validate_cmakelists.py to move
> > configuration to a separate configuration file.
> >
> > Reason, currently both scripts have intermingled code and configuration
> > which means that any new ignored dependencies require changes to the code
> > rather than configuration.  The scripts seem generally useful and I would
> > like to incorporate them into a different project, it would be nice to be
> > able to do so without requiring code changes so that the code can be used
> > as is without modification.
> >
> > I am willing to develop a patch if the community is interested.
> >
> >
> > Cheers!
> >Caleb
> >
>

[GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...

[hakanmemisoglu]

Github user hakanmemisoglu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/73#discussion_r73118755
  
--- Diff: query_optimizer/rules/SwapProbeBuild.cpp ---
@@ -0,0 +1,72 @@
+#include "query_optimizer/rules/SwapProbeBuild.hpp"
+
+#include 
+#include 
+
+#include "query_optimizer/cost_model/StarSchemaSimpleCostModel.hpp"
+#include "query_optimizer/expressions/AttributeReference.hpp"
+#include "query_optimizer/physical/HashJoin.hpp"
+#include "query_optimizer/physical/PatternMatcher.hpp"
+#include "query_optimizer/physical/Physical.hpp"
+#include "query_optimizer/physical/TopLevelPlan.hpp"
+#include "query_optimizer/rules/Rule.hpp"
+
+
+namespace quickstep {
+namespace optimizer {
+
+P::PhysicalPtr SwapProbeBuild::applyToNode(const P::PhysicalPtr ) {
+  P::HashJoinPtr hash_join;
+
+  if (P::SomeHashJoin::MatchesWithConditionalCast(input, _join)) {
+P::PhysicalPtr left = hash_join->left();
+P::PhysicalPtr right = hash_join->right();
+
+P::TopLevelPlanPtr top_level;
+if (P::SomeTopLevelPlan::MatchesWithConditionalCast(input, 
_level)) {
--- End diff --

@jianqiao , Thanks for the catch. 

> In fact, BottomUpRule does not provide a place for initializing 
cost_model_.

It is the reason why, I have implemented initialization of cost model in 
"applyToNode". 
I will introduce init(const P::PhysicalPtr _level_plan) as you said.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #74: Removed the redundant query id in the ...

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/74

Removed the redundant query id in the optimizer.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep optimizer-q-id

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit f565f33a479b6c815a68874beb1d0eaa66e807a1
Author: Zuyu Zhang 
Date:   2016-08-02T06:02:37Z

Removed the redundant query id in the optimizer.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---