[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread zuyu
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
@cwelton I've created [the 
guideline](https://cwiki.apache.org/confluence/display/QUICKSTEP/Workflow+For+Contributors)
 as suggested. Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread zuyu
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Yes, we should add a workflow for contributors as well. Stay tuned!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread cwelton
Github user cwelton commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Ah, sorry, just thought you wanted the extraneous merge commit squashed.  
I've reordered the commits in my branch.  For some reason the hashjoin commit 
is still showing up in this PR, not sure why.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread cwelton
Github user cwelton commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Thanks for fixing, I suggest adding a contributor's guide with your 
suggested git workflow, to help streamline future contributors/contributions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread zuyu
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
@cwelton No worry for this PR. I've addressed the issues in the `master` 
branch. Thanks again for submitting a PR.

Next time if we run `git fetch origin/master` and then `git rebase -i 
origin/master`, I think we are good to go.

Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread zuyu
Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
@pateljm We need to reverse this merge, due to an incorrect rebase.

@cwelton We expect a different rebase result where this PR only contains a 
single commit ahead of the `origin/master`, instead of having another unrelated 
commit from a merged PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread pateljm
Github user pateljm commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Thanks @cwelton! Merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread cwelton
Github user cwelton commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
Rebase complete


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-quickstep issue #75: QUICKSTEP-38. Add support for python3 to util...

2016-08-03 Thread pateljm
Github user pateljm commented on the issue:

https://github.com/apache/incubator-quickstep/pull/75
  
This looks good Caleb (@cwelton)! Can you rebase so that I can merge this 
commit? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---