[GitHub] incubator-quickstep issue #99: QUICKSTEP-36 Quickstep gives segmentation fau...
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/99 LGTM. Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-quickstep issue #99: QUICKSTEP-36 Quickstep gives segmentation fau...
Github user pateljm commented on the issue: https://github.com/apache/incubator-quickstep/pull/99 Thanks @zuyu and @hbdeshmukh for excellent mentorship on this PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-quickstep issue #99: QUICKSTEP-36 Quickstep gives segmentation fau...
Github user zuyu commented on the issue: https://github.com/apache/incubator-quickstep/pull/99 @tarunbansal Before we merge this PR, please squash all the commits into one. Thanks! https://cwiki.apache.org/confluence/display/QUICKSTEP/Workflow+For+Contributors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-quickstep issue #99: QUICKSTEP-36 Quickstep gives segmentation fau...
Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/99 Hi @tarunbansal I have given some comments. After you address them, I will merge this PR. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-quickstep issue #99: QUICKSTEP-36 Quickstep gives segmentation fau...
Github user tarunbansal commented on the issue: https://github.com/apache/incubator-quickstep/pull/99 Thanks @hbdeshmukh for noticing this possible ambiguity. I am still digging around the code and will update the PR once the fix is ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
