[GitHub] incubator-quickstep pull request #125: QUICKSTEP-61 Fixes varlen insert bug.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #125: QUICKSTEP-61 Fixes varlen insert bug.

[cramja]

GitHub user cramja opened a pull request:

https://github.com/apache/incubator-quickstep/pull/125

QUICKSTEP-61 Fixes varlen insert bug.

This change fixes an incorrect estimate for the maximum size of a tuple. 
Previously, it was not accounting for the space used by the fixed length 
portion of the tuple.

The unit tests were modified because, now, we insert fewer tuples. It's 
actually quite hard to test the correct number of tuples which will be 
inserted, so this has been left as a TODO. We were able to load all of the SSB 
tables correctly now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cramja/incubator-quickstep 
fix_splitrow_estimate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #125


commit 70a3d47cdcf46bbb8f39b1cc1a0fbd2650a6afa0
Author: cramja 
Date:   2016-11-01T18:42:04Z

QUICKSTEP-61 Fixes varlen insert bug.

This change fixes an incorrect estimate for the maximum size of a
tuple. Previously, it was not accounting for the space used by the
fixed length portion of the tuple.

The unit tests were modified because, now, we insert fewer tuples. It's
actually quite hard to test the correct number of tuples which will be
inserted, so this has been left as a TODO.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---