[racket-dev] A broken contract test feature

2013-07-02 Thread Sam Tobin-Hochstadt
Currently, there's one test in 'contract-test.rktl' that fails.  The
problem is that the test expects 'contract-test.rktl' to be in the
main collects directory, but it isn't -- it's in the `racket-test`
package.   What we want is to have it detect that it's in a package,
but doing that has two problems. First, the relevant function is in
`setup/private/setup-relative`, but should probably be exported
publicly.  Second, it can't be used, because it uses the package
system (of course) but the package system uses contracts in its
implementation. For this reason, I've disabled the test for the
moment, so that the core racket tests complete successfully [1].

Unfortunately, this is a really nice, if small, feature of the
contract system.  Any suggestions for how we can fix this?

Sam

[1] Why I care in will be clear in a subsequent email.
_
  Racket Developers list:
  http://lists.racket-lang.org/dev


Re: [racket-dev] A broken contract test feature

2013-07-02 Thread Robby Findler
I looked into this too and didn't come up with a good solution.

It would be nice if there were a way to write the here's a path, please
tell me which part to replace with pkg/something without too many
dependencies, but I didn't try to see if that would be feasible.

Meanwhile, I agree that just disabling that test is probably the way to go.

Robby


On Tue, Jul 2, 2013 at 5:57 PM, Sam Tobin-Hochstadt sa...@ccs.neu.eduwrote:

 Currently, there's one test in 'contract-test.rktl' that fails.  The
 problem is that the test expects 'contract-test.rktl' to be in the
 main collects directory, but it isn't -- it's in the `racket-test`
 package.   What we want is to have it detect that it's in a package,
 but doing that has two problems. First, the relevant function is in
 `setup/private/setup-relative`, but should probably be exported
 publicly.  Second, it can't be used, because it uses the package
 system (of course) but the package system uses contracts in its
 implementation. For this reason, I've disabled the test for the
 moment, so that the core racket tests complete successfully [1].

 Unfortunately, this is a really nice, if small, feature of the
 contract system.  Any suggestions for how we can fix this?

 Sam

 [1] Why I care in will be clear in a subsequent email.

_
  Racket Developers list:
  http://lists.racket-lang.org/dev


Re: [racket-dev] A broken contract test feature

2013-07-02 Thread Carl Eastlund
Could you simply forge the source location on the syntax object to make it
look like it's from a collection?

Carl Eastlund

On Tue, Jul 2, 2013 at 7:10 PM, Robby Findler
ro...@eecs.northwestern.eduwrote:

 I looked into this too and didn't come up with a good solution.

 It would be nice if there were a way to write the here's a path, please
 tell me which part to replace with pkg/something without too many
 dependencies, but I didn't try to see if that would be feasible.

 Meanwhile, I agree that just disabling that test is probably the way to go.

 Robby


 On Tue, Jul 2, 2013 at 5:57 PM, Sam Tobin-Hochstadt sa...@ccs.neu.eduwrote:

 Currently, there's one test in 'contract-test.rktl' that fails.  The
 problem is that the test expects 'contract-test.rktl' to be in the
 main collects directory, but it isn't -- it's in the `racket-test`
 package.   What we want is to have it detect that it's in a package,
 but doing that has two problems. First, the relevant function is in
 `setup/private/setup-relative`, but should probably be exported
 publicly.  Second, it can't be used, because it uses the package
 system (of course) but the package system uses contracts in its
 implementation. For this reason, I've disabled the test for the
 moment, so that the core racket tests complete successfully [1].

 Unfortunately, this is a really nice, if small, feature of the
 contract system.  Any suggestions for how we can fix this?

 Sam

 [1] Why I care in will be clear in a subsequent email.



 _
   Racket Developers list:
   http://lists.racket-lang.org/dev


_
  Racket Developers list:
  http://lists.racket-lang.org/dev


Re: [racket-dev] A broken contract test feature

2013-07-02 Thread Robby Findler
Oh, that's a good idea! I'll do that (later). Stupid me for not seeing that.

It would be great to get pkg/x into error messages at some point, but I
shouldn't have confused these two.

Thanks,
Robby


On Tue, Jul 2, 2013 at 6:53 PM, Carl Eastlund c...@ccs.neu.edu wrote:

 Could you simply forge the source location on the syntax object to make it
 look like it's from a collection?

 Carl Eastlund

 On Tue, Jul 2, 2013 at 7:10 PM, Robby Findler ro...@eecs.northwestern.edu
  wrote:

 I looked into this too and didn't come up with a good solution.

 It would be nice if there were a way to write the here's a path, please
 tell me which part to replace with pkg/something without too many
 dependencies, but I didn't try to see if that would be feasible.

 Meanwhile, I agree that just disabling that test is probably the way to
 go.

 Robby


 On Tue, Jul 2, 2013 at 5:57 PM, Sam Tobin-Hochstadt sa...@ccs.neu.eduwrote:

 Currently, there's one test in 'contract-test.rktl' that fails.  The
 problem is that the test expects 'contract-test.rktl' to be in the
 main collects directory, but it isn't -- it's in the `racket-test`
 package.   What we want is to have it detect that it's in a package,
 but doing that has two problems. First, the relevant function is in
 `setup/private/setup-relative`, but should probably be exported
 publicly.  Second, it can't be used, because it uses the package
 system (of course) but the package system uses contracts in its
 implementation. For this reason, I've disabled the test for the
 moment, so that the core racket tests complete successfully [1].

 Unfortunately, this is a really nice, if small, feature of the
 contract system.  Any suggestions for how we can fix this?

 Sam

 [1] Why I care in will be clear in a subsequent email.



 _
   Racket Developers list:
   http://lists.racket-lang.org/dev



_
  Racket Developers list:
  http://lists.racket-lang.org/dev