Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188568
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 18, 2017, 7:26 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> ---
> 
> (Updated Oct. 18, 2017, 7:26 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Performance improvements in RANGER-1771, in finding the policies for a given 
> resource, should be made in tag-enricher as well - to optimize finding of 
> tags applicable for a given resource.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  5f0a422 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
>  210eb3d 
> 
> 
> Diff: https://reviews.apache.org/r/63085/diff/5/
> 
> 
> Testing
> ---
> 
> Passes all unit tests. Tested with perf-tool locally.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/
---

(Updated Oct. 18, 2017, 7:26 p.m.)


Review request for ranger, Madhan Neethiraj and Ramesh Mani.


Changes
---

Fixed bug uncovered by a failed unit test.


Bugs: RANGER-1843
https://issues.apache.org/jira/browse/RANGER-1843


Repository: ranger


Description
---

Performance improvements in RANGER-1771, in finding the policies for a given 
resource, should be made in tag-enricher as well - to optimize finding of tags 
applicable for a given resource.


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
 5f0a422 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
 210eb3d 


Diff: https://reviews.apache.org/r/63085/diff/5/

Changes: https://reviews.apache.org/r/63085/diff/4-5/


Testing
---

Passes all unit tests. Tested with perf-tool locally.


Thanks,

Abhay Kulkarni

[jira] [Commented] (RANGER-1820) Duplicate entries should be deleted before creation of unique index on x_group and x_group_users table

2017-10-18 Thread Pradeep Agrawal (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209831#comment-16209831
 ] 

Pradeep Agrawal commented on RANGER-1820:
-

Committed in Apache master: 
https://github.com/apache/ranger/commit/97280ee10f8cb1c624e348227fc696adffa731ce
Committed in Apache ranger-0.7 : 
https://github.com/apache/ranger/commit/d3527546f10c514cc0b4069d7d830bf46e8726f8

> Duplicate entries should be deleted before creation of unique index on 
> x_group and x_group_users table
> --
>
> Key: RANGER-1820
> URL: https://issues.apache.org/jira/browse/RANGER-1820
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.5.0, 0.6.0, 0.7.0, 1.0.0
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
> Fix For: 1.0.0, 0.7.2
>
> Attachments: RANGER-1820-1.patch, RANGER-1820-master-2.patch, 
> RANGER-1820-ranger-0.7.patch
>
>
> Currently, concurrent request to create a group and group-users mapping is 
> causing duplicate entries of the same group in the x_group table and 
> user-group mapping entry in the x_group_users table. Duplicate entry creation 
> has been restricted through the RANGER-1765 patch which creates unique 
> constraints on the x_group and x_group_users table. But unique index creation 
> may fail if there is already duplicate entries(likely to happen in upgrade 
> case) so we should delete duplicate entries of these tables before creating 
> the unique index. If the reference of duplicate group id is being used in 
> child table then the id of the duplicate group shall be updated in the child 
> table. In case of duplicate entries of the same group name; group name having 
> the minimum id(created first) shall be given higher preference and will not 
> be deleted from the x_group table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188547
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 18, 2017, 6:13 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> ---
> 
> (Updated Oct. 18, 2017, 6:13 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Performance improvements in RANGER-1771, in finding the policies for a given 
> resource, should be made in tag-enricher as well - to optimize finding of 
> tags applicable for a given resource.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  5f0a422 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
>  210eb3d 
> 
> 
> Diff: https://reviews.apache.org/r/63085/diff/4/
> 
> 
> Testing
> ---
> 
> Passes all unit tests. Tested with perf-tool locally.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/
---

(Updated Oct. 18, 2017, 6:13 p.m.)


Review request for ranger, Madhan Neethiraj and Ramesh Mani.


Changes
---

Addressed review comments


Bugs: RANGER-1843
https://issues.apache.org/jira/browse/RANGER-1843


Repository: ranger


Description
---

Performance improvements in RANGER-1771, in finding the policies for a given 
resource, should be made in tag-enricher as well - to optimize finding of tags 
applicable for a given resource.


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
 5f0a422 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
 210eb3d 


Diff: https://reviews.apache.org/r/63085/diff/4/

Changes: https://reviews.apache.org/r/63085/diff/3-4/


Testing
---

Passes all unit tests. Tested with perf-tool locally.


Thanks,

Abhay Kulkarni

Re: Review Request 63115: RANGER-1820: Updated optimized db schema script for SQLServer DB

2017-10-18 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63115/#review188537
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 18, 2017, 5:21 p.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63115/
> ---
> 
> (Updated Oct. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, bhavik patel, 
> Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, 
> Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1820
> https://issues.apache.org/jira/browse/RANGER-1820
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> **Problem Statement:** DB schema script updated through RR-62717 does not 
> have new db patch entry(029) in optimized sql server script. Similarly java 
> patch J10008 and J10011 need to be added.
> 
> **Proposed Solution:** Proposed solution is having insert statement for sql 
> patch 029 and java patch J10008,J10011 in 
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> file.
> 
> **Note:** Patch for master branch shall be different than ranger-0.7 branch 
> patch as master branch script is already having changes related to java patch 
> J10008. Proposed patch for master branch is attached in Apache Jira 
> RANGER-1820.
> 
> 
> Diffs
> -
> 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 27257e3 
> 
> 
> Diff: https://reviews.apache.org/r/63115/diff/1/
> 
> 
> Testing
> ---
> 
> 1) Executed DBA Setup and ensured that ranger-admin database and ranger-admin 
> DB user are created.
> 2) From a MSSQL Client tool executed 
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> file on database created in previous step.
> 3) Executed DB setup and java patches execution command.
> 
> **Expected Behaviour :** Ranger setup process should skip the DB schema 
> creation and java patch execution. Ranger UI should work properly after 
> starting Ranger admin.
> Actual Behaviour : DB schema creation and java patch execution was skipped 
> and patches were marked executed in x_db_version_h table.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 63115: RANGER-1820: Updated optimized db schema script for SQLServer DB

2017-10-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63115/#review188532
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 18, 2017, 5:21 p.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63115/
> ---
> 
> (Updated Oct. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, bhavik patel, 
> Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, 
> Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1820
> https://issues.apache.org/jira/browse/RANGER-1820
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> **Problem Statement:** DB schema script updated through RR-62717 does not 
> have new db patch entry(029) in optimized sql server script. Similarly java 
> patch J10008 and J10011 need to be added.
> 
> **Proposed Solution:** Proposed solution is having insert statement for sql 
> patch 029 and java patch J10008,J10011 in 
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> file.
> 
> **Note:** Patch for master branch shall be different than ranger-0.7 branch 
> patch as master branch script is already having changes related to java patch 
> J10008. Proposed patch for master branch is attached in Apache Jira 
> RANGER-1820.
> 
> 
> Diffs
> -
> 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 27257e3 
> 
> 
> Diff: https://reviews.apache.org/r/63115/diff/1/
> 
> 
> Testing
> ---
> 
> 1) Executed DBA Setup and ensured that ranger-admin database and ranger-admin 
> DB user are created.
> 2) From a MSSQL Client tool executed 
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> file on database created in previous step.
> 3) Executed DB setup and java patches execution command.
> 
> **Expected Behaviour :** Ranger setup process should skip the DB schema 
> creation and java patch execution. Ranger UI should work properly after 
> starting Ranger admin.
> Actual Behaviour : DB schema creation and java patch execution was skipped 
> and patches were marked executed in x_db_version_h table.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188527
---


Fix it, then Ship it!





agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
Lines 155 (patched)


Please add JavaDoc to new classes & methods.


- Alejandro Fernandez


On Oct. 18, 2017, 1:03 a.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> ---
> 
> (Updated Oct. 18, 2017, 1:03 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Performance improvements in RANGER-1771, in finding the policies for a given 
> resource, should be made in tag-enricher as well - to optimize finding of 
> tags applicable for a given resource.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  5f0a422d 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
>  210eb3d5 
> 
> 
> Diff: https://reviews.apache.org/r/63085/diff/3/
> 
> 
> Testing
> ---
> 
> Passes all unit tests. Tested with perf-tool locally.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Review Request 63115: RANGER-1820: Updated optimized db schema script for SQLServer DB

2017-10-18 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63115/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, bhavik patel, Gautam 
Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan 
Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1820
https://issues.apache.org/jira/browse/RANGER-1820


Repository: ranger


Description
---

**Problem Statement:** DB schema script updated through RR-62717 does not have 
new db patch entry(029) in optimized sql server script. Similarly java patch 
J10008 and J10011 need to be added.

**Proposed Solution:** Proposed solution is having insert statement for sql 
patch 029 and java patch J10008,J10011 in 
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql file.

**Note:** Patch for master branch shall be different than ranger-0.7 branch 
patch as master branch script is already having changes related to java patch 
J10008. Proposed patch for master branch is attached in Apache Jira RANGER-1820.


Diffs
-

  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
27257e3 


Diff: https://reviews.apache.org/r/63115/diff/1/


Testing
---

1) Executed DBA Setup and ensured that ranger-admin database and ranger-admin 
DB user are created.
2) From a MSSQL Client tool executed 
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql file 
on database created in previous step.
3) Executed DB setup and java patches execution command.

**Expected Behaviour :** Ranger setup process should skip the DB schema 
creation and java patch execution. Ranger UI should work properly after 
starting Ranger admin.
Actual Behaviour : DB schema creation and java patch execution was skipped and 
patches were marked executed in x_db_version_h table.


Thanks,

Pradeep Agrawal

[jira] [Updated] (RANGER-1820) Duplicate entries should be deleted before creation of unique index on x_group and x_group_users table

2017-10-18 Thread Pradeep Agrawal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Agrawal updated RANGER-1820:

Attachment: RANGER-1820-ranger-0.7.patch
RANGER-1820-master-2.patch

> Duplicate entries should be deleted before creation of unique index on 
> x_group and x_group_users table
> --
>
> Key: RANGER-1820
> URL: https://issues.apache.org/jira/browse/RANGER-1820
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.5.0, 0.6.0, 0.7.0, 1.0.0
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
> Fix For: 1.0.0, 0.7.2
>
> Attachments: RANGER-1820-1.patch, RANGER-1820-master-2.patch, 
> RANGER-1820-ranger-0.7.patch
>
>
> Currently, concurrent request to create a group and group-users mapping is 
> causing duplicate entries of the same group in the x_group table and 
> user-group mapping entry in the x_group_users table. Duplicate entry creation 
> has been restricted through the RANGER-1765 patch which creates unique 
> constraints on the x_group and x_group_users table. But unique index creation 
> may fail if there is already duplicate entries(likely to happen in upgrade 
> case) so we should delete duplicate entries of these tables before creating 
> the unique index. If the reference of duplicate group id is being used in 
> child table then the id of the duplicate group shall be updated in the child 
> table. In case of duplicate entries of the same group name; group name having 
> the minimum id(created first) shall be given higher preference and will not 
> be deleted from the x_group table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 63085: Tag enricher performance improvement in identifying tags for resource being accessed

2017-10-18 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63085/#review188498
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 18, 2017, 1:03 a.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63085/
> ---
> 
> (Updated Oct. 18, 2017, 1:03 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-1843
> https://issues.apache.org/jira/browse/RANGER-1843
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Performance improvements in RANGER-1771, in finding the policies for a given 
> resource, should be made in tag-enricher as well - to optimize finding of 
> tags applicable for a given resource.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  5f0a422d 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
>  210eb3d5 
> 
> 
> Diff: https://reviews.apache.org/r/63085/diff/3/
> 
> 
> Testing
> ---
> 
> Passes all unit tests. Tested with perf-tool locally.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

[jira] [Reopened] (RANGER-1820) Duplicate entries should be deleted before creation of unique index on x_group and x_group_users table

2017-10-18 Thread Pradeep Agrawal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Agrawal reopened RANGER-1820:
-

Re-opening this issue as an entry of new SQL patch 029 need to be added in 
optimized SQL server script as well.

> Duplicate entries should be deleted before creation of unique index on 
> x_group and x_group_users table
> --
>
> Key: RANGER-1820
> URL: https://issues.apache.org/jira/browse/RANGER-1820
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.5.0, 0.6.0, 0.7.0, 1.0.0
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
> Fix For: 1.0.0, 0.7.2
>
> Attachments: RANGER-1820-1.patch
>
>
> Currently, concurrent request to create a group and group-users mapping is 
> causing duplicate entries of the same group in the x_group table and 
> user-group mapping entry in the x_group_users table. Duplicate entry creation 
> has been restricted through the RANGER-1765 patch which creates unique 
> constraints on the x_group and x_group_users table. But unique index creation 
> may fail if there is already duplicate entries(likely to happen in upgrade 
> case) so we should delete duplicate entries of these tables before creating 
> the unique index. If the reference of duplicate group id is being used in 
> child table then the id of the duplicate group shall be updated in the child 
> table. In case of duplicate entries of the same group name; group name having 
> the minimum id(created first) shall be given higher preference and will not 
> be deleted from the x_group table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61021: RANGER-1672:Ranger supports plugin to enable, monitor and manage apache kylin

2017-10-18 Thread Colm O hEigeartaigh 


> On Sept. 27, 2017, 9:33 a.m., pengjianhua wrote:
> > The https://issues.apache.org/jira/browse/KYLIN-2703 I submitted had been 
> > resolved. Our test experts have rigorously tested this issue. At the same 
> > time the Kyligence company which is Apache kylin's main contributor will 
> > soon use this feature.
> 
> Colm O hEigeartaigh wrote:
> When will Kylin 2.2.0 be released? If we merge a dependency on a SNAPSHOT 
> version in Ranger, we can't release Ranger until Kylin is released. Do you 
> have any documentation on how to set up a simple test-scenario?
> 
> pengjianhua wrote:
> Ok. The Kylin 2.2.0 will be released  in late October.
> 
> Qiang Zhang wrote:
> Ok. I am writing install guide for the feature.
> 
> Qiang Zhang wrote:
> Hi Colm, Can you tell me how to build a document patch? Thanks!
> 
> Colm O hEigeartaigh wrote:
> I'm not sure what you mean by "document patch". What do you want to do 
> exactly?
> 
> Qiang Zhang wrote:
> I build patch for RANGER-1809 after writed installing guide for 
> RANGER-1672. I want to know which path the document is placed and how to 
> build the document patch. Thanks!

Well you could add it to the website, but it's probably easier just to create a 
new wiki page, which is where all the rest of the Ranger documentation lives:

https://cwiki.apache.org/confluence/display/RANGER/Index


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61021/#review186391
---


On Sept. 27, 2017, 9:19 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61021/
> ---
> 
> (Updated Sept. 27, 2017, 9:19 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1672
> https://issues.apache.org/jira/browse/RANGER-1672
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger supports plugin to enable, monitor and manage apache kylin
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh d31a264 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  9463ab8 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 58cdd35 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json 
> PRE-CREATION 
>   plugin-kylin/.gitignore PRE-CREATION 
>   plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION 
>   plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION 
>   plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION 
>   plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION 
>   plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION 
>   plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION 
>   plugin-kylin/pom.xml PRE-CREATION 
>   plugin-kylin/scripts/install.properties PRE-CREATION 
>   
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java
>  PRE-CREATION 
>   
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java
>  PRE-CREATION 
>   
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java
>  PRE-CREATION 
>   
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java
>  PRE-CREATION 
>   
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java
>  PRE-CREATION 
>   
> plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java
>  PRE-CREATION 
>   pom.xml 3958014 
>   ranger-kylin-plugin-shim/.gitignore PRE-CREATION 
>   ranger-kylin-plugin-shim/pom.xml PRE-CREATION 
>   
> ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java
>  PRE-CREATION 
>   src/main/assembly/admin-web.xml 0e97818 
>   src/main/assembly/plugin-kylin.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61021/diff/3/
> 
> 
> Testing
> ---
> 
> Tested
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>