Re: Review Request 65777: RANGER-1967 - Kafka 1.0 support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65777/#review198273 --- Ship it! Ship It! - Ramesh Mani On Feb. 24, 2018, 10:08 a.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65777/ > --- > > (Updated Feb. 24, 2018, 10:08 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1967 > https://issues.apache.org/jira/browse/RANGER-1967 > > > Repository: ranger > > > Description > --- > > The API changes are not too big, however running Kafka in embedded mode > turned out to be a bit trickier beast. I had to add a couple of new flags, > otherwise it would wait for 2 other broker to join. > The commit also contains logging changes, even a test log4j configuration, > just to make the debugging easier. > > > Diffs > - > > agents-audit/pom.xml 4fa44c5f > plugin-kafka/pom.xml f644646b > > plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java > b3d5a74d > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java > 4ea39ed7 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java > fb541cd3 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java > fb0a2c0f > plugin-kafka/src/test/resources/log4j.properties PRE-CREATION > pom.xml fa1d1c7b > ranger-kafka-plugin-shim/pom.xml f1aeee6f > > > Diff: https://reviews.apache.org/r/65777/diff/2/ > > > Testing > --- > > Unit & local tests > > > Thanks, > > Zsombor Gegesy > >
[jira] [Commented] (RANGER-1961) Fixed spelling error "condtion"
[ https://issues.apache.org/jira/browse/RANGER-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375635#comment-16375635 ] Zsombor Gegesy commented on RANGER-1961: Patch commited to master : https://github.com/apache/ranger/commit/04b4e167b14d768a160d4342ed12302f9449994f > Fixed spelling error "condtion" > --- > > Key: RANGER-1961 > URL: https://issues.apache.org/jira/browse/RANGER-1961 > Project: Ranger > Issue Type: Bug > Components: tagsync >Affects Versions: master >Reporter: Willie Engelbrecht >Priority: Trivial > Fix For: 1.0.0 > > Attachments: > 0001-Fixed-spelling-mistake-of-condtion-to-condition.patch > > > When creating a new tag policy, under "Add conditions" there is an input box > with the text: Please enter condtion.. > The patch corrects the spelling to _condition_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-1961) Fixed spelling error "condtion"
[ https://issues.apache.org/jira/browse/RANGER-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1961: --- Fix Version/s: 1.0.0 > Fixed spelling error "condtion" > --- > > Key: RANGER-1961 > URL: https://issues.apache.org/jira/browse/RANGER-1961 > Project: Ranger > Issue Type: Bug > Components: tagsync >Affects Versions: master >Reporter: Willie Engelbrecht >Priority: Trivial > Fix For: 1.0.0 > > Attachments: > 0001-Fixed-spelling-mistake-of-condtion-to-condition.patch > > > When creating a new tag policy, under "Add conditions" there is an input box > with the text: Please enter condtion.. > The patch corrects the spelling to _condition_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Review Request 65793: RANGER-1991 : fix errors detected by static code analysis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65793/
---
Review request for ranger.
Bugs: RANGER-1991
https://issues.apache.org/jira/browse/RANGER-1991
Repository: ranger
Description
---
FindBugs/SpotBug detects a couple of problems with the code base:
* Incorrect class casting - in XXServiceDef.equals
* Unnecessary NPE checks - for variables which is known to be non-null (for
example, because in other places a method is called on that object). In
ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in
XUserMgr.java
* Collection.contains method call which is never true - in
ServiceDBStore.validatePolicyItems for policyItem.getAccesses().contains("") -
because getAccesses doesn't store String objects
* Making public partially initialized objects in
HadoopConfigHolder.initResourceMap()
* Calling toString on array, which is not too readable
Diffs
-
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
fd925aa4
hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerHdfsAuthorizerTest.java
46f92ecb
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
7aee4336
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java cecb3f8b
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java
92b0e031
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java
e82d33d3
security-admin/src/main/java/org/apache/ranger/entity/XXServiceDef.java
3d496831
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 7818eb59
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 9e4d799b
Diff: https://reviews.apache.org/r/65793/diff/1/
Testing
---
Tested locally
Thanks,
Zsombor Gegesy
[jira] [Updated] (RANGER-1991) Fix problems detected by static code analysis
[
https://issues.apache.org/jira/browse/RANGER-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1991:
---
Attachment: RANGER-1991.patch
> Fix problems detected by static code analysis
> -
>
> Key: RANGER-1991
> URL: https://issues.apache.org/jira/browse/RANGER-1991
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: 0.7.1
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
>Priority: Minor
> Labels: code-cleanup, findbugs
> Attachments: RANGER-1991.patch
>
>
> FindBugs/SpotBug detects a couple of problems with the code base:
> * Incorrect class casting - in XXServiceDef.equals
> * Unnecessary NPE checks - for variables which is known to be non-null (for
> example, because in other places a method is called on that object). In
> ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in
> XUserMgr.java
> * Collection.contains method call which is never true - in
> ServiceDBStore.validatePolicyItems for policyItem.getAccesses().contains("")
> - because getAccesses doesn't store String objects
> * Making public partially initialized objects in
> HadoopConfigHolder.initResourceMap()
> * Calling toString on array, which is not too readable
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (RANGER-1991) Fix problems detected by static code analysis
Zsombor Gegesy created RANGER-1991:
--
Summary: Fix problems detected by static code analysis
Key: RANGER-1991
URL: https://issues.apache.org/jira/browse/RANGER-1991
Project: Ranger
Issue Type: Bug
Components: admin
Affects Versions: 0.7.1
Reporter: Zsombor Gegesy
Assignee: Zsombor Gegesy
FindBugs/SpotBug detects a couple of problems with the code base:
* Incorrect class casting - in XXServiceDef.equals
* Unnecessary NPE checks - for variables which is known to be non-null (for
example, because in other places a method is called on that object). In
ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in
XUserMgr.java
* Collection.contains method call which is never true - in
ServiceDBStore.validatePolicyItems for policyItem.getAccesses().contains("") -
because getAccesses doesn't store String objects
* Making public partially initialized objects in
HadoopConfigHolder.initResourceMap()
* Calling toString on array, which is not too readable
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RANGER-1987) Upgrade to Storm 1.2.0
[ https://issues.apache.org/jira/browse/RANGER-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375502#comment-16375502 ] Zsombor Gegesy commented on RANGER-1987: Commit merged to master: https://github.com/apache/ranger/commit/7514a9102b6649f0043220e0708a71d1ec6d0c77 > Upgrade to Storm 1.2.0 > -- > > Key: RANGER-1987 > URL: https://issues.apache.org/jira/browse/RANGER-1987 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1987-Upgrade-to-Storm-1.2.0.patch > > > > We should upgrade to the recently release Apache Storm 1.2.0. No code changes > are required. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-1967) The Ranger support the Kafka 1.0.0
[ https://issues.apache.org/jira/browse/RANGER-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375465#comment-16375465 ] Zsombor Gegesy commented on RANGER-1967: The updated review request is here: https://reviews.apache.org/r/65777/ > The Ranger support the Kafka 1.0.0 > -- > > Key: RANGER-1967 > URL: https://issues.apache.org/jira/browse/RANGER-1967 > Project: Ranger > Issue Type: New Feature > Components: plugins >Reporter: Qiang Zhang >Assignee: Zsombor Gegesy >Priority: Major > Labels: newbie, patch > Attachments: RANGER-1967-2.patch, RANGER-1967.patch > > > Now the Ranger don't support the Kafka 1.0.0. We should support the Kafka > 1.0.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-1967) The Ranger support the Kafka 1.0.0
[ https://issues.apache.org/jira/browse/RANGER-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1967: --- Attachment: RANGER-1967-2.patch > The Ranger support the Kafka 1.0.0 > -- > > Key: RANGER-1967 > URL: https://issues.apache.org/jira/browse/RANGER-1967 > Project: Ranger > Issue Type: New Feature > Components: plugins >Reporter: Qiang Zhang >Assignee: Zsombor Gegesy >Priority: Major > Labels: newbie, patch > Attachments: RANGER-1967-2.patch, RANGER-1967.patch > > > Now the Ranger don't support the Kafka 1.0.0. We should support the Kafka > 1.0.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 65777: RANGER-1967 - Kafka 1.0 support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65777/ --- (Updated Feb. 24, 2018, 10:08 a.m.) Review request for ranger. Changes --- Apache header for log4j.properties Bugs: RANGER-1967 https://issues.apache.org/jira/browse/RANGER-1967 Repository: ranger Description --- The API changes are not too big, however running Kafka in embedded mode turned out to be a bit trickier beast. I had to add a couple of new flags, otherwise it would wait for 2 other broker to join. The commit also contains logging changes, even a test log4j configuration, just to make the debugging easier. Diffs (updated) - agents-audit/pom.xml 4fa44c5f plugin-kafka/pom.xml f644646b plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b3d5a74d plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java 4ea39ed7 plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java fb541cd3 plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java fb0a2c0f plugin-kafka/src/test/resources/log4j.properties PRE-CREATION pom.xml fa1d1c7b ranger-kafka-plugin-shim/pom.xml f1aeee6f Diff: https://reviews.apache.org/r/65777/diff/2/ Changes: https://reviews.apache.org/r/65777/diff/1-2/ Testing --- Unit & local tests Thanks, Zsombor Gegesy
[jira] [Commented] (RANGER-1967) The Ranger support the Kafka 1.0.0
[ https://issues.apache.org/jira/browse/RANGER-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375448#comment-16375448 ] Ramesh Mani commented on RANGER-1967: - [~zsombor] Thanks for the patch. I see that log4j.properties file didn't have the apache header. Please added it and create an RR. Otherwise patch looks good! > The Ranger support the Kafka 1.0.0 > -- > > Key: RANGER-1967 > URL: https://issues.apache.org/jira/browse/RANGER-1967 > Project: Ranger > Issue Type: New Feature > Components: plugins >Reporter: Qiang Zhang >Assignee: Zsombor Gegesy >Priority: Major > Labels: newbie, patch > Attachments: RANGER-1967.patch > > > Now the Ranger don't support the Kafka 1.0.0. We should support the Kafka > 1.0.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 65709: RANGER-1987 - Upgrade to Storm 1.2.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65709/#review198251 --- Ship it! Ship It! - pengjianhua On 二月 19, 2018, 4:21 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65709/ > --- > > (Updated 二月 19, 2018, 4:21 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1987 > https://issues.apache.org/jira/browse/RANGER-1987 > > > Repository: ranger > > > Description > --- > > We should upgrade to the recently release Apache Storm 1.2.0. No code changes > are required. > > > Diffs > - > > pom.xml fa1d1c7b > > > Diff: https://reviews.apache.org/r/65709/diff/1/ > > > Testing > --- > > Tested Ranger with Storm 1.2.0. > > > Thanks, > > Colm O hEigeartaigh > >
