Re: Review Request 66170: RANGER-2031: Good coding practice in Ranger recommended by static code analysis

2018-03-20 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66170/#review199584
---


Ship it!




Ship It!

- Velmurugan Periasamy


On March 20, 2018, 4:19 a.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66170/
> ---
> 
> (Updated March 20, 2018, 4:19 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-2031
> https://issues.apache.org/jira/browse/RANGER-2031
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix code issues in Ranger recommended by static code analysis
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagForEval.java
>  524605d15 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValidityRecurrence.java
>  4bff3eaab 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValiditySchedule.java
>  8fe323181 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
>  4557b9f04 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java
>  8f996d11a 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 
> 86b4e4309 
> 
> 
> Diff: https://reviews.apache.org/r/66170/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

[jira] [Updated] (RANGER-1687) Atlas Resource based policy lists the 'Atlas types' JSON irrespective of the resource selected

2018-03-20 Thread Velmurugan Periasamy (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-1687:
-
Fix Version/s: 1.1.0

> Atlas Resource based policy lists the 'Atlas types' JSON irrespective of the 
> resource selected
> --
>
> Key: RANGER-1687
> URL: https://issues.apache.org/jira/browse/RANGER-1687
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Sharmadha Sainath
>Assignee: Deepak Sharma
>Priority: Major
> Fix For: 1.1.0
>
>
> Following are present in resource list for Atlas policy :
>  1.entity
>  2.type
>  3.taxonomy
>  4.term
>  5.operation
> For any resource selected and lookup made , following POST request is made :
> {code}
> http://rangerhost:6080/service/plugins/services/lookupResource/cl1_atlas
> {code}
> Response is the list of types in Atlas as JSON :
> {code}
> ["{\"results\":[\"hive_principal_type\",\"file_action\",\"hive_serde\",\"hive_order\",\"fs_permissions\",\"TaxonomyTerm\",\"falcon_process\",\"falcon_feed_replication\",\"DataSet\",\"falcon_feed_creation\",\"Process\",\"hive_table\",\"sqoop_dbdatastore\",\"hive_db\",\"storm_node\",\"hive_process\",\"hbase_column\",\"Referenceable\",\"falcon_feed\",\"hbase_table\",\"jms_topic\",\"storm_topology\",\"Infrastructure\",\"hbase_column_family\",\"storm_spout\",\"Asset\",\"hive_column\",\"kafka_topic\",\"hive_storagedesc\",\"hdfs_path\",\"sqoop_process\",\"hive_column_lineage\",\"storm_bolt\",\"falcon_cluster\",\"fs_path\"],\"count\":35,\"requestId\":\"pool-2-thread-9
>  - dbf4e4ea-bfd3-49a7-86a2-b381c905f7fd\"}"]
> {code}
> No other results are shown other than the above JSON.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ANNOUNCE] Apache Ranger 1.0.0 released

2018-03-20 Thread Sailaja Polavarapu 
The Apache Ranger team is pleased to announce the immediate availability of the 
1.0.0 release. This is a major release after 0.7.1, with 463 bug fixes and 
enhancements.

The following release activities are completed:
1. Updated ranger-1.0 branch – version is set to 1.0.1-SNAPSHOT
2. Updated doc to have proper download/release-notes links for 1.0.0
3. Binary Release is build/staged/verified/released.
4. In JIRA, Release 1.0.0 is marked as Complete.  Release version 1.0.1. is 
created to track all further minor release.

All of the changes in this release can be found in:
https://cwiki.apache.org/confluence/display/RANGER/Apache+Ranger+1.0.0+-+Release+Notes

You can download the source release and binary packages from Apache Ranger’s 
download page: https://ranger.apache.org/download.html

Thanks everyone who have contributed to the 1.0.0 release.

We welcome your help and feedback. For more information on how to report 
problems, and to get involved, visit the project website at 
https://ranger.apache.org/

Thanks,
Sailaja

On 3/19/18, 10:13 AM, "Sailaja Polavarapu"  wrote:

Hello Rangers:

Thank you so much for your efforts to validate Apache Ranger 1.0.0 release 
candidate #1 and your feedback/vote.

More than 72 hours have passed and the current vote thread is considered 
concluded and passes with the following resolution:

Five +1 votes from the following PPMC member(s):
+1 Colm O hEigeartaigh
+1 Ramesh Mani
+1 Selvamohan Neethiraj
+1 Velmurugan Periasamy
+1 Abhay Kulkarni

Nine +1 votes from the following committers/contributors:
+1 Nitin Galave
+1 Qiang Zhang
+1 Sailaja Polavarapu
+1 Jianhua Peng
+1 Pradeep Agrawal
+1 Zsombor Gegesy
+1 Nixon Rodrigues
+1 Vishal Suvagia
+1 Mehul Parikh

Zero -1 votes:

I will start the process of moving the release artifacts to the mirrors and 
other release activities.

Voting thread for reference -

https://lists.apache.org/thread.html/7f09931843955a0d39979e46c1970866dbc730cedef3952910674fdc@%3Cdev.ranger.apache.org%3E

Issues fixed in this release - 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75975356

Thanks,
Sailaja

[jira] [Updated] (RANGER-2030) UI updates to accommodate policy effective dates

2018-03-20 Thread Pradeep Agrawal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Agrawal updated RANGER-2030:

Fix Version/s: (was: master)

> UI updates to accommodate policy effective dates
> 
>
> Key: RANGER-2030
> URL: https://issues.apache.org/jira/browse/RANGER-2030
> Project: Ranger
>  Issue Type: Sub-task
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: RANGER-2030.1.patch, UI-RANGER-2030.patch
>
>
> Policy screens should support effective dates.(i.e policy start time, end 
> time and timezone)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (RANGER-2030) UI updates to accommodate policy effective dates

2018-03-20 Thread Pradeep Agrawal (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406138#comment-16406138
 ] 

Pradeep Agrawal edited comment on RANGER-2030 at 3/20/18 11:05 AM:
---

Patch of RR [https://reviews.apache.org/r/66135/] committed to master branch : 
[https://github.com/apache/ranger/commit/ab2a7df91736451fe0c1d0e43287b740394f169c]


was (Author: pradeep.agrawal):
Patch committed to master branch : 
https://github.com/apache/ranger/commit/ab2a7df91736451fe0c1d0e43287b740394f169c

> UI updates to accommodate policy effective dates
> 
>
> Key: RANGER-2030
> URL: https://issues.apache.org/jira/browse/RANGER-2030
> Project: Ranger
>  Issue Type: Sub-task
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: master, 1.1.0
>
> Attachments: RANGER-2030.1.patch, UI-RANGER-2030.patch
>
>
> Policy screens should support effective dates.(i.e policy start time, end 
> time and timezone)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2030) UI updates to accommodate policy effective dates

2018-03-20 Thread Pradeep Agrawal (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406138#comment-16406138
 ] 

Pradeep Agrawal commented on RANGER-2030:
-

Patch committed to master branch : 
https://github.com/apache/ranger/commit/ab2a7df91736451fe0c1d0e43287b740394f169c

> UI updates to accommodate policy effective dates
> 
>
> Key: RANGER-2030
> URL: https://issues.apache.org/jira/browse/RANGER-2030
> Project: Ranger
>  Issue Type: Sub-task
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: master, 1.1.0
>
> Attachments: RANGER-2030.1.patch, UI-RANGER-2030.patch
>
>
> Policy screens should support effective dates.(i.e policy start time, end 
> time and timezone)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2030) UI updates to accommodate policy effective dates

2018-03-20 Thread Nitin Galave (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406137#comment-16406137
 ] 

Nitin Galave commented on RANGER-2030:
--

Committed to 
[master|https://github.com/apache/ranger/commit/ab2a7df91736451fe0c1d0e43287b740394f169c]
 branch.

> UI updates to accommodate policy effective dates
> 
>
> Key: RANGER-2030
> URL: https://issues.apache.org/jira/browse/RANGER-2030
> Project: Ranger
>  Issue Type: Sub-task
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: master, 1.1.0
>
> Attachments: RANGER-2030.1.patch, UI-RANGER-2030.patch
>
>
> Policy screens should support effective dates.(i.e policy start time, end 
> time and timezone)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66135: RANGER-2030: UI updates to accommodate policy effective dates

2018-03-20 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199537
---


Ship it!




Ship It!

- Gautam Borad


On March 20, 2018, 10:51 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> ---
> 
> (Updated March 20, 2018, 10:51 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Policy screens should support effective dates(i.e policy start time, end time 
> and timezone).
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/index.html d8a5d98 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js c388a79 
>   security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 8afc2e6 
>   security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5 
>   security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js 
> PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
> 4b15ab7 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 04dad2e 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> fa7f191 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  f23d18c 
>   security-admin/src/main/webapp/styles/xa.css 9eb99d9 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html 
> PRE-CREATION 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html 
> PRE-CREATION 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html
>  78a56c6 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 
> 859aced 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 
> 6d2eb3f 
> 
> 
> Diff: https://reviews.apache.org/r/66135/diff/3/
> 
> 
> Testing
> ---
> 
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

Re: Review Request 66135: RANGER-2030: UI updates to accommodate policy effective dates

2018-03-20 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199536
---


Ship it!




Ship It!

- Zsombor Gegesy


On March 20, 2018, 10:51 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> ---
> 
> (Updated March 20, 2018, 10:51 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Policy screens should support effective dates(i.e policy start time, end time 
> and timezone).
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/index.html d8a5d98 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js c388a79 
>   security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 8afc2e6 
>   security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5 
>   security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js 
> PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
> 4b15ab7 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 04dad2e 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> fa7f191 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  f23d18c 
>   security-admin/src/main/webapp/styles/xa.css 9eb99d9 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html 
> PRE-CREATION 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html 
> PRE-CREATION 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html
>  78a56c6 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 
> 859aced 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 
> 6d2eb3f 
> 
> 
> Diff: https://reviews.apache.org/r/66135/diff/3/
> 
> 
> Testing
> ---
> 
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

Re: Review Request 66135: RANGER-2030: UI updates to accommodate policy effective dates

2018-03-20 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/
---

(Updated March 20, 2018, 10:51 a.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and 
Velmurugan Periasamy.


Bugs: RANGER-2030
https://issues.apache.org/jira/browse/RANGER-2030


Repository: ranger


Description
---

Policy screens should support effective dates(i.e policy start time, end time 
and timezone).


Diffs (updated)
-

  security-admin/src/main/webapp/index.html d8a5d98 
  
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css
 PRE-CREATION 
  
security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js
 PRE-CREATION 
  security-admin/src/main/webapp/scripts/Init.js c388a79 
  security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
8afc2e6 
  security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5 
  security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js 
PRE-CREATION 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
4b15ab7 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
04dad2e 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
fa7f191 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 f23d18c 
  security-admin/src/main/webapp/styles/xa.css 9eb99d9 
  security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3 
  security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html 
PRE-CREATION 
  security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html 
PRE-CREATION 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 
78a56c6 
  security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 
859aced 
  security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 
6d2eb3f 


Diff: https://reviews.apache.org/r/66135/diff/3/

Changes: https://reviews.apache.org/r/66135/diff/2-3/


Testing
---

1.Able to create policy by adding start date, end date and timezone.
2.Able to create a policy with multiple validity time
3.Also tested Policy CRUD.
4.Checked policy enforcement for time-based /normal policy.


Thanks,

Nitin Galave

Re: Review Request 66135: RANGER-2030: UI updates to accommodate policy effective dates

2018-03-20 Thread Nitin Galave 


> On March 20, 2018, 8:42 a.m., Zsombor Gegesy wrote:
> > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
> > Lines 212 (patched)
> > 
> >
> > Why this is commented out? The two html fragment looks the same - 
> > except this commented out part

Becuase policy expired indication feature we are handling as part of another 
improvement patch.


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199528
---


On March 20, 2018, 10:51 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> ---
> 
> (Updated March 20, 2018, 10:51 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Policy screens should support effective dates(i.e policy start time, end time 
> and timezone).
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/index.html d8a5d98 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js c388a79 
>   security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 8afc2e6 
>   security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5 
>   security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js 
> PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
> 4b15ab7 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 04dad2e 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> fa7f191 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  f23d18c 
>   security-admin/src/main/webapp/styles/xa.css 9eb99d9 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html 
> PRE-CREATION 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html 
> PRE-CREATION 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html
>  78a56c6 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 
> 859aced 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 
> 6d2eb3f 
> 
> 
> Diff: https://reviews.apache.org/r/66135/diff/3/
> 
> 
> Testing
> ---
> 
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

[jira] [Updated] (RANGER-2030) UI updates to accommodate policy effective dates

2018-03-20 Thread Nitin Galave (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Galave updated RANGER-2030:
-
Attachment: RANGER-2030.1.patch

> UI updates to accommodate policy effective dates
> 
>
> Key: RANGER-2030
> URL: https://issues.apache.org/jira/browse/RANGER-2030
> Project: Ranger
>  Issue Type: Sub-task
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: master, 1.1.0
>
> Attachments: RANGER-2030.1.patch, UI-RANGER-2030.patch
>
>
> Policy screens should support effective dates.(i.e policy start time, end 
> time and timezone)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66135: RANGER-2030: UI updates to accommodate policy effective dates

2018-03-20 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66135/#review199528
---




security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js
Lines 154 (patched)


I'm not native, but for me, 'later than' would be more understandable. Or, 
just please fix the typo: 'greate' -> 'greater'



security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
Lines 212 (patched)


Why this is commented out? The two html fragment looks the same - except 
this commented out part


- Zsombor Gegesy


On March 20, 2018, 4:19 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66135/
> ---
> 
> (Updated March 20, 2018, 4:19 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Policy screens should support effective dates(i.e policy start time, end time 
> and timezone).
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/index.html d8a5d98 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js c388a79 
>   security-admin/src/main/webapp/scripts/models/RangerPolicy.js b1fb143 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 8afc2e6 
>   security-admin/src/main/webapp/scripts/utils/XAGlobals.js d55ab4a 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js c1e6ef5 
>   security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js 
> PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 
> 4b15ab7 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 04dad2e 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> fa7f191 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  f23d18c 
>   security-admin/src/main/webapp/styles/xa.css 9eb99d9 
>   security-admin/src/main/webapp/templates/helpers/XAHelpers.js 946b6a3 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html 
> PRE-CREATION 
>   security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html 
> PRE-CREATION 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html
>  78a56c6 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 
> 859aced 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 
> 6d2eb3f 
> 
> 
> Diff: https://reviews.apache.org/r/66135/diff/2/
> 
> 
> Testing
> ---
> 
> 1.Able to create policy by adding start date, end date and timezone.
> 2.Able to create a policy with multiple validity time
> 3.Also tested Policy CRUD.
> 4.Checked policy enforcement for time-based /normal policy.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

[jira] [Created] (RANGER-2032) Use consolidated and optimized DB schema script for fresh install of Ranger

2018-03-20 Thread Pradeep Agrawal (JIRA) 
Pradeep Agrawal created RANGER-2032:
---

 Summary: Use consolidated and optimized DB schema script for fresh 
install of Ranger
 Key: RANGER-2032
 URL: https://issues.apache.org/jira/browse/RANGER-2032
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Pradeep Agrawal
Assignee: Pradeep Agrawal
 Fix For: 1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-20 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/#review199527
---


Ship it!




Ship It!

- Zsombor Gegesy


On March 20, 2018, 7:39 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66089/
> ---
> 
> (Updated March 20, 2018, 7:39 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
> Parikh, suja s, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2018
> https://issues.apache.org/jira/browse/RANGER-2018
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here I am proposing to change Spring Security to 4.2.4 and Spring Framework 
> to 4.3.14.
> 
> 
> Diffs
> -
> 
>   pom.xml 1df5f2c 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
>  d9c2bcf 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
>  370df70 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 0dda56b 
>   security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
>   security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
> 10f1a84 
>   security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
> a9fb632 
>   security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
>   security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
>   
> security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
>  3dc6413 
> 
> 
> Diff: https://reviews.apache.org/r/66089/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the Ranger admin installation, user login, ldap authentication , 
> usersync and other crud operations on service, policy, user and group module.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 66170: RANGER-2031: Good coding practice in Ranger recommended by static code analysis

2018-03-20 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66170/#review199526
---


Ship it!




Ship It!

- Zsombor Gegesy


On March 20, 2018, 4:19 a.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66170/
> ---
> 
> (Updated March 20, 2018, 4:19 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-2031
> https://issues.apache.org/jira/browse/RANGER-2031
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix code issues in Ranger recommended by static code analysis
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagForEval.java
>  524605d15 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValidityRecurrence.java
>  4bff3eaab 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValiditySchedule.java
>  8fe323181 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
>  4557b9f04 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java
>  8f996d11a 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 
> 86b4e4309 
> 
> 
> Diff: https://reviews.apache.org/r/66170/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-20 Thread Pradeep Agrawal 


> On March 19, 2018, 2:21 p.m., Zsombor Gegesy wrote:
> > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
> > Line 63 (original), 64 (patched)
> > 
> >
> > This "Value" annotation is not needed, isn't it? The loginFormUrl is 
> > specified in the XML, this value would be used only if the 
> > RangerAuthenticationEntryPoint would be initialized by some other 
> > auto-magic. Honestly, I would love if everything could be configured 
> > without XML, but this is a bit confusing now.

Yes, its not needed. The change was aligned with XML. There is no change in the 
working of Ranger with or without @Value annotation so it can be removed.


- Pradeep


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/#review199415
---


On March 20, 2018, 7:39 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66089/
> ---
> 
> (Updated March 20, 2018, 7:39 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
> Parikh, suja s, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2018
> https://issues.apache.org/jira/browse/RANGER-2018
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here I am proposing to change Spring Security to 4.2.4 and Spring Framework 
> to 4.3.14.
> 
> 
> Diffs
> -
> 
>   pom.xml 1df5f2c 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
>  d9c2bcf 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
>  370df70 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 0dda56b 
>   security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
>   security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
> 10f1a84 
>   security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
> a9fb632 
>   security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
>   security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
>   
> security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
>  3dc6413 
> 
> 
> Diff: https://reviews.apache.org/r/66089/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the Ranger admin installation, user login, ldap authentication , 
> usersync and other crud operations on service, policy, user and group module.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-20 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/
---

(Updated March 20, 2018, 7:39 a.m.)


Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
Parikh, suja s, and Velmurugan Periasamy.


Changes
---

Addressed review comments.


Bugs: RANGER-2018
https://issues.apache.org/jira/browse/RANGER-2018


Repository: ranger


Description
---

Here I am proposing to change Spring Security to 4.2.4 and Spring Framework to 
4.3.14.


Diffs (updated)
-

  pom.xml 1df5f2c 
  
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
 d9c2bcf 
  
security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
 370df70 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
0dda56b 
  security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
  security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
10f1a84 
  security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
a9fb632 
  security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
  security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
  security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
  
security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
 3dc6413 


Diff: https://reviews.apache.org/r/66089/diff/2/

Changes: https://reviews.apache.org/r/66089/diff/1-2/


Testing
---

Tested the Ranger admin installation, user login, ldap authentication , 
usersync and other crud operations on service, policy, user and group module.


Thanks,

Pradeep Agrawal