Re: Review Request 66946: Good coding practice for ranger response codes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66946/#review202441 --- Ship it! Ship It! - Velmurugan Periasamy On May 4, 2018, 10:26 a.m., Nikhil P wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66946/ > --- > > (Updated May 4, 2018, 10:26 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2091 > https://issues.apache.org/jira/browse/RANGER-2091 > > > Repository: ranger > > > Description > --- > > Good coding practice for ranger response codes > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java > de3891e > > > Diff: https://reviews.apache.org/r/66946/diff/1/ > > > Testing > --- > > 1)Tested on simple as well as kerberised environment. > 2)Tested with Knox SSO,Knox Proxy, wire encryption. > > > Thanks, > > Nikhil P > >
Re: Review Request 66945: RANGER-2094 : Handle Export Policy feature for different browsers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66945/#review202440 --- Ship it! Ship It! - Velmurugan Periasamy On May 4, 2018, 7:03 a.m., Mehul Parikh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66945/ > --- > > (Updated May 4, 2018, 7:03 a.m.) > > > Review request for ranger, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2094 > https://issues.apache.org/jira/browse/RANGER-2094 > > > Repository: ranger > > > Description > --- > > Policies are not getting exported in Firefox 59. > "Add validity period" button is not working in Internet Explore 11. > > > Diffs > - > > > security-admin/src/main/webapp/libs/bower/moment/js/moment-timezone-with-data.min.js > PRE-CREATION > > security-admin/src/main/webapp/libs/bower/moment/js/moment-with-langs.min.js > 15a339c > > security-admin/src/main/webapp/libs/bower/moment/js/moment-with-locales.min.js > PRE-CREATION > security-admin/src/main/webapp/scripts/Init.js 4de6b6d > security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js b64f911 > security-admin/src/main/webapp/scripts/utils/XAUtils.js ed83669 > security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js > fc8edbb > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 0a6b16c > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js cb13908 > > security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html > e608a0f > security-admin/src/main/webapp/templates/helpers/XAHelpers.js e58bece > > > Diff: https://reviews.apache.org/r/66945/diff/1/ > > > Testing > --- > > Verified Import Export feature on firefox as well as IE and chrome. > Also verified Add validaity feature on all 3 browsers. > > Did sanity testing on Firefox, Chrome and IE 11. > > > Thanks, > > Mehul Parikh > >
Review Request 66951: RANGER-2095 : Add unit tests for new read only admin-auditor/kms-auditor roles functionality
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66951/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-2095 https://issues.apache.org/jira/browse/RANGER-2095 Repository: ranger Description --- Add unit tests for new read only admin-auditor/kms-auditor roles functionality Diffs - security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a0477fb security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 10e517f security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 9182195 Diff: https://reviews.apache.org/r/66951/diff/1/ Testing --- Tested with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, bhavik patel
[jira] [Updated] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality
[ https://issues.apache.org/jira/browse/RANGER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bhavik patel updated RANGER-2095: - Attachment: RANGER-2095-master.patch > Add unit tests for new read only admin-auditor/kms-auditor roles functionality > -- > > Key: RANGER-2095 > URL: https://issues.apache.org/jira/browse/RANGER-2095 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: bhavik patel >Assignee: bhavik patel >Priority: Critical > Attachments: RANGER-2095-master.patch > > > Add unit tests for new read only admin-auditor/kms-auditor roles functionality -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 66946: Good coding practice for ranger response codes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66946/#review202434 --- Ship it! Ship It! - Zsombor Gegesy On May 4, 2018, 10:26 a.m., Nikhil P wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66946/ > --- > > (Updated May 4, 2018, 10:26 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2091 > https://issues.apache.org/jira/browse/RANGER-2091 > > > Repository: ranger > > > Description > --- > > Good coding practice for ranger response codes > > > Diffs > - > > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java > de3891e > > > Diff: https://reviews.apache.org/r/66946/diff/1/ > > > Testing > --- > > 1)Tested on simple as well as kerberised environment. > 2)Tested with Knox SSO,Knox Proxy, wire encryption. > > > Thanks, > > Nikhil P > >
Review Request 66950: RANGER-2096 - remove dead code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66950/ --- Review request for ranger. Bugs: RANGER-2096 https://issues.apache.org/jira/browse/RANGER-2096 Repository: ranger Description --- There is unnecessary dead code in AbstractBaseResourceService.java, which stores the child services in a service map, which is only called from RangerBizUtil.getVObject/getMObject methods, which are only called from test method. This can be removed safely. Diffs - security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a0477fb1c security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java a64bb3048 security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 10e517fb1 Diff: https://reviews.apache.org/r/66950/diff/1/ Testing --- Tested locally, and on a cluster Thanks, Zsombor Gegesy
[jira] [Updated] (RANGER-2096) Remove dead code from AbstractBaseResourceService and RangerBizUtil
[ https://issues.apache.org/jira/browse/RANGER-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2096: --- Attachment: RANGER-2096.patch > Remove dead code from AbstractBaseResourceService and RangerBizUtil > --- > > Key: RANGER-2096 > URL: https://issues.apache.org/jira/browse/RANGER-2096 > Project: Ranger > Issue Type: Bug > Components: admin >Affects Versions: 1.0.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: code-cleanup > Fix For: 1.1.0 > > Attachments: RANGER-2096.patch > > > There is unnecessary dead code in AbstractBaseResourceService.java, which > stores the child services in a service map, which is only called from > RangerBizUtil.getVObject/getMObject methods, which are only called from test > method. > This can be removed safely. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2096) Remove dead code from AbstractBaseResourceService and RangerBizUtil
Zsombor Gegesy created RANGER-2096: -- Summary: Remove dead code from AbstractBaseResourceService and RangerBizUtil Key: RANGER-2096 URL: https://issues.apache.org/jira/browse/RANGER-2096 Project: Ranger Issue Type: Bug Components: admin Affects Versions: 1.0.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.1.0 There is unnecessary dead code in AbstractBaseResourceService.java, which stores the child services in a service map, which is only called from RangerBizUtil.getVObject/getMObject methods, which are only called from test method. This can be removed safely. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Review Request 66946: Good coding practice for ranger response codes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66946/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-2091 https://issues.apache.org/jira/browse/RANGER-2091 Repository: ranger Description --- Good coding practice for ranger response codes Diffs - security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java de3891e Diff: https://reviews.apache.org/r/66946/diff/1/ Testing --- 1)Tested on simple as well as kerberised environment. 2)Tested with Knox SSO,Knox Proxy, wire encryption. Thanks, Nikhil P
[jira] [Updated] (RANGER-2091) Good coding practice for ranger response codes.
[ https://issues.apache.org/jira/browse/RANGER-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Purbhe updated RANGER-2091: -- Attachment: RANGER-2091-Good-coding-practice-for-ranger-response.patch > Good coding practice for ranger response codes. > --- > > Key: RANGER-2091 > URL: https://issues.apache.org/jira/browse/RANGER-2091 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Nikhil Purbhe >Assignee: Nikhil Purbhe >Priority: Major > Fix For: 1.1.0 > > Attachments: > RANGER-2091-Good-coding-practice-for-ranger-response.patch > > > Good coding practice for ranger response codes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality
bhavik patel created RANGER-2095: Summary: Add unit tests for new read only admin-auditor/kms-auditor roles functionality Key: RANGER-2095 URL: https://issues.apache.org/jira/browse/RANGER-2095 Project: Ranger Issue Type: Improvement Components: Ranger Reporter: bhavik patel Assignee: bhavik patel Add unit tests for new read only admin-auditor/kms-auditor roles functionality -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 66945: RANGER-2094 : Handle Export Policy feature for different browsers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66945/#review202422 --- Ship it! Ship It! - Gautam Borad On May 4, 2018, 7:03 a.m., Mehul Parikh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66945/ > --- > > (Updated May 4, 2018, 7:03 a.m.) > > > Review request for ranger, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2094 > https://issues.apache.org/jira/browse/RANGER-2094 > > > Repository: ranger > > > Description > --- > > Policies are not getting exported in Firefox 59. > "Add validity period" button is not working in Internet Explore 11. > > > Diffs > - > > > security-admin/src/main/webapp/libs/bower/moment/js/moment-timezone-with-data.min.js > PRE-CREATION > > security-admin/src/main/webapp/libs/bower/moment/js/moment-with-langs.min.js > 15a339c > > security-admin/src/main/webapp/libs/bower/moment/js/moment-with-locales.min.js > PRE-CREATION > security-admin/src/main/webapp/scripts/Init.js 4de6b6d > security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js b64f911 > security-admin/src/main/webapp/scripts/utils/XAUtils.js ed83669 > security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js > fc8edbb > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 0a6b16c > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js cb13908 > > security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html > e608a0f > security-admin/src/main/webapp/templates/helpers/XAHelpers.js e58bece > > > Diff: https://reviews.apache.org/r/66945/diff/1/ > > > Testing > --- > > Verified Import Export feature on firefox as well as IE and chrome. > Also verified Add validaity feature on all 3 browsers. > > Did sanity testing on Firefox, Chrome and IE 11. > > > Thanks, > > Mehul Parikh > >
Review Request 66945: RANGER-2094 : Handle Export Policy feature for different browsers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66945/ --- Review request for ranger, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-2094 https://issues.apache.org/jira/browse/RANGER-2094 Repository: ranger Description --- Policies are not getting exported in Firefox 59. "Add validity period" button is not working in Internet Explore 11. Diffs - security-admin/src/main/webapp/libs/bower/moment/js/moment-timezone-with-data.min.js PRE-CREATION security-admin/src/main/webapp/libs/bower/moment/js/moment-with-langs.min.js 15a339c security-admin/src/main/webapp/libs/bower/moment/js/moment-with-locales.min.js PRE-CREATION security-admin/src/main/webapp/scripts/Init.js 4de6b6d security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js b64f911 security-admin/src/main/webapp/scripts/utils/XAUtils.js ed83669 security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js fc8edbb security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0a6b16c security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js cb13908 security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html e608a0f security-admin/src/main/webapp/templates/helpers/XAHelpers.js e58bece Diff: https://reviews.apache.org/r/66945/diff/1/ Testing --- Verified Import Export feature on firefox as well as IE and chrome. Also verified Add validaity feature on all 3 browsers. Did sanity testing on Firefox, Chrome and IE 11. Thanks, Mehul Parikh
