[jira] [Commented] (RANGER-2182) Handle upgrade scenario since atlas-service def is added with new resources for relationship

2018-08-02 Thread bhavik patel (JIRA)


[ 
https://issues.apache.org/jira/browse/RANGER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567772#comment-16567772
 ] 

bhavik patel commented on RANGER-2182:
--

In addition to handling service-def updates, the upgrade should add a policy 
that lets all users be able to create all relationships:
 - resources: relationship-type=*, end-one-entity-type=*, 
end-one-entity-classification=*, end-one-entity=*, end-two-entity-type=*, 
end-two-entity-classification=*, end-two-entity=*
 - groups: public
 - accessTypes: add-relationship, update-relationship, remove-relationship

> Handle upgrade scenario since atlas-service def is added with new resources 
> for relationship
> 
>
> Key: RANGER-2182
> URL: https://issues.apache.org/jira/browse/RANGER-2182
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 2.0.0
>Reporter: bhavik patel
>Assignee: bhavik patel
>Priority: Critical
>
> Handle upgrade scenario in Ranger since atlas-service def is added with new 
> resources for relationship authorization after 1.x release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (RANGER-2182) Handle upgrade scenario since atlas-service def is added with new resources for relationship

2018-08-02 Thread bhavik patel (JIRA)


 [ 
https://issues.apache.org/jira/browse/RANGER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bhavik patel updated RANGER-2182:
-
Description: Handle upgrade scenario in Ranger since atlas-service def is 
added with new resources for relationship authorization after 1.x release

> Handle upgrade scenario since atlas-service def is added with new resources 
> for relationship
> 
>
> Key: RANGER-2182
> URL: https://issues.apache.org/jira/browse/RANGER-2182
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 2.0.0
>Reporter: bhavik patel
>Assignee: bhavik patel
>Priority: Critical
>
> Handle upgrade scenario in Ranger since atlas-service def is added with new 
> resources for relationship authorization after 1.x release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (RANGER-2182) Handle upgrade scenario since atlas-service def is added with new resources for relationship

2018-08-02 Thread bhavik patel (JIRA)
bhavik patel created RANGER-2182:


 Summary: Handle upgrade scenario since atlas-service def is added 
with new resources for relationship
 Key: RANGER-2182
 URL: https://issues.apache.org/jira/browse/RANGER-2182
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: 2.0.0
Reporter: bhavik patel
Assignee: bhavik patel






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (RANGER-2181) Code Improvement To Follow Best Practices

2018-08-02 Thread Mehul Parikh (JIRA)
Mehul Parikh created RANGER-2181:


 Summary: Code Improvement To Follow Best Practices
 Key: RANGER-2181
 URL: https://issues.apache.org/jira/browse/RANGER-2181
 Project: Ranger
  Issue Type: Bug
  Components: admin
Affects Versions: 1.1.0
Reporter: Mehul Parikh
Assignee: bhavik patel
 Fix For: 2.0.0


Code Improvement To Follow Best Practices for saving services. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-02 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206829
---


Ship it!




Ship It!

- pengjianhua


On Aug. 2, 2018, 7:42 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated Aug. 2, 2018, 7:42 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> 1e3554f03 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  83253e43a 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>



Re: Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

2018-08-02 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/#review206822
---


Ship it!




Ship It!

- Ramesh Mani


On Aug. 2, 2018, 7:52 p.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68170/
> ---
> 
> (Updated Aug. 2, 2018, 7:52 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2172
> https://issues.apache.org/jira/browse/RANGER-2172
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Changed code to read only STRLEN-1 characters using sscanf in order to 
> correctly accommodate the array size.
> 
> 
> Diffs
> -
> 
>   unixauthnative/src/main/c/credValidator.c 189c2ca5e 
>   unixauthpam/src/main/c/pamCredValidator.c 8e3690301 
> 
> 
> Diff: https://reviews.apache.org/r/68170/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually from command line.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>



Re: Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

2018-08-02 Thread Selvamohan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/#review206821
---


Ship it!




Ship It!

- Selvamohan Neethiraj


On Aug. 2, 2018, 3:52 p.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68170/
> ---
> 
> (Updated Aug. 2, 2018, 3:52 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2172
> https://issues.apache.org/jira/browse/RANGER-2172
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Changed code to read only STRLEN-1 characters using sscanf in order to 
> correctly accommodate the array size.
> 
> 
> Diffs
> -
> 
>   unixauthnative/src/main/c/credValidator.c 189c2ca5e 
>   unixauthpam/src/main/c/pamCredValidator.c 8e3690301 
> 
> 
> Diff: https://reviews.apache.org/r/68170/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually from command line.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>



Re: Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

2018-08-02 Thread Velmurugan Periasamy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/#review206820
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Aug. 2, 2018, 7:52 p.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68170/
> ---
> 
> (Updated Aug. 2, 2018, 7:52 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2172
> https://issues.apache.org/jira/browse/RANGER-2172
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Changed code to read only STRLEN-1 characters using sscanf in order to 
> correctly accommodate the array size.
> 
> 
> Diffs
> -
> 
>   unixauthnative/src/main/c/credValidator.c 189c2ca5e 
>   unixauthpam/src/main/c/pamCredValidator.c 8e3690301 
> 
> 
> Diff: https://reviews.apache.org/r/68170/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually from command line.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>



Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

2018-08-02 Thread Sailaja Polavarapu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/
---

Review request for ranger.


Bugs: RANGER-2172
https://issues.apache.org/jira/browse/RANGER-2172


Repository: ranger


Description
---

Changed code to read only STRLEN-1 characters using sscanf in order to 
correctly accommodate the array size.


Diffs
-

  unixauthnative/src/main/c/credValidator.c 189c2ca5e 
  unixauthpam/src/main/c/pamCredValidator.c 8e3690301 


Diff: https://reviews.apache.org/r/68170/diff/1/


Testing
---

Tested manually from command line.


Thanks,

Sailaja Polavarapu



[jira] [Reopened] (RANGER-2172) Good coding practices for unix authentication Service in Ranger

2018-08-02 Thread Sailaja Polavarapu (JIRA)


 [ 
https://issues.apache.org/jira/browse/RANGER-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sailaja Polavarapu reopened RANGER-2172:


Found a minor issue as part of the code review. Hence reopening the bug.

> Good coding practices for unix authentication Service in Ranger
> ---
>
> Key: RANGER-2172
> URL: https://issues.apache.org/jira/browse/RANGER-2172
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.1.0
>Reporter: Sailaja Polavarapu
>Assignee: Sailaja Polavarapu
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2172-Good-coding-practices-for-unix-authentic.patch
>
>
> Good coding practices for unix authentication Service in Ranger



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-02 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206795
---


Ship it!




Ship It!

- Nitin Galave


On Aug. 2, 2018, 7:42 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated Aug. 2, 2018, 7:42 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> 1e3554f03 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  83253e43a 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>



[jira] [Updated] (RANGER-2153) Supply the function of reverting policy history version.

2018-08-02 Thread Qiang Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/RANGER-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-2153:

Attachment: (was: 
0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch)

> Supply the function of reverting policy history version.
> 
>
> Key: RANGER-2153
> URL: https://issues.apache.org/jira/browse/RANGER-2153
> Project: Ranger
>  Issue Type: New Feature
>  Components: Ranger
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2153-Supply-the-function-of-reverting-policy-.patch, 
> 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch, 
> no-resolved-button.png, ranger-01.PNG
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (RANGER-2153) Supply the function of reverting policy history version.

2018-08-02 Thread Qiang Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/RANGER-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-2153:

Attachment: 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch

> Supply the function of reverting policy history version.
> 
>
> Key: RANGER-2153
> URL: https://issues.apache.org/jira/browse/RANGER-2153
> Project: Ranger
>  Issue Type: New Feature
>  Components: Ranger
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2153-Supply-the-function-of-reverting-policy-.patch, 
> 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch, 
> no-resolved-button.png, ranger-01.PNG
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-02 Thread Qiang Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/
---

(Updated 八月 2, 2018, 7:42 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, 
sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Changes
---

Fix an issue that the table is not loaded


Bugs: RANGER-2153
https://issues.apache.org/jira/browse/RANGER-2153


Repository: ranger


Description
---

Supply the function of reverting policy history version.


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
1e3554f03 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 83253e43a 


Diff: https://reviews.apache.org/r/68010/diff/3/

Changes: https://reviews.apache.org/r/68010/diff/2-3/


Testing
---


File Attachments


0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch


Thanks,

Qiang Zhang