Review Request 69488: RANGER-2298 Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties

2018-11-29 Thread Qiang Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69488/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, 
pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
Polavarapu, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Bugs: RANGER-2298
https://issues.apache.org/jira/browse/RANGER-2298


Repository: ranger


Description
---

Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties


Diffs
-

  kms/scripts/install.properties 947d9f389 
  security-admin/scripts/install.properties 674844cec 


Diff: https://reviews.apache.org/r/69488/diff/1/


Testing
---


Thanks,

Qiang Zhang



[jira] [Commented] (RANGER-2298) Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties

2018-11-29 Thread Qiang Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/RANGER-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704358#comment-16704358
 ] 

Qiang Zhang commented on RANGER-2298:
-

Review Requet:
https://reviews.apache.org/r/69488/

> Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties
> -
>
> Key: RANGER-2298
> URL: https://issues.apache.org/jira/browse/RANGER-2298
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, kms
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
>  Labels: patch
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2298-Modify-JAVA_VERSION_REQUIRED-to-1.8-in-i.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (RANGER-2298) Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties

2018-11-29 Thread Qiang Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/RANGER-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-2298:

Attachment: 0001-RANGER-2298-Modify-JAVA_VERSION_REQUIRED-to-1.8-in-i.patch

> Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties
> -
>
> Key: RANGER-2298
> URL: https://issues.apache.org/jira/browse/RANGER-2298
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, kms
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
>  Labels: patch
> Fix For: 2.0.0
>
> Attachments: 
> 0001-RANGER-2298-Modify-JAVA_VERSION_REQUIRED-to-1.8-in-i.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (RANGER-2298) Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties

2018-11-29 Thread Qiang Zhang (JIRA)
Qiang Zhang created RANGER-2298:
---

 Summary: Modify JAVA_VERSION_REQUIRED to 1.8 in install.properties
 Key: RANGER-2298
 URL: https://issues.apache.org/jira/browse/RANGER-2298
 Project: Ranger
  Issue Type: Bug
  Components: admin, kms
Affects Versions: master
Reporter: Qiang Zhang
Assignee: Qiang Zhang
 Fix For: 2.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (RANGER-2297) getContentSummary validation failure

2018-11-29 Thread Abhay Kulkarni (JIRA)


 [ 
https://issues.apache.org/jira/browse/RANGER-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhay Kulkarni updated RANGER-2297:
---
Affects Version/s: 1.1.0
Fix Version/s: 1.1.1
   master

> getContentSummary validation failure
> 
>
> Key: RANGER-2297
> URL: https://issues.apache.org/jira/browse/RANGER-2297
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: master, 1.1.1, 1.2.1
>
>
> Parameter values for authorization API call for getContentSummary have 
> changed with fix for 
> [HDFS-12130|https://issues.apache.org/jira/browse/HDFS-12130]. This causes 
> Ranger authorizer to fail.
> Ranger authorizer needs to be updated to accommodate for NameNode changes in 
> authorizing getContentSummary() use-case. Here are the details of the 
> proposed updates:
> Ranger authorizer currently constructs the path to authorize from the given 
> INodeAttributes
>  Ranger authorizer will use the following alternate approach to construct the 
> path - only when checkPermission() is called with single entry arrays for 
> inodes and inodeAttributes parameters, and the given inode has a parent.
>  – get path to authorize from the given inode by calling getFullPathName()
>  – if snapshotId != Snapshot.CURRENT_STATE_ID, remove "/.snapshot" from the 
> path obtained from getFullPathName()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69471: RANGER-2297: getContentSummary validation failure

2018-11-29 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69471/#review210951
---


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 29, 2018, 6:32 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69471/
> ---
> 
> (Updated Nov. 29, 2018, 6:32 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-2297
> https://issues.apache.org/jira/browse/RANGER-2297
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Parameter values for authorization API call for getContentSummary have 
> changed with fix for HDFS-12130. This causes Ranger authorizer to fail.
> 
> Ranger authorizer needs to be updated to accommodate for NameNode changes in 
> authorizing getContentSummary() use-case. Here are the details of the 
> proposed updates:
> 
> Ranger authorizer currently constructs the path to authorize from the given 
> INodeAttributes
> Ranger authorizer will use the following alternate approach to construct the 
> path - only when checkPermission() is called with single entry arrays for 
> inodes and inodeAttributes parameters, and the given inode has a parent.
> – get path to authorize from the given inode by calling getFullPathName()
> – if snapshotId != Snapshot.CURRENT_STATE_ID, remove "/.snapshot" from the 
> path obtained from getFullPathName()
> 
> 
> Diffs
> -
> 
>   
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
>  65a397d09 
> 
> 
> Diff: https://reviews.apache.org/r/69471/diff/2/
> 
> 
> Testing
> ---
> 
> Tested with local VM.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>



Re: Review Request 69471: RANGER-2297: getContentSummary validation failure

2018-11-29 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69471/
---

(Updated Nov. 29, 2018, 6:32 p.m.)


Review request for ranger and Madhan Neethiraj.


Changes
---

Updated for generating no audit log records when authorizer is called for 
getContentSummary, and using default authorizer for snapshots when authorizing 
getContentSummary.


Bugs: RANGER-2297
https://issues.apache.org/jira/browse/RANGER-2297


Repository: ranger


Description
---

Parameter values for authorization API call for getContentSummary have changed 
with fix for HDFS-12130. This causes Ranger authorizer to fail.

Ranger authorizer needs to be updated to accommodate for NameNode changes in 
authorizing getContentSummary() use-case. Here are the details of the proposed 
updates:

Ranger authorizer currently constructs the path to authorize from the given 
INodeAttributes
Ranger authorizer will use the following alternate approach to construct the 
path - only when checkPermission() is called with single entry arrays for 
inodes and inodeAttributes parameters, and the given inode has a parent.
– get path to authorize from the given inode by calling getFullPathName()
– if snapshotId != Snapshot.CURRENT_STATE_ID, remove "/.snapshot" from the path 
obtained from getFullPathName()


Diffs (updated)
-

  
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
 65a397d09 


Diff: https://reviews.apache.org/r/69471/diff/2/

Changes: https://reviews.apache.org/r/69471/diff/1-2/


Testing
---

Tested with local VM.


Thanks,

Abhay Kulkarni