Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-05 Thread Nikhil P

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/
---

(Updated May 6, 2019, 11:20 a.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Bugs: RANGER-2411
https://issues.apache.org/jira/browse/RANGER-2411


Repository: ranger


Description
---

Restrict Admin role user to create Zone for KMS service


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
4f6fa89 
  security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
edb3102 


Diff: https://reviews.apache.org/r/70565/diff/3/

Changes: https://reviews.apache.org/r/70565/diff/2-3/


Testing
---

Tested if Admin user is not able to create zone for KMS service.


Thanks,

Nikhil P



Re: Review Request 68667: RANGER-2205 Optimize view 'vx_trx_log' to improve query performance

2019-05-05 Thread Pradeep Agrawal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68667/#review215041
---



Can you update this patch and make the db patch number to 042 rather 035.

- Pradeep Agrawal


On Sept. 7, 2018, 6:53 a.m., Xing Peng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68667/
> ---
> 
> (Updated Sept. 7, 2018, 6:53 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2205
> https://issues.apache.org/jira/browse/RANGER-2205
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When the number of records in the table 'x_trx_log' is 1000, the view 
> 'vx_trx_log' query takes about 14.651 seconds.
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 3f23b0082 
>   
> security-admin/db/mysql/patches/035-update-view-vx_trx_log-and-add-index-on-table-x_trx_log.sql
>  PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> bafdb9676 
>   
> security-admin/db/oracle/patches/035-update-view-vx_trx_log-and-add-index-on-table-x_trx_log.sql
>  PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 2bc58acfe 
>   
> security-admin/db/postgres/patches/035-update-view-vx_trx_log-and-add-index-on-table-x_trx_log.sql
>  PRE-CREATION 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  1b64eeac8 
>   
> security-admin/db/sqlanywhere/patches/035-update-view-vx_trx_log-and-add-index-on-table-x_trx_log.sql
>  PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 4a216fed9 
>   
> security-admin/db/sqlserver/patches/035-update-view-vx_trx_log-and-add-index-on-table-x_trx_log.sql
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68667/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Xing Peng
> 
>