[GitHub] [ranger] tooptoop4 commented on issue #36: [RANGER-2395] Add Presto plugin

2019-08-14 Thread GitBox
tooptoop4 commented on issue #36: [RANGER-2395] Add Presto plugin
URL: https://github.com/apache/ranger/pull/36#issuecomment-521401008
 
 
   @bolkedebruin if access-control.name=ranger not access-control.name=file how 
are you locking each principal to one user? as security.config-file can't be 
provided


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Review Request 71217: RANGER-2535 : Good coding practices for storing and retrieving data history in ranger

2019-08-14 Thread Nikhil P

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71217/
---

Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Bugs: RANGER-2535
https://issues.apache.org/jira/browse/RANGER-2535


Repository: ranger


Description
---

Good coding practices for storing and retrieving data history in ranger


Diffs
-

  agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java 
2af5845e2 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
113e727c4 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
af74daf26 
  
security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java
 7bd0681b1 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyLabelHelper.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyLabelsService.java
 1a1b56e4c 
  security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 
2be371892 


Diff: https://reviews.apache.org/r/71217/diff/1/


Testing
---

1.Tested If data is getting stored and retrieved properly in data history table 
i.e. x_data_hist.


Thanks,

Nikhil P



[jira] [Created] (RANGER-2535) Good coding practices for storing and retrieving data history in ranger

2019-08-14 Thread Nikhil Purbhe (JIRA)
Nikhil Purbhe created RANGER-2535:
-

 Summary: Good coding practices for storing and retrieving data 
history in ranger
 Key: RANGER-2535
 URL: https://issues.apache.org/jira/browse/RANGER-2535
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Nikhil Purbhe
Assignee: Nikhil Purbhe


Good coding practices for storing and retrieving data history in ranger



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


Re: Review Request 71261: RANGER-2533: After setting 'xasecure.audit.is.enabled' to 'false', the audit log is still logged

2019-08-14 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71261/#review217197
---


Ship it!




Ship It!

- pengjianhua


On 八月 9, 2019, 7:44 a.m., Xing Peng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71261/
> ---
> 
> (Updated 八月 9, 2019, 7:44 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, sam  rome, Venkat Ranganathan, Velmurugan 
> Periasamy, Qiang Zhang, and Zsombor Gegesy.
> 
> 
> Bugs: RANGER-2533
> https://issues.apache.org/jira/browse/RANGER-2533
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After setting 'xasecure.audit.is.enabled' to 'false', the audit log is still 
> logged
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java
>  f858efe8f 
> 
> 
> Diff: https://reviews.apache.org/r/71261/diff/1/
> 
> 
> Testing
> ---
> 
> Test Result:
> 
> 
> Tested.
> 
> 
> Thanks,
> 
> Xing Peng
> 
>