Re: Review Request 71572: RANGER-2600: Ranger Login Sessions audits always show "Login Type" as "Username/Password" even for kerberos login

2019-10-07 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71572/#review218128
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 7, 2019, 9:28 a.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71572/
> ---
> 
> (Updated Oct. 7, 2019, 9:28 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> Nitin Galave, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2600
> https://issues.apache.org/jira/browse/RANGER-2600
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added kerberos Auth Type to support different login methods so that the audit 
> logs show properly.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java 
> c277158cd 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
>  5c825d839 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java
>  eb40cfdf2 
>   security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java 
> 059b75a42 
>   security-admin/src/main/webapp/scripts/utils/XAEnums.js a4a4e0b85 
> 
> 
> Diff: https://reviews.apache.org/r/71572/diff/3/
> 
> 
> Testing
> ---
> 
> 1. Patched cluster and verified both username/password login and kerberos 
> login are working fine.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Re: Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-07 Thread Selvamohan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/
---

(Updated Oct. 7, 2019, 10 p.m.)


Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
and Velmurugan Periasamy.


Changes
---

uploaded the diff file for the master branch


Bugs: RANGER-2606
https://issues.apache.org/jira/browse/RANGER-2606


Repository: ranger


Description
---

Added all modules to the sign-artifacts profile to fix this issue ...


Diffs (updated)
-

  pom.xml bb2e84728 


Diff: https://reviews.apache.org/r/71587/diff/2/

Changes: https://reviews.apache.org/r/71587/diff/1-2/


Testing
---

Ran it from v2.0 release codebase to check if it is able to upload as part of 
the deployment. It works!
* Also, fixed some of the TAB characters (replaced with SPACE to look nice)


Thanks,

Selvamohan Neethiraj

[jira] [Commented] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946396#comment-16946396
 ] 

Selvamohan Neethiraj commented on RANGER-2606:
--

[~vel]  - Please use 
0001-RANGER-2606-Added-all-modules-to-the-sign-artifacts-master-branch.patch 
for applying to master branch ...

> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 
> 0001-RANGER-2606-Added-all-modules-to-the-sign-artifacts-master-branch.patch, 
> 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-2606:
-
Attachment: 
0001-RANGER-2606-Added-all-modules-to-the-sign-artifacts-master-branch.patch

> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 
> 0001-RANGER-2606-Added-all-modules-to-the-sign-artifacts-master-branch.patch, 
> 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-2532) unable to connect to hiverepo

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-2532:
-
Attachment: 
0001-RANGER-2606-Added-all-modules-to-the-sign-artifacts-master-branch.patch

> unable to connect to hiverepo 
> --
>
> Key: RANGER-2532
> URL: https://issues.apache.org/jira/browse/RANGER-2532
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.2.0
>Reporter: rohit
>Priority: Blocker
>
> Unable to connect to hiveserver2 using http transport mode with AD LDAP 
> authentication
> Error:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:147) - 
> Unable to decrypt password due to error
> javax.crypto.IllegalBlockSizeException: Input length (with padding) not 
> multiple of 8 bytes
>  
> h1.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-2532) unable to connect to hiverepo

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-2532:
-
Attachment: (was: 
0001-RANGER-2606-Added-all-modules-to-the-sign-artifacts-master-branch.patch)

> unable to connect to hiverepo 
> --
>
> Key: RANGER-2532
> URL: https://issues.apache.org/jira/browse/RANGER-2532
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.2.0
>Reporter: rohit
>Priority: Blocker
>
> Unable to connect to hiveserver2 using http transport mode with AD LDAP 
> authentication
> Error:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:147) - 
> Unable to decrypt password due to error
> javax.crypto.IllegalBlockSizeException: Input length (with padding) not 
> multiple of 8 bytes
>  
> h1.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-07 Thread Selvamohan Neethiraj 


> On Oct. 7, 2019, 5:39 p.m., Velmurugan Periasamy wrote:
> >

Was this patch worked for 2.0 release?  I will send another patch for master 
branch ...


- Selvamohan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/#review218125
---


On Oct. 7, 2019, 5:24 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71587/
> ---
> 
> (Updated Oct. 7, 2019, 5:24 p.m.)
> 
> 
> Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added all modules to the sign-artifacts profile to fix this issue ...
> 
> 
> Diffs
> -
> 
>   pom.xml afc27d2cb 
> 
> 
> Diff: https://reviews.apache.org/r/71587/diff/1/
> 
> 
> Testing
> ---
> 
> Ran it from v2.0 release codebase to check if it is able to upload as part of 
> the deployment. It works!
> * Also, fixed some of the TAB characters (replaced with SPACE to look nice)
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>

Re: Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-07 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/#review218125
---




pom.xml
Line 183 (original), 183 (patched)


Can you please rebase it to master branch? Patch fails to apply.

```
$ git apply --check -v < 
~/Downloads/0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
Checking patch pom.xml...
Hunk #1 succeeded at 117 (offset 1 line).
error: while searching for:
1.7
3.4.14

3.1.4
5.0.3
2.9.9

0.0.2
5.2.0
5.2.0

0.178
2.0.0

error: patch failed: pom.xml:183
error: pom.xml: patch does not apply
```


- Velmurugan Periasamy


On Oct. 7, 2019, 9:24 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71587/
> ---
> 
> (Updated Oct. 7, 2019, 9:24 p.m.)
> 
> 
> Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added all modules to the sign-artifacts profile to fix this issue ...
> 
> 
> Diffs
> -
> 
>   pom.xml afc27d2cb 
> 
> 
> Diff: https://reviews.apache.org/r/71587/diff/1/
> 
> 
> Testing
> ---
> 
> Ran it from v2.0 release codebase to check if it is able to upload as part of 
> the deployment. It works!
> * Also, fixed some of the TAB characters (replaced with SPACE to look nice)
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>

[jira] [Updated] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Velmurugan Periasamy (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-2606:
-
Affects Version/s: (was: 2.1)
   2.1.0

> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 
> 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-2606:
-
Affects Version/s: 2.0.0
   2.1

> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 2.0.0, 2.1
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 
> 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946257#comment-16946257
 ] 

Selvamohan Neethiraj commented on RANGER-2606:
--

Review Request (https://reviews.apache.org/r/71587/)  has been added.

> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 
> 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-07 Thread Selvamohan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/
---

Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
and Velmurugan Periasamy.


Repository: ranger


Description
---

Added all modules to the sign-artifacts profile to fix this issue ...


Diffs
-

  pom.xml afc27d2cb 


Diff: https://reviews.apache.org/r/71587/diff/1/


Testing
---

Ran it from v2.0 release codebase to check if it is able to upload as part of 
the deployment. It works!
* Also, fixed some of the TAB characters (replaced with SPACE to look nice)


Thanks,

Selvamohan Neethiraj

[jira] [Commented] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946249#comment-16946249
 ] 

Selvamohan Neethiraj commented on RANGER-2606:
--

Attached patch for fixing the deployment of {jar|war|...} files from the 
modules ...


> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 
> 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj updated RANGER-2606:
-
Attachment: 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch

> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 
> 0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj reassigned RANGER-2606:


Assignee: Selvamohan Neethiraj

> Maven central deployment publishing only the top level ranger artifact
> --
>
> Key: RANGER-2606
> URL: https://issues.apache.org/jira/browse/RANGER-2606
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
>
> Following these instructions to publish Apache Ranger artifacts to maven 
> central. 
> https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central
> This used to work before, but now it is deploying only the top level 
> artifact. Most likely was caused by 
> https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (RANGER-2605) Update maven version to 3.6.2

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj reassigned RANGER-2605:


Assignee: Velmurugan Periasamy  (was: Selvamohan Neethiraj)

> Update maven version to 3.6.2
> -
>
> Key: RANGER-2605
> URL: https://issues.apache.org/jira/browse/RANGER-2605
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: Velmurugan Periasamy
>Priority: Major
> Fix For: 2.1.0
>
>
> Maven version needs to be updated to 3.3.9. See 
> https://issues.apache.org/jira/browse/INFRA-19222



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (RANGER-2605) Update maven version to 3.6.2

2019-10-07 Thread Selvamohan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Selvamohan Neethiraj reassigned RANGER-2605:


Assignee: Selvamohan Neethiraj  (was: Velmurugan Periasamy)

> Update maven version to 3.6.2
> -
>
> Key: RANGER-2605
> URL: https://issues.apache.org/jira/browse/RANGER-2605
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: Selvamohan Neethiraj
>Priority: Major
> Fix For: 2.1.0
>
>
> Maven version needs to be updated to 3.3.9. See 
> https://issues.apache.org/jira/browse/INFRA-19222



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (RANGER-2606) Maven central deployment publishing only the top level ranger artifact

2019-10-07 Thread Velmurugan Periasamy (Jira) 
Velmurugan Periasamy created RANGER-2606:


 Summary: Maven central deployment publishing only the top level 
ranger artifact
 Key: RANGER-2606
 URL: https://issues.apache.org/jira/browse/RANGER-2606
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Velmurugan Periasamy
 Fix For: 2.1.0


Following these instructions to publish Apache Ranger artifacts to maven 
central. 
https://cwiki.apache.org/confluence/display/RANGER/Publishing+Apache+Ranger+artifacts+to+Maven+Central

This used to work before, but now it is deploying only the top level artifact. 
Most likely was caused by https://issues.apache.org/jira/browse/RANGER-2243 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RANGER-2605) Update maven version to 3.6.2

2019-10-07 Thread Velmurugan Periasamy (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-2605:
-
Summary: Update maven version to 3.6.2  (was: Update maven version to 3.3.9)

> Update maven version to 3.6.2
> -
>
> Key: RANGER-2605
> URL: https://issues.apache.org/jira/browse/RANGER-2605
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: Velmurugan Periasamy
>Priority: Major
> Fix For: 2.1.0
>
>
> Maven version needs to be updated to 3.3.9. See 
> https://issues.apache.org/jira/browse/INFRA-19222



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 71583: RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins for evaluation -part2

2019-10-07 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71583/#review218123
---


Fix it, then Ship it!





security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 3501 (patched)


Instead of creating a new HashSet in every call to this method, consider 
taking the Set as a parameter:

private void collectRoleNames(List policyItems, 
Set roleNames) {
  ..
}


- Madhan Neethiraj


On Oct. 7, 2019, 6:05 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71583/
> ---
> 
> (Updated Oct. 7, 2019, 6:05 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2512
> https://issues.apache.org/jira/browse/RANGER-2512
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins 
> for evaluation -part2
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 9151a72 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> edc886c 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 0d46ca8 
>   security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java c1ec629 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
> e168278 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1a6b0bd 
> 
> 
> Diff: https://reviews.apache.org/r/71583/diff/5/
> 
> 
> Testing
> ---
> 
> - Addressed review comments in preview patch.
> - "ranger.support.for.service.specific.role.download" introduced to enable 
> role download by service. By default it is "false" and it will download all 
> the roles when add or update of roles happens. If set to "true" only these 
> services which uses the roles will get the updated roles.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71585: RANGER-2605 : Update Maven Version

2019-10-07 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71585/#review218122
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 7, 2019, 2:41 p.m., Velmurugan Periasamy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71585/
> ---
> 
> (Updated Oct. 7, 2019, 2:41 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-2605
> https://issues.apache.org/jira/browse/RANGER-2605
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2605 - maven version needs to be updated
> 
> 
> Diffs
> -
> 
>   pom.xml bb2e84728364d2509a6fbebdbcc253b55ce01ef2 
> 
> 
> Diff: https://reviews.apache.org/r/71585/diff/2/
> 
> 
> Testing
> ---
> 
> Built successfully with unit tests passing
> 
> 
> Thanks,
> 
> Velmurugan Periasamy
> 
>

Re: Review Request 71583: RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins for evaluation -part2

2019-10-07 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71583/#review218120
---


Ship it!




Ship It!

- Abhay Kulkarni


On Oct. 7, 2019, 6:05 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71583/
> ---
> 
> (Updated Oct. 7, 2019, 6:05 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2512
> https://issues.apache.org/jira/browse/RANGER-2512
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins 
> for evaluation -part2
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 9151a72 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> edc886c 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 0d46ca8 
>   security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java c1ec629 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
> e168278 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1a6b0bd 
> 
> 
> Diff: https://reviews.apache.org/r/71583/diff/5/
> 
> 
> Testing
> ---
> 
> - Addressed review comments in preview patch.
> - "ranger.support.for.service.specific.role.download" introduced to enable 
> role download by service. By default it is "false" and it will download all 
> the roles when add or update of roles happens. If set to "true" only these 
> services which uses the roles will get the updated roles.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71583: RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins for evaluation -part2

2019-10-07 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71583/
---

(Updated Oct. 7, 2019, 6:05 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
---

Review comments fixed


Bugs: RANGER-2512
https://issues.apache.org/jira/browse/RANGER-2512


Repository: ranger


Description
---

RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins 
for evaluation -part2


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 9151a72 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
edc886c 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 0d46ca8 
  security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java c1ec629 
  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
e168278 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1a6b0bd 


Diff: https://reviews.apache.org/r/71583/diff/5/

Changes: https://reviews.apache.org/r/71583/diff/4-5/


Testing
---

- Addressed review comments in preview patch.
- "ranger.support.for.service.specific.role.download" introduced to enable role 
download by service. By default it is "false" and it will download all the 
roles when add or update of roles happens. If set to "true" only these services 
which uses the roles will get the updated roles.


Thanks,

Ramesh Mani

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 7, 2019, 5:47 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs
-

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/6/


Testing (updated)
---

Getting the desired json
{
  "data": {
"jvm": {
  "os.spec": "Linux, amd64, 4.15.0-65-generic",
  "os.vcpus": "4",
  "memory": {
"heapInit": "1073741824",
"heapMax": "1024983040",
"heapCommitted": "1024983040",
"heapUsed": "284762328",
"nonHeapInit": "2555904",
"nonHeapMax": "662700032",
"nonHeapCommitted": "102694912",
"nonHeapUsed": "98983000",
"memory_pool_usages": {
  "PS Eden Space": {
"init": 268435456,
"used": 246715792,
"committed": 260046848,
"max": 261619712
  },
  "PS Survivor Space": {
"init": 44564480,
"used": 30075104,
"committed": 48758784,
"max": 48758784
  },
  "PS Old Gen": {
"init": 716177408,
"used": 7971432,
"committed": 716177408,
"max": 716177408
  }
}
  }
},
"vm": {
  "JVM Machine Actual Name": "OpenJDK 64-Bit Server VM",
  "version": "25.222-b10",
  "JVM Machine Representation Name": "15526@fipl5",
  "Up time of JVM": 10414,
  "JVM Vendor Name": "Private Build"
}
  }
}


Thanks,

Fatima Khan

Re: Review Request 71578: RANGER-2591 : Need changes for usersync(unix/ldap) to support HA without load balancer

2019-10-07 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71578/#review218116
---




agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
Line 121 (original), 121 (patched)


Patch fails to apply. Can you please check and rebase? 

```
$ git apply --check -v 
/Users/vperiasamy/Downloads/4-RANGER-2591-Need-changes-for-usersync-unix-ldap-to-s.patch
Checking patch 
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java...
error: while searching for:
mUrl   = url;
mSslConfigFileName = sslConfigFileName;
this.configuredURLs = getURLs(mUrl);
this.lastKnownActiveUrlIndex   = (new 
Random()).nextInt(configuredURLs.size());
init();
}

error: patch failed: 
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java:121
error: 
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java:
 patch does not apply
Checking patch 
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java...
Checking patch 
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java...
Checking patch 
ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java...
```


- Velmurugan Periasamy


On Oct. 3, 2019, 2:39 p.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71578/
> ---
> 
> (Updated Oct. 3, 2019, 2:39 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2591
> https://issues.apache.org/jira/browse/RANGER-2591
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Need changes for usersync(unix/ldap) to support HA without load balancer.
> - Ranger usersync should be able to sync users / groups when Ranger Admin is 
> in HA (even without having LB)
> - User needs to define Ranger URL values in comma separated format in 
> 'ranger-ugsync-site.xml' config file for 
> 'ranger.usersync.policymanager.baseURL' name or property.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
>  ef5f1d5 
>   
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java
>  224a600 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  52579a3 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71578/diff/2/
> 
> 
> Testing
> ---
> 
> ->BUILD SUCCESS
> 
> 1.User sync verified in simple, kerberose and SSL enabled environment.
> 2.Delta sync is verified for UNIX source.
> 3.Authentication is verified for UNIX source and LDAP source.
> 4.Checked user is able to login from both the Admin UI.
> 5.Checked Authentication after changing password of UNIX user.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Re: Review Request 71585: RANGER-2605 : Update Maven Version

2019-10-07 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71585/
---

(Updated Oct. 7, 2019, 2:40 p.m.)


Review request for ranger.


Bugs: RANGER-2605
https://issues.apache.org/jira/browse/RANGER-2605


Repository: ranger


Description (updated)
---

RANGER-2605 - maven version needs to be updated


Diffs
-

  pom.xml bb2e84728364d2509a6fbebdbcc253b55ce01ef2 


Diff: https://reviews.apache.org/r/71585/diff/2/


Testing
---

Built successfully with unit tests passing


Thanks,

Velmurugan Periasamy

Re: Review Request 71585: RANGER-2605 : Update Maven Version

2019-10-07 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71585/
---

(Updated Oct. 7, 2019, 2:40 p.m.)


Review request for ranger.


Changes
---

Updated to 3.6.2


Bugs: RANGER-2605
https://issues.apache.org/jira/browse/RANGER-2605


Repository: ranger


Description
---

RANGER-2605 - maven version needs to be updated to 3.3.9


Diffs (updated)
-

  pom.xml bb2e84728364d2509a6fbebdbcc253b55ce01ef2 


Diff: https://reviews.apache.org/r/71585/diff/2/

Changes: https://reviews.apache.org/r/71585/diff/1-2/


Testing
---

Built successfully with unit tests passing


Thanks,

Velmurugan Periasamy

[jira] [Commented] (RANGER-2599) Add more audit data to HBase grant/revoke events

2019-10-07 Thread Zsombor Gegesy (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945922#comment-16945922
 ] 

Zsombor Gegesy commented on RANGER-2599:


Thanks for your patch, the commit is merged to 
[master|https://github.com/apache/ranger/commit/0011a441d0151c9eeec78ab1e5b9e3e3262129b8]

> Add more audit data to HBase grant/revoke events
> 
>
> Key: RANGER-2599
> URL: https://issues.apache.org/jira/browse/RANGER-2599
> Project: Ranger
>  Issue Type: Improvement
>  Components: audit
>Affects Versions: 2.0.0
>Reporter: Andor Molnar
>Priority: Major
>  Labels: patch-available
> Fix For: 2.1.0
>
>
> Currently {{RangerAuthorizationCoprocessor}} correctly captures all data from 
> HBase grant and revoke events, but {{RangerBasePlugin}} only copies certain 
> fields to RangerAccessEvent.
> {{RequestData}} is one the fields which are copied to the final entity and 
> currently not being used by the co-processor. I'd like to add some missing 
> information to this field and make it available on the UI similarly how Hive 
> queries are shown in a small pop-up.
> First, I change the co-processor to populate {{RequestData}} with additional 
> grant/revoke information.
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 71566: RANGER-2599. Add more audit data to HBase grant/revoke events

2019-10-07 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71566/#review218115
---


Ship it!




Ship It!

- Nitin Galave


On Oct. 4, 2019, 12:17 p.m., Andor Molnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71566/
> ---
> 
> (Updated Oct. 4, 2019, 12:17 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently RangerAuthorizationCoprocessor correctly captures all data from 
> HBase grant and revoke events, but RangerBasePlugin only copies certain 
> fields to RangerAccessEvent.
> 
> RequestData is one the fields which are copied to the final entity and 
> currently not being used by the co-processor. I'd like to add some missing 
> information to this field and make it available on the UI similarly how Hive 
> queries are shown in a small pop-up.
> 
> First, I change the co-processor to populate RequestData with additional 
> grant/revoke information.
> 
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.
> 
> https://issues.apache.org/jira/browse/RANGER-2599
> 
> 
> Diffs
> -
> 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
>  364a415943bed22890dc5773e162962bb30147f9 
>   security-admin/src/main/webapp/scripts/utils/XAViewUtils.js 
> 6ef33435af7e7cbed7fbc5dc4174c8fb46be3aaf 
> 
> 
> Diff: https://reviews.apache.org/r/71566/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on private test cluster.
> 
> 
> Thanks,
> 
> Andor Molnar
> 
>

Re: Review Request 71566: RANGER-2599. Add more audit data to HBase grant/revoke events

2019-10-07 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71566/#review218114
---


Ship it!




Ship It!

- Zsombor Gegesy


On Oct. 4, 2019, 12:17 p.m., Andor Molnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71566/
> ---
> 
> (Updated Oct. 4, 2019, 12:17 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently RangerAuthorizationCoprocessor correctly captures all data from 
> HBase grant and revoke events, but RangerBasePlugin only copies certain 
> fields to RangerAccessEvent.
> 
> RequestData is one the fields which are copied to the final entity and 
> currently not being used by the co-processor. I'd like to add some missing 
> information to this field and make it available on the UI similarly how Hive 
> queries are shown in a small pop-up.
> 
> First, I change the co-processor to populate RequestData with additional 
> grant/revoke information.
> 
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.
> 
> https://issues.apache.org/jira/browse/RANGER-2599
> 
> 
> Diffs
> -
> 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
>  364a415943bed22890dc5773e162962bb30147f9 
>   security-admin/src/main/webapp/scripts/utils/XAViewUtils.js 
> 6ef33435af7e7cbed7fbc5dc4174c8fb46be3aaf 
> 
> 
> Diff: https://reviews.apache.org/r/71566/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on private test cluster.
> 
> 
> Thanks,
> 
> Andor Molnar
> 
>

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 7, 2019, 12:03 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs (updated)
-

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/6/

Changes: https://reviews.apache.org/r/71565/diff/5-6/


Testing
---

Getting the desired json


Thanks,

Fatima Khan

[jira] [Updated] (RANGER-2589) Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Amjad Khan (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2589:
--
Attachment: (was: 0001-RANGER-2589.patch)

> Introduce Ranger API to return Ranger's JVM resource status metric
> --
>
> Key: RANGER-2589
> URL: https://issues.apache.org/jira/browse/RANGER-2589
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Pradeep Agrawal
>Assignee: Fatima Amjad Khan
>Priority: Minor
> Attachments: 0001-RANGER-2589-v3.patch, RANGER-2589-v1.patch, 
> RANGER-2589-v2.patch, RANGER-2589-v3.patch
>
>
> Important JVM attributes can be returned via Ranger REST API : 
>  * heap memory usage
>  * GC time
>  * # of open threads
>  * # of open file descriptors



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 7, 2019, 11:55 a.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs (updated)
-

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/5/

Changes: https://reviews.apache.org/r/71565/diff/4-5/


Testing
---

Getting the desired json


Thanks,

Fatima Khan

[jira] [Updated] (RANGER-2589) Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Amjad Khan (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2589:
--
Attachment: 0001-RANGER-2589-v3.patch

> Introduce Ranger API to return Ranger's JVM resource status metric
> --
>
> Key: RANGER-2589
> URL: https://issues.apache.org/jira/browse/RANGER-2589
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Pradeep Agrawal
>Assignee: Fatima Amjad Khan
>Priority: Minor
> Attachments: 0001-RANGER-2589-v3.patch, 0001-RANGER-2589.patch, 
> RANGER-2589-v1.patch, RANGER-2589-v2.patch
>
>
> Important JVM attributes can be returned via Ranger REST API : 
>  * heap memory usage
>  * GC time
>  * # of open threads
>  * # of open file descriptors



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 71572: RANGER-2600: Ranger Login Sessions audits always show "Login Type" as "Username/Password" even for kerberos login

2019-10-07 Thread Sailaja Polavarapu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71572/
---

(Updated Oct. 7, 2019, 9:28 a.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
Nitin Galave, Ramesh Mani, and Velmurugan Periasamy.


Changes
---

Moved getAuthType() to RangerSecurityContextFormationFilter.java as suggested 
in review comments.


Bugs: RANGER-2600
https://issues.apache.org/jira/browse/RANGER-2600


Repository: ranger


Description
---

Added kerberos Auth Type to support different login methods so that the audit 
logs show properly.


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java 
c277158cd 
  
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
 5c825d839 
  
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java
 eb40cfdf2 
  security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java 
059b75a42 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js a4a4e0b85 


Diff: https://reviews.apache.org/r/71572/diff/3/

Changes: https://reviews.apache.org/r/71572/diff/2-3/


Testing
---

1. Patched cluster and verified both username/password login and kerberos login 
are working fine.


Thanks,

Sailaja Polavarapu

Re: Review Request 71583: RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins for evaluation -part2

2019-10-07 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71583/
---

(Updated Oct. 7, 2019, 6:44 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
---

Fixed review comments


Bugs: RANGER-2512
https://issues.apache.org/jira/browse/RANGER-2512


Repository: ranger


Description
---

RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins 
for evaluation -part2


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 9151a72 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
edc886c 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 0d46ca8 
  security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java c1ec629 
  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
e168278 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1a6b0bd 


Diff: https://reviews.apache.org/r/71583/diff/4/

Changes: https://reviews.apache.org/r/71583/diff/3-4/


Testing
---

- Addressed review comments in preview patch.
- "ranger.support.for.service.specific.role.download" introduced to enable role 
download by service. By default it is "false" and it will download all the 
roles when add or update of roles happens. If set to "true" only these services 
which uses the roles will get the updated roles.


Thanks,

Ramesh Mani