[jira] [Commented] (RANGER-2634) Add ElasticSearch support

2019-12-07 Thread Bosco (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990765#comment-16990765
 ] 

Bosco commented on RANGER-2634:
---

Hi [~acharneski] sorry for  the delay. I can try it out.

For reviewing the code, would you be able to create a Review Board request?  
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244

Thanks


> Add ElasticSearch support
> -
>
> Key: RANGER-2634
> URL: https://issues.apache.org/jira/browse/RANGER-2634
> Project: Ranger
>  Issue Type: Wish
>  Components: audit
>Reporter: Andrew Charneski
>Priority: Major
>
> Hello,
> Our organization is working on integrating and rolling out Apache Ranger for 
> our internal toolset, and firstly, we'd like to thank you all for your great 
> work!
> Although we have decided to adopt Ranger, for a variety of reasons we would 
> very much like to use an alternate indexing service (Elasticsearch) in 
> preference to the currently-supported Solr.
> We are happy to develop this extension on our own, and the initial efforts 
> are underway at [https://github.com/acharneski/ranger/pull/1] however we 
> would like to engage the community for guidance and suggestions with the aim 
> of getting this change merged into the main codebase when it is ready.
> Our initial approach is in three main phases:
>  # Isolate all usages of Solr packages/classes to pass through an API 
> wrapper, delegating to the original Solr code with minimal changes. (Dev 
> complete)
>  # Refactor api package as a pluggable interface with greater simplicity and 
> implementation agnosticism.
>  # Provide alternate implementation for the new interface for Elasticsearch.
> Any guidance and feedback is appreciated. Thank you for reading!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (RANGER-2666) Rename matchType and matchScope enumerators to more descriptive names

2019-12-07 Thread Abhay Kulkarni (Jira)
Abhay Kulkarni created RANGER-2666:
--

 Summary: Rename matchType and matchScope enumerators to more 
descriptive names
 Key: RANGER-2666
 URL: https://issues.apache.org/jira/browse/RANGER-2666
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Affects Versions: master
Reporter: Abhay Kulkarni
Assignee: Abhay Kulkarni
 Fix For: master


Rename match-type and match-scope enumerators as follows:

ANCESTOR_WITH_WILDCARDS ==> SELF_AND_ALL_DESCENDANTS



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 71891: RANGER-2654: updated RangerAdminTagRetriever to use pluginConfig from RangerBasePlugin

2019-12-07 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71891/#review218971
---


Ship it!




Ship It!

- Abhay Kulkarni


On Dec. 7, 2019, 1:55 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71891/
> ---
> 
> (Updated Dec. 7, 2019, 1:55 a.m.)
> 
> 
> Review request for ranger and Abhay Kulkarni.
> 
> 
> Bugs: RANGER-2654
> https://issues.apache.org/jira/browse/RANGER-2654
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - updated RangerAdminTagRetriever to use pluginConfig from RangerBasePlugin
> - replaced multiple instances of RangerAdminConfig, to avoid repeated loading 
> of configuration files
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerAdminConfig.java
>  8783142a6 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java
>  99d97cc4a 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java
>  e4b19c367 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  7e0369023 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagRetriever.java
>  91fdcc3c1 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  f5cdddf83 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
>  01a7c9f77 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
>  3b549608c 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  543d13f80 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> 3761ef2ce 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 
> ec4615d94 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 80e3f978f 
>   security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 
> 2d7f40745 
>   
> security-admin/src/main/java/org/apache/ranger/common/RangerAdminTagEnricher.java
>  c4b134e53 
>   security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java 
> 0b94c1954 
>   
> security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
>  536cb0613 
>   
> security-admin/src/main/java/org/apache/ranger/common/RangerServiceTagsCache.java
>  249a3bfab 
>   security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java 
> 6cae5cba2 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> 5a57ee0e1 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java
>  1ec2f495b 
> 
> 
> Diff: https://reviews.apache.org/r/71891/diff/1/
> 
> 
> Testing
> ---
> 
> - manually verified that RangerAdminTagRetriever successfully downloads tags
> - verified that all unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 71467: RANGER-2565 Remove duplicate error messages when test connection fails

2019-12-07 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71467/#review218969
---


Ship it!




Ship It!

- pengjianhua


On 九月 11, 2019, 9:50 a.m., Xing Peng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71467/
> ---
> 
> (Updated 九月 11, 2019, 9:50 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, sam  rome, Venkat Ranganathan, Velmurugan 
> Periasamy, and Zsombor Gegesy.
> 
> 
> Bugs: RANGER-2565
> https://issues.apache.org/jira/browse/RANGER-2565
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Remove duplicate error messages when test connection fails
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopException.java
>  5c2660fc3 
> 
> 
> Diff: https://reviews.apache.org/r/71467/diff/1/
> 
> 
> Testing
> ---
> 
> Test Result:
> 
> Tested.
> 
> 
> Thanks,
> 
> Xing Peng
> 
>



Re: Review Request 71876: RANGER-2662 Upgrade Kylin version to 2.6.4

2019-12-07 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71876/#review218967
---


Ship it!




Ship It!

- pengjianhua


On 十二月 5, 2019, 11:28 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71876/
> ---
> 
> (Updated 十二月 5, 2019, 11:28 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep 
> Agrawal, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Zsombor 
> Gegesy.
> 
> 
> Bugs: RANGER-2662
> https://issues.apache.org/jira/browse/RANGER-2662
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We should upgrade to the recently release Apache Kylin 2.6.4. No code changes 
> are required.
> 
> 
> Diffs
> -
> 
>   pom.xml cb04757a8 
> 
> 
> Diff: https://reviews.apache.org/r/71876/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Ranger with Kylin 2.6.4
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>



Re: Review Request 71877: RANGER-2663 Add elasticsearch-plugin infomation to README.txt

2019-12-07 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71877/#review218968
---


Ship it!




Ship It!

- pengjianhua


On 十二月 5, 2019, 11:50 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71877/
> ---
> 
> (Updated 十二月 5, 2019, 11:50 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep 
> Agrawal, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Zsombor 
> Gegesy.
> 
> 
> Bugs: RANGER-2663
> https://issues.apache.org/jira/browse/RANGER-2663
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> As elasticsearch plugin has been submitted and merged into to Ranger,
> we should add elasticsearch-plugin infomation to README.txt.
> Related Issue: RANGER-2170
> 
> 
> Diffs
> -
> 
>   README.txt 788b281de 
> 
> 
> Diff: https://reviews.apache.org/r/71877/diff/1/
> 
> 
> Testing
> ---
> 
> Test OK.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>