[jira] [Comment Edited] (RANGER-3755) Build Plugin-Trino artifacts only with JDK 11
[ https://issues.apache.org/jira/browse/RANGER-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536458#comment-17536458 ] Aakash Nand edited comment on RANGER-3755 at 5/13/22 6:54 AM: -- [~rmani], I have performed the final testing for this patch RANGER-3755 on my side and it is working correctly as expected. Good to go, however, I found out that when the trino plugin is used with Ranger it is enabling DEBUG logs by default which is flooding the trino server logs. For that part, Since we have reverted the trino patch I was thinking of adding logback.xml to the trino-plugin tar file. Can I still fix this and add to patch RANGER-3182? I will try to fix it asap but I might need this weekend to work on that as the last part? What do you think? Should I fix that? Can we wait till this weekend? was (Author: aakashnand): [~rmani], I have performed the final testing for this patch RANGER-3755 on my side and it is working correctly as expected. Good to go, however, I found out that when the trino plugin is used with Ranger it is enabling DEBUG logs by default which is flooding the trino server logs. For that part, Since we have reverted the trino patch I was thinking of adding logback.xml to the trino-plugin tar file. Can I still fix this and add to patch RANGER-3182? I will need this weekend to work on that as the last part? What do you think? > Build Plugin-Trino artifacts only with JDK 11 > - > > Key: RANGER-3755 > URL: https://issues.apache.org/jira/browse/RANGER-3755 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 3.0.0, 2.2.0 >Reporter: Ramesh Mani >Assignee: Ramesh Mani >Priority: Major > > Plugin Trino needs jdk 11 and about to compile and build. In order to avoid > build issue in Apache Ranger when including Plugin Trino, we need to enable a > profile so that default build of Apache Ranger will use JDK 1.8 and Plugin > Trino and its artifacts can be build with JDK 11 profile. > To build Plugin Trino artifacts following command can be executed. > mvn clean compile package -P ranger-trino-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (RANGER-3755) Build Plugin-Trino artifacts only with JDK 11
[ https://issues.apache.org/jira/browse/RANGER-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536458#comment-17536458 ] Aakash Nand edited comment on RANGER-3755 at 5/13/22 6:51 AM: -- [~rmani], I have performed the final testing for this patch RANGER-3755 on my side and it is working correctly as expected. Good to go, however, I found out that when the trino plugin is used with Ranger it is enabling DEBUG logs by default which is flooding the trino server logs. For that part, Since we have reverted the trino patch I was thinking of adding logback.xml to the trino-plugin tar file. Can I still fix this and add to patch RANGER-3182? I will need this weekend to work on that as the last part? What do you think? was (Author: aakashnand): [~rmani], I have performed the final testing on my side and it is working correctly as expected. Good to go > Build Plugin-Trino artifacts only with JDK 11 > - > > Key: RANGER-3755 > URL: https://issues.apache.org/jira/browse/RANGER-3755 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 3.0.0, 2.2.0 >Reporter: Ramesh Mani >Assignee: Ramesh Mani >Priority: Major > > Plugin Trino needs jdk 11 and about to compile and build. In order to avoid > build issue in Apache Ranger when including Plugin Trino, we need to enable a > profile so that default build of Apache Ranger will use JDK 1.8 and Plugin > Trino and its artifacts can be build with JDK 11 profile. > To build Plugin Trino artifacts following command can be executed. > mvn clean compile package -P ranger-trino-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (RANGER-3755) Build Plugin-Trino artifacts only with JDK 11
[ https://issues.apache.org/jira/browse/RANGER-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536458#comment-17536458 ] Aakash Nand commented on RANGER-3755: - [~rmani], I have performed the final testing on my side and it is working correctly as expected. Good to go > Build Plugin-Trino artifacts only with JDK 11 > - > > Key: RANGER-3755 > URL: https://issues.apache.org/jira/browse/RANGER-3755 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 3.0.0, 2.2.0 >Reporter: Ramesh Mani >Assignee: Ramesh Mani >Priority: Major > > Plugin Trino needs jdk 11 and about to compile and build. In order to avoid > build issue in Apache Ranger when including Plugin Trino, we need to enable a > profile so that default build of Apache Ranger will use JDK 1.8 and Plugin > Trino and its artifacts can be build with JDK 11 profile. > To build Plugin Trino artifacts following command can be executed. > mvn clean compile package -P ranger-trino-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: Review Request 73984: RANGER-3755:Build Plugin-Trino artifacts only with JDK 11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73984/#review224442 --- Ship it! Ship It! - Aakash Nand On May 12, 2022, 6:46 a.m., Ramesh Mani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73984/ > --- > > (Updated May 12, 2022, 6:46 a.m.) > > > Review request for ranger, Aakash Nand and Madhan Neethiraj. > > > Bugs: RANGER-3755 > https://issues.apache.org/jira/browse/RANGER-3755 > > > Repository: ranger > > > Description > --- > > RANGER-3755:Build Plugin-Trino artifacts only with JDK 11 > > > Diffs > - > > distro/pom.xml 45a2164a6 > pom.xml cc62a6fa4 > > > Diff: https://reviews.apache.org/r/73984/diff/3/ > > > Testing > --- > > - Verified in local build. > - Apache Ranger builds without issue with Plugin Trino Patch in place. > > > Thanks, > > Ramesh Mani > >
[GitHub] [ranger] joshelser opened a new pull request, #146: RANGER-3758: Demote the log level to trace about not having an HBase …
joshelser opened a new pull request, #146: URL: https://github.com/apache/ranger/pull/146 …remote client address This is an expected case where there is no client address and there is zero value derived from knowing that one is not present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RANGER-3755) Build Plugin-Trino artifacts only with JDK 11
[ https://issues.apache.org/jira/browse/RANGER-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536376#comment-17536376 ] Aakash Nand commented on RANGER-3755: - [~rmani] please give me some time as I am going to build it again and test with actual trino cluster one last time. I will finish this by noon today JST > Build Plugin-Trino artifacts only with JDK 11 > - > > Key: RANGER-3755 > URL: https://issues.apache.org/jira/browse/RANGER-3755 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 3.0.0, 2.2.0 >Reporter: Ramesh Mani >Assignee: Ramesh Mani >Priority: Major > > Plugin Trino needs jdk 11 and about to compile and build. In order to avoid > build issue in Apache Ranger when including Plugin Trino, we need to enable a > profile so that default build of Apache Ranger will use JDK 1.8 and Plugin > Trino and its artifacts can be build with JDK 11 profile. > To build Plugin Trino artifacts following command can be executed. > mvn clean compile package -P ranger-trino-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (RANGER-3758) Decrease log-level when no HBase remote client address is found
Josh Elser created RANGER-3758:
--
Summary: Decrease log-level when no HBase remote client address is
found
Key: RANGER-3758
URL: https://issues.apache.org/jira/browse/RANGER-3758
Project: Ranger
Issue Type: Task
Components: Ranger
Reporter: Josh Elser
We deal with really annoying logging in HBase services because of this one line
{noformat}
2022-04-17 17:51:05,481 INFO
org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor: Unable to
get remote Address {noformat}
20% of all HBase logging in one RegionServer is from this one log message.
There is zero value derived from this log message as it is completely expected
that HBase will perform operations on its own which Ranger would audit.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (RANGER-3755) Build Plugin-Trino artifacts only with JDK 11
[ https://issues.apache.org/jira/browse/RANGER-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536297#comment-17536297 ] Ramesh Mani commented on RANGER-3755: - [~aakashnand] Any update for me on the testing? > Build Plugin-Trino artifacts only with JDK 11 > - > > Key: RANGER-3755 > URL: https://issues.apache.org/jira/browse/RANGER-3755 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: 3.0.0, 2.2.0 >Reporter: Ramesh Mani >Assignee: Ramesh Mani >Priority: Major > > Plugin Trino needs jdk 11 and about to compile and build. In order to avoid > build issue in Apache Ranger when including Plugin Trino, we need to enable a > profile so that default build of Apache Ranger will use JDK 1.8 and Plugin > Trino and its artifacts can be build with JDK 11 profile. > To build Plugin Trino artifacts following command can be executed. > mvn clean compile package -P ranger-trino-plugin -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: Review Request 73983: RANGER-3754: Chained plugins access evaluation result is not considered in some cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73983/#review224440 --- Ship it! Ship It! - Madhan Neethiraj On May 11, 2022, 8:43 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73983/ > --- > > (Updated May 11, 2022, 8:43 p.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-3754 > https://issues.apache.org/jira/browse/RANGER-3754 > > > Repository: ranger > > > Description > --- > > If the plugins are chained, the result of an access request combines the > access result of the main plugin with the result reported by the plugin > chained to the main plugin. In some cases (where fallback to native > authorizer is not enabled for the main plugin), the result of the chained > plugin's access result is not used if the chained plugin's policy that > evaluated the access is of same or lower priority. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > f157475bf > > > Diff: https://reviews.apache.org/r/73983/diff/3/ > > > Testing > --- > > Compiled and ran all unit tests successfully > > > Thanks, > > Abhay Kulkarni > >
Re: Review Request 73983: RANGER-3754: Chained plugins access evaluation result is not considered in some cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73983/#review224439 --- Ship it! Ship It! - Ramesh Mani On May 11, 2022, 8:43 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73983/ > --- > > (Updated May 11, 2022, 8:43 p.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-3754 > https://issues.apache.org/jira/browse/RANGER-3754 > > > Repository: ranger > > > Description > --- > > If the plugins are chained, the result of an access request combines the > access result of the main plugin with the result reported by the plugin > chained to the main plugin. In some cases (where fallback to native > authorizer is not enabled for the main plugin), the result of the chained > plugin's access result is not used if the chained plugin's policy that > evaluated the access is of same or lower priority. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > f157475bf > > > Diff: https://reviews.apache.org/r/73983/diff/3/ > > > Testing > --- > > Compiled and ran all unit tests successfully > > > Thanks, > > Abhay Kulkarni > >
[jira] [Commented] (RANGER-3752) Restrict duplicate access types entries in policy creation
[
https://issues.apache.org/jira/browse/RANGER-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535910#comment-17535910
]
kirby zhou commented on RANGER-3752:
This seems to be a historical problem, because the underlying
"isValidPolicyItemAccess" function will also modify the input.
{code:java}
String matchedAccessType = getMatchedAccessType(accessType, accessTypes);
if (StringUtils.isEmpty(matchedAccessType)) {
//...
} else {
access.setType(matchedAccessType);
} {code}
> Restrict duplicate access types entries in policy creation
> --
>
> Key: RANGER-3752
> URL: https://issues.apache.org/jira/browse/RANGER-3752
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
>Priority: Major
> Fix For: 3.0.0
>
> Attachments:
> 0001-RANGER-3752-Restrict-duplicate-access-types-entries-.patch
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
