[jira] [Comment Edited] (RANGER-4524) FIx TestRangerMetricsContainerSource class UT
[
https://issues.apache.org/jira/browse/RANGER-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786632#comment-17786632
]
Bhavik Patel edited comment on RANGER-4524 at 11/20/23 7:30 AM:
[~kishor.gollapalliwar] / [~dhavalshah9131] Can you review and merge?
was (Author: bpatel):
[~kishor.gollapalliwar] Can you review and merge?
> FIx TestRangerMetricsContainerSource class UT
> -
>
> Key: RANGER-4524
> URL: https://issues.apache.org/jira/browse/RANGER-4524
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Bhavik Patel
>Assignee: Bhavik Patel
>Priority: Major
> Fix For: 3.0.0
>
> Attachments:
> 0001-RANGER-4524-Fix-TestRangerMetricsContainerSource-cla.patch
>
>
> Steps to reproduce:
> 1. clean .m2 repo and trigger the test-cases.
> {code:java}
> java.lang.NoClassDefFoundError: org/apache/log4j/Level at
> org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)
> Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Level at
> org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (RANGER-4418) Upgrade hadoop version and use shaded hadoop client artifacts
[
https://issues.apache.org/jira/browse/RANGER-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787844#comment-17787844
]
Bhavik Patel commented on RANGER-4418:
--
Followed the build and installation cmd is mentioned in the readme file.
{code:java}
java.lang.NoClassDefFoundError:
org/apache/hadoop/thirdparty/com/google/common/collect/Interners {code}
> Upgrade hadoop version and use shaded hadoop client artifacts
> -
>
> Key: RANGER-4418
> URL: https://issues.apache.org/jira/browse/RANGER-4418
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 2.3.0, 2.4.0
>Reporter: YUBI LEE
>Priority: Major
> Attachments: screenshot-1.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> - Upgrade the hadoop version Ranger uses.
> - Try to use shaded hadoop client artifacts if possible.
> Related issue: https://issues.apache.org/jira/browse/HADOOP-11804
> If shaded hadoop client artifacts ({{hadoop-client-api}},
> {{hadoop-client-runtime}}) are used, Ranger will be free to use any version
> of thirdparty libraries without collision.
> I will make a pull request soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (RANGER-4187) Not able to search using multiple user filter in access audit tab
[ https://issues.apache.org/jira/browse/RANGER-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mugdha Varadkar updated RANGER-4187: Attachment: 0002-RANGER-4187.patch > Not able to search using multiple user filter in access audit tab > - > > Key: RANGER-4187 > URL: https://issues.apache.org/jira/browse/RANGER-4187 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Harshal Chavan >Assignee: Mugdha Varadkar >Priority: Major > Labels: ranger-react > Attachments: 0001-RANGER-4187.patch, 0002-RANGER-4187.patch > > > Steps > 1. Go to access audit tab > 2. Search with one user > 3. Try selecting user filter again > Note - we dont see user filter in 3 step -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74727: RANGER-4187: Not able to search using multiple user filter in access audit tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74727/ --- (Updated Nov. 20, 2023, 7:14 a.m.) Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, and Nikunj Pansuriya. Bugs: RANGER-4187 https://issues.apache.org/jira/browse/RANGER-4187 Repository: ranger Description --- This review request is providing a fix to support multiple user search filter in Ranger React structured filter. Steps to reproduce the issue : 1. Go to access audit tab 2. Search with one user 3. Try selecting user filter again At step 3 user filter is option is not available in the filter Diffs (updated) - security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js 82f73024a security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js ebf1b3fc2 security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 7ec8503e7 Diff: https://reviews.apache.org/r/74727/diff/2/ Changes: https://reviews.apache.org/r/74727/diff/1-2/ Testing --- Testing is in progress Thanks, Mugdha Varadkar
Re: Review Request 74653: RANGER-4370: "Select All permissions for all components." checkbox missing in tag based policy permission popup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74653/ --- (Updated Nov. 20, 2023, 7:04 a.m.) Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. Bugs: RANGER-4370 https://issues.apache.org/jira/browse/RANGER-4370 Repository: ranger Description --- In the permissions selector popup for tag based policies in Backbone UI, there is a checkbox which allows users to select all permissions for all components selected. But in React UI, this checkbox is missing. This is a minor bug. Diffs (updated) - security-admin/src/main/webapp/react-webapp/src/styles/style.css 46e8eeda1 security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx cda20700c Diff: https://reviews.apache.org/r/74653/diff/2/ Changes: https://reviews.apache.org/r/74653/diff/1-2/ Testing --- Tested changes on a cluster setup with Ranger Admin build with React JS code base. verified the Service & Policy Module permission component. Thanks, Brijesh Bhalala
[jira] [Updated] (RANGER-4370) [Ranger UI] [React JS]"Select All permissions for all components." checkbox missing in tag based policy permission popup
[
https://issues.apache.org/jira/browse/RANGER-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brijesh Bhalala updated RANGER-4370:
Attachment: 0002-RANGER-4370.patch
> [Ranger UI] [React JS]"Select All permissions for all components." checkbox
> missing in tag based policy permission popup
>
>
> Key: RANGER-4370
> URL: https://issues.apache.org/jira/browse/RANGER-4370
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
>Reporter: Abhishek
>Assignee: Brijesh Bhalala
>Priority: Minor
> Labels: ranger-react
> Attachments: 0001-RANGER-4370.patch, 0002-RANGER-4370.patch
>
>
> {color:#172b4d}In the permissions selector popup for tag based policies in
> Backbone UI,{color}
> {color:#172b4d}there is a checkbox which allows users to select all
> permissions for all components selected.{color}
> {color:#172b4d}But in React UI, this checkbox is missing.{color}
> {color:#172b4d}This is a minor bug.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74701/ --- (Updated Nov. 20, 2023, 6:53 a.m.) Review request for ranger, Dhaval Rajpara and Mugdha Varadkar. Bugs: RANGER-4493 https://issues.apache.org/jira/browse/RANGER-4493 Repository: ranger Description --- In Ranger admin, security zones can be now created without any services/resources. If a security zone is created without any service, and on the service manager page, if the resource based services are filtered based on the zone without any service, then the UI displays an image with the text "No Services". But if the same service filtering is done for tag based services, then the UI shows a service element for tag. It will be better if the UI behaviour is consistent for both resource and tag based service filtering In the current review request, I have improvise the code with following fixes : 1)Fix for the No service page in tag based. 2)Fix for the deleting the zone service while filtering zone. 3)Fix for import and export button click when there are no service while filtering zone. Diffs (updated) - security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 67f71ec79 security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 8c222d080 security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 47763fb9d security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1 Diff: https://reviews.apache.org/r/74701/diff/3/ Changes: https://reviews.apache.org/r/74701/diff/2-3/ Testing --- Testing is in progress Thanks, Brijesh Bhalala
[jira] [Updated] (RANGER-4493) Keep the UI behaviour for tag based and resource based services filtering for zone without any service
[ https://issues.apache.org/jira/browse/RANGER-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brijesh Bhalala updated RANGER-4493: Attachment: 0003-RANGER-4493.patch > Keep the UI behaviour for tag based and resource based services filtering for > zone without any service > -- > > Key: RANGER-4493 > URL: https://issues.apache.org/jira/browse/RANGER-4493 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Abhishek >Assignee: Brijesh Bhalala >Priority: Major > Labels: ranger-react > Attachments: 0001-RANGER-4493.patch, 0002-RANGER-4493.patch, > 0003-RANGER-4493.patch, image (10).png, image (9).png > > > In Ranger admin, security zones can be now created without any > services/resources. > If a security zone is created without any service, and on the service manager > page, > if the resource based services are filtered based on the zone without any > service, > then the UI displays an image with the text "No Services". > But if the same service filtering is done for tag based services, then the UI > shows a service element for tag. > It will be better if the UI behaviour is consistent for both resource and tag > based service filtering -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74653: RANGER-4370: "Select All permissions for all components." checkbox missing in tag based policy permission popup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74653/#review225973 --- Ship it! Ship It! - Dhaval Rajpara On Oct. 9, 2023, 10:16 a.m., Brijesh Bhalala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74653/ > --- > > (Updated Oct. 9, 2023, 10:16 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan > Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. > > > Bugs: RANGER-4370 > https://issues.apache.org/jira/browse/RANGER-4370 > > > Repository: ranger > > > Description > --- > > In the permissions selector popup for tag based policies in Backbone UI, > there is a checkbox which allows users to select all permissions for all > components selected. > But in React UI, this checkbox is missing. > This is a minor bug. > > > Diffs > - > > security-admin/src/main/webapp/react-webapp/src/styles/style.css b29d23b12 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx > cda20700c > > > Diff: https://reviews.apache.org/r/74653/diff/1/ > > > Testing > --- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > > verified the Service & Policy Module permission component. > > > Thanks, > > Brijesh Bhalala > >
Re: Review Request 74572: RANGER-4347 : User name with comma split in old Ranger admin UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74572/ --- (Updated Nov. 20, 2023, 6:30 a.m.) Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, and Velmurugan Periasamy. Bugs: RANGER-4347 https://issues.apache.org/jira/browse/RANGER-4347 Repository: ranger Description --- when using Ranger Audit filter to filter out the audit for a specific user: Usually, if we input a username, it would be no issue, but if we input the user like: “CN=SZH-C-004VX,CN=Machine,CN=PKI,DC=Bosch,DC=com”. We found that once we saved the audit filter policy, the user was split into “CN=SZH-C-004VX”, “CN=Machine”, “CN=PKI”, “DC=Bosch”, “DC=com” It happens because Ranger UI recognize “,” to be separate items. Same scenario is present in : 1) Security Zone Form 2) Permission modules 3) Role Form Diffs - security-admin/src/main/webapp/libs/fsOverrides/BBFOverrides.js 469f4aa9c security-admin/src/main/webapp/scripts/models/RangerZone.js 08d118132 security-admin/src/main/webapp/scripts/utils/XAUtils.js 3c5907099 security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js 7b8c4c809 security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js ebdd2a0b2 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js a4885e379 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreateForm.js cbfb8da2d security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 27e2aaecb security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js 26a62e67d security-admin/src/main/webapp/styles/xa.css f5544cca0 security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 68737 security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html 2ddfc3927 security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 7686c3fd1 Diff: https://reviews.apache.org/r/74572/diff/1/ Testing (updated) --- Validated below scenarios with adding comman in name on old UI 1. Tested Resource Based/Tag Based/ KMS Service CRUD. 2. Tested Zone & Unzone policy CRUD. 3. Tested User/Group/ Role CRUD. 4. Tested Zone CRUD. 5. Tested Resource Based/Tag Based/ KMS Policy CRUD. 6. Tested reports/permissions/audits tab. 7. Tested Export and import feature. Thanks, Dhaval Rajpara
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74701/#review225971 --- Ship it! Ship It! - Dhaval Rajpara On Nov. 6, 2023, 12:56 p.m., Brijesh Bhalala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74701/ > --- > > (Updated Nov. 6, 2023, 12:56 p.m.) > > > Review request for ranger, Dhaval Rajpara and Mugdha Varadkar. > > > Bugs: RANGER-4493 > https://issues.apache.org/jira/browse/RANGER-4493 > > > Repository: ranger > > > Description > --- > > In Ranger admin, security zones can be now created without any > services/resources. > If a security zone is created without any service, and on the service manager > page, > if the resource based services are filtered based on the zone without any > service, > then the UI displays an image with the text "No Services". > But if the same service filtering is done for tag based services, then the UI > shows a service element for tag. > It will be better if the UI behaviour is consistent for both resource and tag > based service filtering > > In the current review request, I have improvise the code with following fixes > : > > 1)Fix for the No service page in tag based. > 2)Fix for the deleting the zone service while filtering zone. > 3)Fix for import and export button click when there are no service while > filtering zone. > > > Diffs > - > > security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx > 0b2f46bec > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > 2df0c4d63 > security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx > d4dbc57d1 > > > Diff: https://reviews.apache.org/r/74701/diff/2/ > > > Testing > --- > > Testing is in progress > > > Thanks, > > Brijesh Bhalala > >
Re: Review Request 74667: RANGER-4376: Need to show Tag Policies for user when it has permission in "Tag Based Policies" module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74667/#review225970 --- Ship it! Ship It! - Dhaval Rajpara On Oct. 25, 2023, 10:17 a.m., Brijesh Bhalala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74667/ > --- > > (Updated Oct. 25, 2023, 10:17 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan > Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. > > > Bugs: RANGER-4376 > https://issues.apache.org/jira/browse/RANGER-4376 > > > Repository: ranger > > > Description > --- > > By default user with user-role doesn't have permission on Tag Based Policies > modules. > > If in some case where user with user-role is given permission on Tag Based > Policies module and not on Resource Based Policies, then need to show tag > policies. > > Need to fix this corner case in Ranger Admin UI with react JS. > > > Diffs > - > > security-admin/src/main/webapp/react-webapp/src/App.jsx bc3cf9a7a > > security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx > 5e51faf27 > > security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx > e3d09c51e > > > Diff: https://reviews.apache.org/r/74667/diff/2/ > > > Testing > --- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > > > Verified the "Tag Based Policies" Module with all user-role. > > > Thanks, > > Brijesh Bhalala > >
