Re: Review Request 74773: RANGER-4571: update handling of expressions that evaluate to null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74773/#review226027 --- Ship it! Ship It! - Abhay Kulkarni On Dec. 2, 2023, 1:07 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74773/ > --- > > (Updated Dec. 2, 2023, 1:07 a.m.) > > > Review request for ranger, Ankita Sinha, Barbara Eckman, Abhay Kulkarni, > Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, and Subhrat Chaudhary. > > > Bugs: RANGER-4571 > https://issues.apache.org/jira/browse/RANGER-4571 > > > Repository: ranger > > > Description > --- > > updated expression resolver to replace null value with empty string, instead > of "null" > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestExprResolver.java > 0caa4f0e0 > > agents-common/src/test/java/org/apache/ranger/plugin/util/RangerRequestExprResolverTest.java > a062f0e9b > > > Diff: https://reviews.apache.org/r/74773/diff/1/ > > > Testing > --- > > - updated test cases for the change in handling of null > - added test case > - verified that all existing tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
Review Request 74773: RANGER-4571: update handling of expressions that evaluate to null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74773/ --- Review request for ranger, Ankita Sinha, Barbara Eckman, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Subhrat Chaudhary. Bugs: RANGER-4571 https://issues.apache.org/jira/browse/RANGER-4571 Repository: ranger Description --- updated expression resolver to replace null value with empty string, instead of "null" Diffs - agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestExprResolver.java 0caa4f0e0 agents-common/src/test/java/org/apache/ranger/plugin/util/RangerRequestExprResolverTest.java a062f0e9b Diff: https://reviews.apache.org/r/74773/diff/1/ Testing --- - updated test cases for the change in handling of null - added test case - verified that all existing tests pass successfully Thanks, Madhan Neethiraj
[jira] [Updated] (RANGER-4521) All records not displayed on Admin Audits UI when filtered using session ID
[ https://issues.apache.org/jira/browse/RANGER-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4521: - Fix Version/s: 3.0.0 > All records not displayed on Admin Audits UI when filtered using session ID > --- > > Key: RANGER-4521 > URL: https://issues.apache.org/jira/browse/RANGER-4521 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Rakesh Gupta >Priority: Major > Fix For: 3.0.0 > > Attachments: 0002-RANGER-4521.patch > > > STEPS TO REPRODUCE: > Login as keyadmin user to Ranger Admin UI. > Add a ranger kms policy by doing a json import. > Navigate to Admin Audits on UI > Click on the session ID corresponding to policy import and select "Show > Actions" so that audits related to specific sessionID are displayed > CURRENT BEHAVIOUR: > Some audit entries are missing when filtered using sessionID > (Audots for import and export are shown, audit corresponding to policy create > is missing) > EXPECTED BEHAVIOUR: > All audits corresponding to filtered sessionID should be displayed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4467) User Agent info not logged under "Login sessions" when login fails
[ https://issues.apache.org/jira/browse/RANGER-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4467: - Fix Version/s: 3.0.0 > User Agent info not logged under "Login sessions" when login fails > -- > > Key: RANGER-4467 > URL: https://issues.apache.org/jira/browse/RANGER-4467 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Rakesh Gupta >Priority: Major > Fix For: 3.0.0 > > Attachments: 0001-RANGER-4467.patch > > > STEPS TO REPRODUCE: > Provide wrong uname or password on Ranger admin UI so that login fails > Verify login sessions under Audits page > CURRENT BEHAVIOUR: > User Agent info is missing when login fails > EXPECTED BEHAVIOUR: > User Agent info should be displayed > IMPACT: > User Agent info missing when login fails. Its good to display this detail as > it helps in knowing how the login was tried in case of failed login attempts -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4467) User Agent info not logged under "Login sessions" when login fails
[ https://issues.apache.org/jira/browse/RANGER-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4467: - Attachment: (was: 0001-RANGER-4467-User-Agent-info-not-logged-under-Login-s.patch) > User Agent info not logged under "Login sessions" when login fails > -- > > Key: RANGER-4467 > URL: https://issues.apache.org/jira/browse/RANGER-4467 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Rakesh Gupta >Priority: Major > Attachments: 0001-RANGER-4467.patch > > > STEPS TO REPRODUCE: > Provide wrong uname or password on Ranger admin UI so that login fails > Verify login sessions under Audits page > CURRENT BEHAVIOUR: > User Agent info is missing when login fails > EXPECTED BEHAVIOUR: > User Agent info should be displayed > IMPACT: > User Agent info missing when login fails. Its good to display this detail as > it helps in knowing how the login was tried in case of failed login attempts -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4467) User Agent info not logged under "Login sessions" when login fails
[ https://issues.apache.org/jira/browse/RANGER-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4467: - Attachment: 0001-RANGER-4467.patch > User Agent info not logged under "Login sessions" when login fails > -- > > Key: RANGER-4467 > URL: https://issues.apache.org/jira/browse/RANGER-4467 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Rakesh Gupta >Priority: Major > Attachments: 0001-RANGER-4467.patch > > > STEPS TO REPRODUCE: > Provide wrong uname or password on Ranger admin UI so that login fails > Verify login sessions under Audits page > CURRENT BEHAVIOUR: > User Agent info is missing when login fails > EXPECTED BEHAVIOUR: > User Agent info should be displayed > IMPACT: > User Agent info missing when login fails. Its good to display this detail as > it helps in knowing how the login was tried in case of failed login attempts -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4521) All records not displayed on Admin Audits UI when filtered using session ID
[ https://issues.apache.org/jira/browse/RANGER-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Gupta updated RANGER-4521: - Attachment: 0002-RANGER-4521.patch > All records not displayed on Admin Audits UI when filtered using session ID > --- > > Key: RANGER-4521 > URL: https://issues.apache.org/jira/browse/RANGER-4521 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Rakesh Gupta >Priority: Major > Attachments: 0002-RANGER-4521.patch > > > STEPS TO REPRODUCE: > Login as keyadmin user to Ranger Admin UI. > Add a ranger kms policy by doing a json import. > Navigate to Admin Audits on UI > Click on the session ID corresponding to policy import and select "Show > Actions" so that audits related to specific sessionID are displayed > CURRENT BEHAVIOUR: > Some audit entries are missing when filtered using sessionID > (Audots for import and export are shown, audit corresponding to policy create > is missing) > EXPECTED BEHAVIOUR: > All audits corresponding to filtered sessionID should be displayed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74753: RANGER-4521: All records not displayed on Admin Audits UI when filtered using session ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74753/ --- (Updated Dec. 1, 2023, 1:20 p.m.) Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy. Changes --- password change audit entries were missing Bugs: RANGER-4521 https://issues.apache.org/jira/browse/RANGER-4521 Repository: ranger Description --- Some audit entries for keyadmin user are missing when filtered using sessionID or Audit Type = Ranger Policy. Also when moved to next page most audit entries are missing (Audits for import and export are shown, audit corresponding to policy crud operation is missing for keyadmin user) Diffs (updated) - security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 9d9e0bbc0 Diff: https://reviews.apache.org/r/74753/diff/2/ Changes: https://reviews.apache.org/r/74753/diff/1-2/ Testing --- Tested All audits are displayed properly with filter and without filter for admin and keyadmin user. Thanks, Rakesh Gupta
Re: Review Request 74740: RANGER-4519: Update ServiceDef icons in service manager page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74740/ --- (Updated Dec. 1, 2023, 11:56 a.m.) Review request for ranger, Dhaval Rajpara and Mugdha Varadkar. Bugs: RANGER-4519 https://issues.apache.org/jira/browse/RANGER-4519 Repository: ranger Description --- Update ServiceDef icons in service manager page. The service manager page currently uses a folder icon for displaying ServiceDefs. We should update this to show a real logo or icon that is specific to each ServiceDef. Diffs (updated) - security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/atlas/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/elasticsearch/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hbase/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hdfs/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hive/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kafka/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/knox/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kudu/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kylin/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi-registry/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/ozone/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/presto/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/schema-registry/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/solr/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/sqoop/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/storm/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/trino/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/yarn/icon.svg PRE-CREATION security-admin/src/main/webapp/react-webapp/src/styles/style.css 10f47923b security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 9f6706261 security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx bedce6f4b Diff: https://reviews.apache.org/r/74740/diff/2/ Changes: https://reviews.apache.org/r/74740/diff/1-2/ Testing --- Testing is in progress Thanks, Brijesh Bhalala
[jira] [Updated] (RANGER-4519) Update ServiceDef icons in service manager page
[ https://issues.apache.org/jira/browse/RANGER-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brijesh Bhalala updated RANGER-4519: Attachment: 0002-RANGER-4519.patch > Update ServiceDef icons in service manager page > --- > > Key: RANGER-4519 > URL: https://issues.apache.org/jira/browse/RANGER-4519 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Brijesh Bhalala >Assignee: Brijesh Bhalala >Priority: Major > Labels: ranger-react > Fix For: 3.0.0 > > Attachments: 0001-RANGER-4519.patch, 0002-RANGER-4519.patch > > > Update ServiceDef icons in service manager page. > The service manager page currently uses a folder icon for displaying > ServiceDefs. > We should update this to show a real logo or icon that is specific to each > ServiceDef. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74756: RANGER-4559: Migrate Ranger modules to junit5 - phase 1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74756/#review226026 --- Ship it! Ship It! - Dineshkumar Yadav On Nov. 25, 2023, 6:51 p.m., Kishor Gollapalliwar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74756/ > --- > > (Updated Nov. 25, 2023, 6:51 p.m.) > > > Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan > Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-4559 > https://issues.apache.org/jira/browse/RANGER-4559 > > > Repository: ranger > > > Description > --- > > This sub-task is responsible to migrate following maven sub-modules to junit5. > > 01. conditions-enrichers > 02. credentialsbuilder > 03. embeddedwebserver > 04. jisql > 05. ldapconfigcheck > 06. ranger-atlas-plugin > 07. ranger-atlas-plugin-shim > 08. ranger-authn > 09. ranger-common-ha > 10. ranger-elasticsearch-plugin > 11. ranger-elasticsearch-plugin-shim > 12. ranger-hive-plugin > 13. ranger-hive-plugin-shim > 14. ranger-intg > 15. ranger-kafka-plugin > 16. ranger-kafka-plugin-shim > > > Diffs > - > > credentialbuilder/pom.xml c18d5585c > > credentialbuilder/src/test/java/org/apache/ranger/credentialapi/TestCredentialReader.java > ff3ce843e > > credentialbuilder/src/test/java/org/apache/ranger/credentialapi/Testbuildks.java > c9fb54c00 > hive-agent/pom.xml 8a21ab81d > > hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java > 2f6f1d846 > > hive-agent/src/test/java/org/apache/ranger/services/hive/TestAllHiveOperationInRanger.java > d424bb4fb > intg/pom.xml 4654ef7f7 > intg/src/test/java/org/apache/ranger/TestRangerClient.java 7da6b18a5 > plugin-kafka/pom.xml 9fa913741 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java > f33405a2f > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java > 90bd628f8 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java > 9a7d5fe83 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java > e48dd2535 > ranger-authn/pom.xml 4ee98f8a5 > ranger-common-ha/pom.xml 2faa243e4 > > ranger-common-ha/src/test/java/org/apache/ranger/ha/service/TestRangerServiceServerIdSelector.java > 0cd55a2a6 > ranger-examples/conditions-enrichers/pom.xml 70e9c6c74 > > ranger-examples/conditions-enrichers/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerSampleSimpleMatcherTest.java > 22e298df5 > > > Diff: https://reviews.apache.org/r/74756/diff/1/ > > > Testing > --- > > 1. mvn clean compile package install > 2. mvn clean compile package install -Psecurity-admin-react > > > Thanks, > > Kishor Gollapalliwar > >
