Review Request 74786: RANGER-4602: Upgrade Tomcat to 8.5.96 in all Ranger services

2023-12-12 Thread sanket shelar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74786/
---

Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Bugs: RANGER-4602
https://issues.apache.org/jira/browse/RANGER-4602


Repository: ranger


Description
---

Upgrade Tomcat to 8.5.96 in all Ranger services


Diffs
-

  pom.xml b40fbcc5a 


Diff: https://reviews.apache.org/r/74786/diff/1/


Testing
---


Thanks,

sanket shelar



Review Request 74785: RANGER-4590: Upgrade Tomcat version to 8.5.96

2023-12-12 Thread bhavik patel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74785/
---

Review request for ranger.


Bugs: RANGER-4590
https://issues.apache.org/jira/browse/RANGER-4590


Repository: ranger


Description
---

Upgrade Tomcat version to 8.5.96


Diffs
-

  pom.xml b40fbcc5a 


Diff: https://reviews.apache.org/r/74785/diff/1/


Testing
---

Verified policy and user crude operations.


Thanks,

bhavik patel



[jira] [Updated] (RANGER-4590) Upgrade Tomcat version to 8.5.96

2023-12-12 Thread Bhavik Patel (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bhavik Patel updated RANGER-4590:
-
Attachment: 0001-RANGER-4590-Upgrade-Tomcat-version-to-8.5.96.patch

> Upgrade Tomcat version to 8.5.96
> 
>
> Key: RANGER-4590
> URL: https://issues.apache.org/jira/browse/RANGER-4590
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Bhavik Patel
>Assignee: Bhavik Patel
>Priority: Major
> Attachments: 0001-RANGER-4590-Upgrade-Tomcat-version-to-8.5.96.patch
>
>
> Upgrade Tomcat version to 8.5.96



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (RANGER-4602) Upgrade Tomcat to 8.5.96 in all Ranger services

2023-12-12 Thread Bhavik Patel (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bhavik Patel resolved RANGER-4602.
--
Resolution: Duplicate

> Upgrade Tomcat to 8.5.96 in all Ranger services
> ---
>
> Key: RANGER-4602
> URL: https://issues.apache.org/jira/browse/RANGER-4602
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Sanket Shelar
>Assignee: Sanket Shelar
>Priority: Major
>
> Upgrade Tomcat to 8.5.96 in all Ranger services 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (RANGER-4602) Upgrade Tomcat to 8.5.96 in all Ranger services

2023-12-12 Thread Bhavik Patel (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796033#comment-17796033
 ] 

Bhavik Patel commented on RANGER-4602:
--

Hi [~sanketshelar] I already raised 
https://issues.apache.org/jira/browse/RANGER-4590 to upgrade tomcat version. I 
will raise review request in sometime.

> Upgrade Tomcat to 8.5.96 in all Ranger services
> ---
>
> Key: RANGER-4602
> URL: https://issues.apache.org/jira/browse/RANGER-4602
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Sanket Shelar
>Assignee: Sanket Shelar
>Priority: Major
>
> Upgrade Tomcat to 8.5.96 in all Ranger services 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (RANGER-4602) Upgrade Tomcat to 8.5.96 in all Ranger services

2023-12-12 Thread Sanket Shelar (Jira)
Sanket Shelar created RANGER-4602:
-

 Summary: Upgrade Tomcat to 8.5.96 in all Ranger services
 Key: RANGER-4602
 URL: https://issues.apache.org/jira/browse/RANGER-4602
 Project: Ranger
  Issue Type: Task
  Components: Ranger
Reporter: Sanket Shelar
Assignee: Sanket Shelar


Upgrade Tomcat to 8.5.96 in all Ranger services 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74778: RANGER-4587: blog: dynamic expressions

2023-12-12 Thread Barbara Eckman via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74778/#review226045
---


Ship it!




Ship It!

- Barbara Eckman


On Dec. 11, 2023, 2:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74778/
> ---
> 
> (Updated Dec. 11, 2023, 2:16 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Monika 
> Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4587
> https://issues.apache.org/jira/browse/RANGER-4587
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> added blog with details of using dynamic expressions in Apache Ranger policies
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/blogs/dynamic_expressions.html PRE-CREATION 
>   docs/src/site/xdoc/blogs.xml 2f81ef7c4 
> 
> 
> Diff: https://reviews.apache.org/r/74778/diff/1/
> 
> 
> Testing
> ---
> 
> - built and ran updated docs with mvn site:run
> - verified that the new blog is seen in the blog list
> - verified that the new blog renders correctly in browser
> 
> 
> File Attachments
> 
> 
> Apache Ranger - dynamic expressions.pdf
>   
> https://reviews.apache.org/media/uploaded/files/2023/12/11/a8d4e7f9-5ec7-4527-9d3c-245c15f49573__Apache_Ranger_-_dynamic_expressions.pdf
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74778: RANGER-4587: blog: dynamic expressions

2023-12-12 Thread Barbara Eckman via Review Board


> On Dec. 11, 2023, 6 p.m., Barbara Eckman wrote:
> > This is a great idea! It's very useful to have all dynamic expressions in 
> > one place!
> > 
> > One example is incorrect, though:  "data_source in 
> > (${{USER.allowedSources}})".  The problem is that IN requires an array on 
> > the RHS, but (${{USER.allowedSources}}) evaluates to "(source1, source2)." 
> > Using GET_USER_ATTR_Q just adds quotes around yields "source1, source2", 
> > but it doesn't create an array.  A split is needed, or the notation 
> > [[USER.allowedSources]], a la RANGER-2434.
> 
> Barbara Eckman wrote:
> My preferred method of addressing this would be changing the type of the 
> UserStore from Map> to Map ArrayList> or some such.  Apache Atlas handles array-valued 
> attributes of tags. It would be great if Ranger handled arrays too!
> 
> Madhan Neethiraj wrote:
> @Barbara -  good point! I will add a note in the blog that the expression 
> should evaluate to a valid value for the context. In this example, 
> data_source is a numeric column with USER.allowedSources having list of 
> numbers separated by a comma - like 10,11,18.
> 
> Let's look for an easier way to handle the use case you raised. How about 
> this?:  data_source in (QUOTED_CSV(USER.allowedSources))
> 
> Barbara Eckman wrote:
> I tried QUOTED_CSV() but got this error:
> ERROR [main] (RangerRequestScriptEvaluator.java:264) - 
> RangerRequestScriptEvaluator.evaluateScript(): failed to evaluate script
> javax.script.ScriptException: ReferenceError: "QUOTED_CSV" is not defined 
> in  at line number 1
> 
> Barbara Eckman wrote:
> Maybe i didn't understand your comment, but I tried the following:
> USER.EventType = "10,20,30"
> condition: 10 in (USER.EventType)
> Error message:
> ERROR [main] (RangerRequestScriptEvaluator.java:264) - 
> RangerRequestScriptEvaluator.evaluateScript(): failed to evaluate script
> javax.script.ScriptException: TypeError: Right hand side of "in" cannot 
> be non-Object, found string in  at line number 1
> 
> Am I missing something?
> 
> Madhan Neethiraj wrote:
> Barbara - the example row-filter expression (given below) would be 
> evaluated by Ranger policy engine to "data_source in (10,11,16)", which would 
> then be executed in a SQL engine.
>   data_source in (${{USER.allowedSources}})
> 
> Also, reference to QUOTED_CSV() in my earlier comment was about an 
> enhancement TBD. Ranger community will continue to review and enhance to 
> support more use cases.
> 
> In your use case here, user attribute EventType is a 
> comma-separated-value string. This needs to be parsed into an array/list 
> before checking if a value exists is present. Perhaps we should look into 
> adding PARSE_CSV() method? Then the condition can be written as:
>   PARSE_CSV(USER.EventType).includes(10)

Hi Madhan,

Sorry for the confusion, I should have realized that in a row filter the syntax 
will be of the underlying engine.

You said: 
"In your use case here, user attribute EventType is a comma-separated-value 
string. This needs to be parsed into an array/list before checking if a value 
exists is present. Perhaps we should look into adding PARSE_CSV() method? Then 
the condition can be written as:
  PARSE_CSV(USER.EventType).includes(10)"

This is PRECISELY the use case for RANGER-2434: eliminate the need for 
"split"-ing delimited strings into arrays by using the notation [[ 
,'']].  Personally, I prefer this notation to 
something referring to "comma-separated values" and then taking a different 
delimiter as a param.:-). It does seems to work in row filters as well as other 
policy conditions, but I admit I haven't tried it with hive.


- Barbara


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74778/#review226035
---


On Dec. 11, 2023, 2:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74778/
> ---
> 
> (Updated Dec. 11, 2023, 2:16 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Monika 
> Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4587
> https://issues.apache.org/jira/browse/RANGER-4587
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> added blog with details of using dynamic expressions in Apache Ranger policies
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/blogs/dynamic_expressions.html PRE-CREATION 
>   docs/src/site/xdoc/blogs.xml 2f81ef7c4 
> 
> 
> Diff: https://reviews.apache.org/r/74778/diff/1/
> 
> 
> Testing
> ---
> 
> - built and ran updated docs with mvn site:run
> - verified 

Re: Review Request 74778: RANGER-4587: blog: dynamic expressions

2023-12-12 Thread Madhan Neethiraj


> On Dec. 11, 2023, 6 p.m., Barbara Eckman wrote:
> > This is a great idea! It's very useful to have all dynamic expressions in 
> > one place!
> > 
> > One example is incorrect, though:  "data_source in 
> > (${{USER.allowedSources}})".  The problem is that IN requires an array on 
> > the RHS, but (${{USER.allowedSources}}) evaluates to "(source1, source2)." 
> > Using GET_USER_ATTR_Q just adds quotes around yields "source1, source2", 
> > but it doesn't create an array.  A split is needed, or the notation 
> > [[USER.allowedSources]], a la RANGER-2434.
> 
> Barbara Eckman wrote:
> My preferred method of addressing this would be changing the type of the 
> UserStore from Map> to Map ArrayList> or some such.  Apache Atlas handles array-valued 
> attributes of tags. It would be great if Ranger handled arrays too!
> 
> Madhan Neethiraj wrote:
> @Barbara -  good point! I will add a note in the blog that the expression 
> should evaluate to a valid value for the context. In this example, 
> data_source is a numeric column with USER.allowedSources having list of 
> numbers separated by a comma - like 10,11,18.
> 
> Let's look for an easier way to handle the use case you raised. How about 
> this?:  data_source in (QUOTED_CSV(USER.allowedSources))
> 
> Barbara Eckman wrote:
> I tried QUOTED_CSV() but got this error:
> ERROR [main] (RangerRequestScriptEvaluator.java:264) - 
> RangerRequestScriptEvaluator.evaluateScript(): failed to evaluate script
> javax.script.ScriptException: ReferenceError: "QUOTED_CSV" is not defined 
> in  at line number 1
> 
> Barbara Eckman wrote:
> Maybe i didn't understand your comment, but I tried the following:
> USER.EventType = "10,20,30"
> condition: 10 in (USER.EventType)
> Error message:
> ERROR [main] (RangerRequestScriptEvaluator.java:264) - 
> RangerRequestScriptEvaluator.evaluateScript(): failed to evaluate script
> javax.script.ScriptException: TypeError: Right hand side of "in" cannot 
> be non-Object, found string in  at line number 1
> 
> Am I missing something?

Barbara - the example row-filter expression (given below) would be evaluated by 
Ranger policy engine to "data_source in (10,11,16)", which would then be 
executed in a SQL engine.
  data_source in (${{USER.allowedSources}})

Also, reference to QUOTED_CSV() in my earlier comment was about an enhancement 
TBD. Ranger community will continue to review and enhance to support more use 
cases.

In your use case here, user attribute EventType is a comma-separated-value 
string. This needs to be parsed into an array/list before checking if a value 
exists is present. Perhaps we should look into adding PARSE_CSV() method? Then 
the condition can be written as:
  PARSE_CSV(USER.EventType).includes(10)


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74778/#review226035
---


On Dec. 11, 2023, 2:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74778/
> ---
> 
> (Updated Dec. 11, 2023, 2:16 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Monika 
> Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4587
> https://issues.apache.org/jira/browse/RANGER-4587
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> added blog with details of using dynamic expressions in Apache Ranger policies
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/blogs/dynamic_expressions.html PRE-CREATION 
>   docs/src/site/xdoc/blogs.xml 2f81ef7c4 
> 
> 
> Diff: https://reviews.apache.org/r/74778/diff/1/
> 
> 
> Testing
> ---
> 
> - built and ran updated docs with mvn site:run
> - verified that the new blog is seen in the blog list
> - verified that the new blog renders correctly in browser
> 
> 
> File Attachments
> 
> 
> Apache Ranger - dynamic expressions.pdf
>   
> https://reviews.apache.org/media/uploaded/files/2023/12/11/a8d4e7f9-5ec7-4527-9d3c-245c15f49573__Apache_Ranger_-_dynamic_expressions.pdf
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74778: RANGER-4587: blog: dynamic expressions

2023-12-12 Thread Barbara Eckman via Review Board


> On Dec. 11, 2023, 6 p.m., Barbara Eckman wrote:
> > This is a great idea! It's very useful to have all dynamic expressions in 
> > one place!
> > 
> > One example is incorrect, though:  "data_source in 
> > (${{USER.allowedSources}})".  The problem is that IN requires an array on 
> > the RHS, but (${{USER.allowedSources}}) evaluates to "(source1, source2)." 
> > Using GET_USER_ATTR_Q just adds quotes around yields "source1, source2", 
> > but it doesn't create an array.  A split is needed, or the notation 
> > [[USER.allowedSources]], a la RANGER-2434.
> 
> Barbara Eckman wrote:
> My preferred method of addressing this would be changing the type of the 
> UserStore from Map> to Map ArrayList> or some such.  Apache Atlas handles array-valued 
> attributes of tags. It would be great if Ranger handled arrays too!
> 
> Madhan Neethiraj wrote:
> @Barbara -  good point! I will add a note in the blog that the expression 
> should evaluate to a valid value for the context. In this example, 
> data_source is a numeric column with USER.allowedSources having list of 
> numbers separated by a comma - like 10,11,18.
> 
> Let's look for an easier way to handle the use case you raised. How about 
> this?:  data_source in (QUOTED_CSV(USER.allowedSources))
> 
> Barbara Eckman wrote:
> I tried QUOTED_CSV() but got this error:
> ERROR [main] (RangerRequestScriptEvaluator.java:264) - 
> RangerRequestScriptEvaluator.evaluateScript(): failed to evaluate script
> javax.script.ScriptException: ReferenceError: "QUOTED_CSV" is not defined 
> in  at line number 1

Maybe i didn't understand your comment, but I tried the following:
USER.EventType = "10,20,30"
condition: 10 in (USER.EventType)
Error message:
ERROR [main] (RangerRequestScriptEvaluator.java:264) - 
RangerRequestScriptEvaluator.evaluateScript(): failed to evaluate script
javax.script.ScriptException: TypeError: Right hand side of "in" cannot be 
non-Object, found string in  at line number 1

Am I missing something?


- Barbara


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74778/#review226035
---


On Dec. 11, 2023, 2:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74778/
> ---
> 
> (Updated Dec. 11, 2023, 2:16 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Monika 
> Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4587
> https://issues.apache.org/jira/browse/RANGER-4587
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> added blog with details of using dynamic expressions in Apache Ranger policies
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/blogs/dynamic_expressions.html PRE-CREATION 
>   docs/src/site/xdoc/blogs.xml 2f81ef7c4 
> 
> 
> Diff: https://reviews.apache.org/r/74778/diff/1/
> 
> 
> Testing
> ---
> 
> - built and ran updated docs with mvn site:run
> - verified that the new blog is seen in the blog list
> - verified that the new blog renders correctly in browser
> 
> 
> File Attachments
> 
> 
> Apache Ranger - dynamic expressions.pdf
>   
> https://reviews.apache.org/media/uploaded/files/2023/12/11/a8d4e7f9-5ec7-4527-9d3c-245c15f49573__Apache_Ranger_-_dynamic_expressions.pdf
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74778: RANGER-4587: blog: dynamic expressions

2023-12-12 Thread Barbara Eckman via Review Board


> On Dec. 11, 2023, 6 p.m., Barbara Eckman wrote:
> > This is a great idea! It's very useful to have all dynamic expressions in 
> > one place!
> > 
> > One example is incorrect, though:  "data_source in 
> > (${{USER.allowedSources}})".  The problem is that IN requires an array on 
> > the RHS, but (${{USER.allowedSources}}) evaluates to "(source1, source2)." 
> > Using GET_USER_ATTR_Q just adds quotes around yields "source1, source2", 
> > but it doesn't create an array.  A split is needed, or the notation 
> > [[USER.allowedSources]], a la RANGER-2434.
> 
> Barbara Eckman wrote:
> My preferred method of addressing this would be changing the type of the 
> UserStore from Map> to Map ArrayList> or some such.  Apache Atlas handles array-valued 
> attributes of tags. It would be great if Ranger handled arrays too!
> 
> Madhan Neethiraj wrote:
> @Barbara -  good point! I will add a note in the blog that the expression 
> should evaluate to a valid value for the context. In this example, 
> data_source is a numeric column with USER.allowedSources having list of 
> numbers separated by a comma - like 10,11,18.
> 
> Let's look for an easier way to handle the use case you raised. How about 
> this?:  data_source in (QUOTED_CSV(USER.allowedSources))

I tried QUOTED_CSV() but got this error:
ERROR [main] (RangerRequestScriptEvaluator.java:264) - 
RangerRequestScriptEvaluator.evaluateScript(): failed to evaluate script
javax.script.ScriptException: ReferenceError: "QUOTED_CSV" is not defined in 
 at line number 1


- Barbara


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74778/#review226035
---


On Dec. 11, 2023, 2:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74778/
> ---
> 
> (Updated Dec. 11, 2023, 2:16 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Monika 
> Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4587
> https://issues.apache.org/jira/browse/RANGER-4587
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> added blog with details of using dynamic expressions in Apache Ranger policies
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/blogs/dynamic_expressions.html PRE-CREATION 
>   docs/src/site/xdoc/blogs.xml 2f81ef7c4 
> 
> 
> Diff: https://reviews.apache.org/r/74778/diff/1/
> 
> 
> Testing
> ---
> 
> - built and ran updated docs with mvn site:run
> - verified that the new blog is seen in the blog list
> - verified that the new blog renders correctly in browser
> 
> 
> File Attachments
> 
> 
> Apache Ranger - dynamic expressions.pdf
>   
> https://reviews.apache.org/media/uploaded/files/2023/12/11/a8d4e7f9-5ec7-4527-9d3c-245c15f49573__Apache_Ranger_-_dynamic_expressions.pdf
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74695: RANGER-4492: Optimize "plugins/definitions" API Call for Initial Load in Multiple Ranger-React Modules

2023-12-12 Thread Brijesh Bhalala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74695/
---

(Updated Dec. 12, 2023, 1:40 p.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, 
Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4492
https://issues.apache.org/jira/browse/RANGER-4492


Repository: ranger


Description
---

In Ranger React, we have already implemented the "plugins/definitions" API call 
at the initial load for optimization. 

This optimization is currently implemented on the Service Manager page and 
needs to be extended to the following modules:
1)Audit
2)Report
3)Security Zone
4)Key Manager

This enhancement aims to improve the initial load performance by efficiently 
utilizing the "plugins/definitions" API call across multiple modules within 
Ranger-React.


Diffs (updated)
-

  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx
 dc75efe50 
  
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 
5f7fc8af0 
  
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx
 19629d6aa 
  
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx
 7eb67544d 


Diff: https://reviews.apache.org/r/74695/diff/2/

Changes: https://reviews.apache.org/r/74695/diff/1-2/


Testing
---

Testing is in progress


Thanks,

Brijesh Bhalala



[jira] [Updated] (RANGER-4492) Optimize "plugins/definitions" API Call for Initial Load in Multiple Ranger-React Modules

2023-12-12 Thread Brijesh Bhalala (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4492:

Attachment: 0002-RANGER-4492.patch

> Optimize "plugins/definitions" API Call for Initial Load in Multiple 
> Ranger-React Modules
> -
>
> Key: RANGER-4492
> URL: https://issues.apache.org/jira/browse/RANGER-4492
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Brijesh Bhalala
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4492.patch, 0002-RANGER-4492.patch
>
>
> In Ranger React, we have already implemented the "plugins/definitions" API 
> call at the initial load for optimization. 
> This optimization is currently implemented on the Service Manager page and 
> needs to be extended to the following modules:
> 1)Audit
> 2)Report
> 3)Security Zone
> 4)Key Manager
> This enhancement aims to improve the initial load performance by efficiently 
> utilizing the "plugins/definitions" API call across multiple modules within 
> Ranger-React.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (RANGER-4519) Update ServiceDef icons in service manager page

2023-12-12 Thread Brijesh Bhalala (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795712#comment-17795712
 ] 

Brijesh Bhalala commented on RANGER-4519:
-

commited to [Apache 
master|https://github.com/apache/ranger/commit/1d6a82cd1615083e0d5c799210aca65fd75542a5]
 branch

> Update ServiceDef icons in service manager page
> ---
>
> Key: RANGER-4519
> URL: https://issues.apache.org/jira/browse/RANGER-4519
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Brijesh Bhalala
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4519.patch, 0002-RANGER-4519.patch, 
> serviceDefSS.png
>
>
> Update ServiceDef icons in service manager page.
> The service manager page currently uses a  folder icon for displaying 
> ServiceDefs.
> We should update this to show a real logo or icon that is specific to each 
> ServiceDef.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Review Request 74784: RANGER-4601: /xaudit/access_audit/count API does not return the proper value

2023-12-12 Thread Abhishek Patil

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74784/
---

Review request for ranger, Mehul Parikh and Pradeep Agrawal.


Bugs: RANGER-4601
https://issues.apache.org/jira/browse/RANGER-4601


Repository: ranger


Description
---

/xaudit/access_audit/count did not work properly, and always returned the 
following response
{"value": "100"}
This fix addresses the issue, and ensures that the proper count is returned in 
the response


Diffs
-

  security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java 36631c82c 


Diff: https://reviews.apache.org/r/74784/diff/1/


Testing
---

Applied the patch on a cluster and made a GET request to 
/xaudit/access_audit/count,
and ensured that the proper count is returned in the response.


Thanks,

Abhishek Patil



[jira] [Created] (RANGER-4601) /xaudit/access_audit/count API does not return the proper value

2023-12-12 Thread Abhishek (Jira)
Abhishek created RANGER-4601:


 Summary: /xaudit/access_audit/count API does not return the proper 
value
 Key: RANGER-4601
 URL: https://issues.apache.org/jira/browse/RANGER-4601
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Abhishek
Assignee: Abhishek


/xaudit/access_audit/count API does not return the proper value



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Review Request 74782: RANGER-4600: Add improvement for /xaudit/access_audit API based on user role

2023-12-12 Thread Abhishek Patil

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74782/
---

Review request for ranger, Mehul Parikh and Pradeep Agrawal.


Bugs: RANGER-4600
https://issues.apache.org/jira/browse/RANGER-4600


Repository: ranger


Description
---

Add improvement for /xaudit/access_audit for keyadmin users.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java 36631c82c 


Diff: https://reviews.apache.org/r/74782/diff/1/


Testing
---

Applied the patch on a cluster and tested the following scenarios :-
1. Admin / Auditor users should be able to fetch access audits for non KMS 
related operations
2. Keyadmin / Key auditor users should be able to fetch access audits only for 
KMS related operations


Thanks,

Abhishek Patil



Re: Review Request 74740: RANGER-4519: Update ServiceDef icons in service manager page

2023-12-12 Thread Mugdha Varadkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74740/#review226040
---


Ship it!




Ship It!

- Mugdha Varadkar


On Dec. 12, 2023, 9:37 a.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74740/
> ---
> 
> (Updated Dec. 12, 2023, 9:37 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan 
> Neethiraj, Mehul Parikh, Mugdha Varadkar, and Nikunj Pansuriya.
> 
> 
> Bugs: RANGER-4519
> https://issues.apache.org/jira/browse/RANGER-4519
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Update ServiceDef icons in service manager page.
> 
> The service manager page currently uses a  folder icon for displaying 
> ServiceDefs.
> We should update this to show a real logo or icon that is specific to each 
> ServiceDef.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/atlas/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/elasticsearch/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hbase/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hdfs/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hive/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kafka/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/knox/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kudu/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kylin/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi-registry/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/ozone/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/presto/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/schema-registry/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/solr/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/sqoop/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/storm/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/trino/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/yarn/icon.svg
>  PRE-CREATION 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 10f47923b 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 9f6706261 
>   
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx
>  bedce6f4b 
> 
> 
> Diff: https://reviews.apache.org/r/74740/diff/2/
> 
> 
> Testing
> ---
> 
> Tested changes on a cluster setup with Ranger Admin build with React JS code 
> base.
> Verified the logos are visible for services in Service Manager landing page.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>



Re: Review Request 74740: RANGER-4519: Update ServiceDef icons in service manager page

2023-12-12 Thread Brijesh Bhalala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74740/
---

(Updated Dec. 12, 2023, 9:37 a.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, 
Mehul Parikh, Mugdha Varadkar, and Nikunj Pansuriya.


Bugs: RANGER-4519
https://issues.apache.org/jira/browse/RANGER-4519


Repository: ranger


Description
---

Update ServiceDef icons in service manager page.

The service manager page currently uses a  folder icon for displaying 
ServiceDefs.
We should update this to show a real logo or icon that is specific to each 
ServiceDef.


Diffs
-

  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/atlas/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/elasticsearch/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hbase/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hdfs/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hive/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kafka/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/knox/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kudu/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kylin/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi-registry/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/ozone/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/presto/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/schema-registry/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/solr/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/sqoop/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/storm/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/trino/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/yarn/icon.svg
 PRE-CREATION 
  security-admin/src/main/webapp/react-webapp/src/styles/style.css 10f47923b 
  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 9f6706261 
  
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx
 bedce6f4b 


Diff: https://reviews.apache.org/r/74740/diff/2/


Testing (updated)
---

Tested changes on a cluster setup with Ranger Admin build with React JS code 
base.
Verified the logos are visible for services in Service Manager landing page.


Thanks,

Brijesh Bhalala



Re: Review Request 74740: RANGER-4519: Update ServiceDef icons in service manager page

2023-12-12 Thread Brijesh Bhalala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74740/
---

(Updated Dec. 12, 2023, 9:36 a.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, 
Mehul Parikh, Mugdha Varadkar, and Nikunj Pansuriya.


Bugs: RANGER-4519
https://issues.apache.org/jira/browse/RANGER-4519


Repository: ranger


Description
---

Update ServiceDef icons in service manager page.

The service manager page currently uses a  folder icon for displaying 
ServiceDefs.
We should update this to show a real logo or icon that is specific to each 
ServiceDef.


Diffs
-

  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/atlas/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/elasticsearch/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hbase/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hdfs/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hive/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kafka/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/knox/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kudu/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kylin/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi-registry/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/ozone/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/presto/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/schema-registry/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/solr/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/sqoop/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/storm/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/trino/icon.svg
 PRE-CREATION 
  
security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/yarn/icon.svg
 PRE-CREATION 
  security-admin/src/main/webapp/react-webapp/src/styles/style.css 10f47923b 
  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 9f6706261 
  
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx
 bedce6f4b 


Diff: https://reviews.apache.org/r/74740/diff/2/


Testing (updated)
---

Tested changes on a cluster setup with Ranger Admin build with React JS code 
base.
Verified the Service Manager landing page.


Thanks,

Brijesh Bhalala



Re: Review Request 74740: RANGER-4519: Update ServiceDef icons in service manager page

2023-12-12 Thread Mugdha Varadkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74740/#review226039
---


Ship it!




Ship It!

- Mugdha Varadkar


On Dec. 1, 2023, 11:58 a.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74740/
> ---
> 
> (Updated Dec. 1, 2023, 11:58 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan 
> Neethiraj, Mehul Parikh, Mugdha Varadkar, and Nikunj Pansuriya.
> 
> 
> Bugs: RANGER-4519
> https://issues.apache.org/jira/browse/RANGER-4519
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Update ServiceDef icons in service manager page.
> 
> The service manager page currently uses a  folder icon for displaying 
> ServiceDefs.
> We should update this to show a real logo or icon that is specific to each 
> ServiceDef.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/atlas/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/elasticsearch/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hbase/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hdfs/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hive/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kafka/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/knox/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kudu/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kylin/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi-registry/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/ozone/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/presto/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/schema-registry/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/solr/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/sqoop/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/storm/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/trino/icon.svg
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/yarn/icon.svg
>  PRE-CREATION 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 10f47923b 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 9f6706261 
>   
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx
>  bedce6f4b 
> 
> 
> Diff: https://reviews.apache.org/r/74740/diff/2/
> 
> 
> Testing
> ---
> 
> Testing is in progress
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>



[jira] [Created] (RANGER-4600) Add improvement for /xaudit/access_audit API based on user role

2023-12-12 Thread Abhishek (Jira)
Abhishek created RANGER-4600:


 Summary: Add improvement for /xaudit/access_audit API based on 
user role
 Key: RANGER-4600
 URL: https://issues.apache.org/jira/browse/RANGER-4600
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Abhishek
Assignee: Abhishek


Add improvement for /xaudit/access_audit API based on user role



--
This message was sent by Atlassian Jira
(v8.20.10#820010)