Re: Review Request 74228: RANGER-3993:Upgrade okhttp dependency

2023-12-14 Thread Vikas Kumar 


> On Nov. 22, 2023, 10:27 a.m., Vikas Kumar wrote:
> > security-admin/pom.xml
> > Lines 320 (patched)
> > 
> >
> > Why do we need to define this dependency explicitly ?
> > 
> > KMS (may be some other modules as well) has transitive dependency on 
> > "okhttp" and "okhttp-urlconnection". I can't find any direct dependency on 
> > these.
> > 
> > So, simply updating the version of okhttp in distro/kms.xml should be 
> > sufficient. 
> > 
> > Please let me know your thoughts on this.
> 
> bhavik patel wrote:
> There is no direct dependency, but to avoid transitive dependency I have 
> included Separately.
> 
> Vikas Kumar wrote:
> Sorry, I am not getting this. This way we will have to define exact 
> version for all transitive dependencies, and that too in all modules. 
> Instead of that, can't we simply update in distro that defines the 
> runtime required libs. 
> 
> Can you help me with the Admin lib jar that has indirect dependency on 
> okhttp?
> 
> bhavik patel wrote:
> Directly defining in distro will only help when we get that exact version 
> from the trasitive dependency. 
> 
> I will revisite my changes and update the patch if required in next week.

Hi Bhavik, I tried my approach to directly updating the version in distro file 
but it is getting more complicated, instead let application moduless define 
their dependencies. And their your approach makes more sense to me now.

But shouldn't we consider following:

Instead of defining dependencies in module's pom, use  to 
override in parent pom and exclude from respective module's pom.

For ex: for your case, exclude from admin pon and override using 
 in parent pom?

What's your thought on this?

PS: Dropping my earlier review comment.


- Vikas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74228/#review225989
---


On Nov. 22, 2023, 4:27 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74228/
> ---
> 
> (Updated Nov. 22, 2023, 4:27 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Madhan Neethiraj, Pradeep Agrawal, 
> Ramesh Mani, and Vikas Kumar.
> 
> 
> Bugs: RANGER-3993
> https://issues.apache.org/jira/browse/RANGER-3993
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Upgrade okhttp dependency
> 
> 
> Diffs
> -
> 
>   pom.xml 7b0dd14c5 
>   security-admin/pom.xml 5e24dd846 
> 
> 
> Diff: https://reviews.apache.org/r/74228/diff/1/
> 
> 
> Testing
> ---
> 
> Validated Ranger admin and KMS CRUD operations.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 74775: RANGER-4502 : Getting Error to load backbone.js latest UI.

2023-12-14 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74775/#review226056
---


Ship it!




Ship It!

- Mugdha Varadkar


On Dec. 14, 2023, 10:42 a.m., Dhaval Rajpara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74775/
> ---
> 
> (Updated Dec. 14, 2023, 10:42 a.m.)
> 
> 
> Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, 
> Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, 
> Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4502
> https://issues.apache.org/jira/browse/RANGER-4502
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Step to reproduce:
> 
> 1) Login to ranger admin UI
> 2) go to the profile drop-down
> 3) Click on Switch to latest UI
> 
> Result in "NO services found" page displayed. But we have services present in 
> Backbone Classic UI.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js
>  965c52c37 
> 
> 
> Diff: https://reviews.apache.org/r/74775/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that with patch latest UI load properly and Validated below scenarios
> 1. Tested Resource Based/Tag Based/ KMS Service CRUD.
> 2. Tested Zone & Unzone policy CRUD.
> 3. Tested User/Group/ Role CRUD.
> 4. Tested Zone CRUD.
> 5. Tested Resource Based/Tag Based/ KMS Policy CRUD.
> 6. Tested reports/permissions/audits tab.
> 7. Tested Export and import feature.
> 
> 
> Thanks,
> 
> Dhaval Rajpara
> 
>

Re: Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74795/#review226055
---


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 15, 2023, 12:03 a.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74795/
> ---
> 
> (Updated Dec. 15, 2023, 12:03 a.m.)
> 
> 
> Review request for ranger, madhan, Madhan Neethiraj, Pradeep Agrawal, Ramesh 
> Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4609
> https://issues.apache.org/jira/browse/RANGER-4609
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> As a part of test infrastructure, a file-based tag retriever class is 
> created. When the TagEnricher is configured with this class, a plugin gets 
> the tag from the configured file.
> 
> Please refer to the Service-definition for tag for tagRetrieverClassName in 
> enricherOptions.
> 
> If the value of this option is set to 
> 
> org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever
> 
> then, the tags will be fetched for a file named by the value of the enricher 
> option 
> 
> "serviceTagsFileName".
> 
> "contextEnrichers":[
> {
> "itemId": 1,
> "name" : "TagEnricher",
> "enricher" : "org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
> "enricherOptions" : {
> "tagRetrieverClassName": 
> "org.apache.ranger.plugin.contextenricher.RangerAdminTagRetriever",
> "tagRefresherPollingInterval": 6
> }
> }]
> This enhancement supports specifying another enricher option "tagFileCount". 
> When this is set to a value greater than 0, each successive call made to 
> fetch tags will provide tags from the file name obtained by adding a suffix 
> [0.. tagFileCount-1].json to the file named by the option 
> "serviceTagsFileName". When tag-delta files are set up with appropriate 
> suffixes, this simulates the fetching of successive tag-deltas for processing.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
>  448c665fc 
> 
> 
> Diff: https://reviews.apache.org/r/74795/diff/2/
> 
> 
> Testing
> ---
> 
> Compiled and ran all unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74795/
---

(Updated Dec. 15, 2023, 12:03 a.m.)


Review request for ranger, madhan, Madhan Neethiraj, Pradeep Agrawal, Ramesh 
Mani, and Velmurugan Periasamy.


Bugs: RANGER-4609
https://issues.apache.org/jira/browse/RANGER-4609


Repository: ranger


Description
---

As a part of test infrastructure, a file-based tag retriever class is created. 
When the TagEnricher is configured with this class, a plugin gets the tag from 
the configured file.

Please refer to the Service-definition for tag for tagRetrieverClassName in 
enricherOptions.

If the value of this option is set to 

org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever

then, the tags will be fetched for a file named by the value of the enricher 
option 

"serviceTagsFileName".

"contextEnrichers":[
{
"itemId": 1,
"name" : "TagEnricher",
"enricher" : "org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
"enricherOptions" : {
"tagRetrieverClassName": 
"org.apache.ranger.plugin.contextenricher.RangerAdminTagRetriever",
"tagRefresherPollingInterval": 6
}
}]
This enhancement supports specifying another enricher option "tagFileCount". 
When this is set to a value greater than 0, each successive call made to fetch 
tags will provide tags from the file name obtained by adding a suffix [0.. 
tagFileCount-1].json to the file named by the option "serviceTagsFileName". 
When tag-delta files are set up with appropriate suffixes, this simulates the 
fetching of successive tag-deltas for processing.


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
 448c665fc 


Diff: https://reviews.apache.org/r/74795/diff/2/

Changes: https://reviews.apache.org/r/74795/diff/1-2/


Testing
---

Compiled and ran all unit tests successfully


Thanks,

Abhay Kulkarni

Re: Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni 


> On Dec. 14, 2023, 11:31 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
> > Lines 44 (patched)
> > 
> >
> > Consider replacing isInitial with currentTagFileIndex == 0.

That will always return the entire tag file to the caller. It's better to keep 
track of first-time call in a separate state variable (like isInitial).


- Abhay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74795/#review226053
---


On Dec. 14, 2023, 10:28 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74795/
> ---
> 
> (Updated Dec. 14, 2023, 10:28 p.m.)
> 
> 
> Review request for ranger, madhan, Madhan Neethiraj, Pradeep Agrawal, Ramesh 
> Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4609
> https://issues.apache.org/jira/browse/RANGER-4609
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> As a part of test infrastructure, a file-based tag retriever class is 
> created. When the TagEnricher is configured with this class, a plugin gets 
> the tag from the configured file.
> 
> Please refer to the Service-definition for tag for tagRetrieverClassName in 
> enricherOptions.
> 
> If the value of this option is set to 
> 
> org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever
> 
> then, the tags will be fetched for a file named by the value of the enricher 
> option 
> 
> "serviceTagsFileName".
> 
> "contextEnrichers":[
> {
> "itemId": 1,
> "name" : "TagEnricher",
> "enricher" : "org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
> "enricherOptions" : {
> "tagRetrieverClassName": 
> "org.apache.ranger.plugin.contextenricher.RangerAdminTagRetriever",
> "tagRefresherPollingInterval": 6
> }
> }]
> This enhancement supports specifying another enricher option "tagFileCount". 
> When this is set to a value greater than 0, each successive call made to 
> fetch tags will provide tags from the file name obtained by adding a suffix 
> [0.. tagFileCount-1].json to the file named by the option 
> "serviceTagsFileName". When tag-delta files are set up with appropriate 
> suffixes, this simulates the fetching of successive tag-deltas for processing.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
>  448c665fc 
> 
> 
> Diff: https://reviews.apache.org/r/74795/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled and ran all unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74795/#review226053
---


Fix it, then Ship it!





agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
Lines 44 (patched)


Consider replacing isInitial with currentTagFileIndex == 0.



agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
Lines 70 (patched)


This would result in NumberFormatException if options doesn't have 
getFileCount entry. Please review and update.


- Madhan Neethiraj


On Dec. 14, 2023, 10:28 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74795/
> ---
> 
> (Updated Dec. 14, 2023, 10:28 p.m.)
> 
> 
> Review request for ranger, madhan, Madhan Neethiraj, Pradeep Agrawal, Ramesh 
> Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4609
> https://issues.apache.org/jira/browse/RANGER-4609
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> As a part of test infrastructure, a file-based tag retriever class is 
> created. When the TagEnricher is configured with this class, a plugin gets 
> the tag from the configured file.
> 
> Please refer to the Service-definition for tag for tagRetrieverClassName in 
> enricherOptions.
> 
> If the value of this option is set to 
> 
> org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever
> 
> then, the tags will be fetched for a file named by the value of the enricher 
> option 
> 
> "serviceTagsFileName".
> 
> "contextEnrichers":[
> {
> "itemId": 1,
> "name" : "TagEnricher",
> "enricher" : "org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
> "enricherOptions" : {
> "tagRetrieverClassName": 
> "org.apache.ranger.plugin.contextenricher.RangerAdminTagRetriever",
> "tagRefresherPollingInterval": 6
> }
> }]
> This enhancement supports specifying another enricher option "tagFileCount". 
> When this is set to a value greater than 0, each successive call made to 
> fetch tags will provide tags from the file name obtained by adding a suffix 
> [0.. tagFileCount-1].json to the file named by the option 
> "serviceTagsFileName". When tag-delta files are set up with appropriate 
> suffixes, this simulates the fetching of successive tag-deltas for processing.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
>  448c665fc 
> 
> 
> Diff: https://reviews.apache.org/r/74795/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled and ran all unit tests successfully
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

[jira] [Updated] (RANGER-4609) Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhay Kulkarni updated RANGER-4609:
---
Description: 
As a part of test infrastructure, a file-based tag retriever class is created. 
When the TagEnricher is configured with this class, a plugin gets the tag from 
the configured file.

Please refer to the Service-definition for tag for tagRetrieverClassName in 
enricherOptions.

If the value of this option is set to 

org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever

then, the tags will be fetched for a file named by the value of the enricher 
option 

"serviceTagsFileName".
{code:java}
"contextEnrichers":[
{
"itemId": 1,
"name" : "TagEnricher",
"enricher" : "org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
"enricherOptions" : {
"tagRetrieverClassName": 
"org.apache.ranger.plugin.contextenricher.RangerAdminTagRetriever",
"tagRefresherPollingInterval": 6
}
}]{code}
This enhancement supports specifying another enricher option "tagFileCount". 
When this is set to a value greater than 0, each successive call made to fetch 
tags will provide tags from the file name obtained by adding a suffix [0.. 
tagFileCount-1].json to the file named by the option "serviceTagsFileName". 
When tag-delta files are set up with appropriate suffixes, this simulates the 
fetching of successive tag-deltas for processing.

 

An example may as follows:
{code:java}
  "contextEnrichers": [
  {
  "itemId": 1,
  "name": "TagEnricher",
  "enricher": 
"org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
"enricherOptions" : 
{"tagRetrieverClassName":"org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever",
 "tagRefresherPollingInterval":1000, 
"serviceTagsFileName":"testdata/test_hive_tag.json", "deDupTags": "false", 
"tagFileCount": "2"}
  }
  ] {code}
where testdata directory contains the following files:

test_hive_tag.json : 
{code:java}
{
"op": "add_or_update",
"serviceName": "test_hive",
"tagVersion": 5,
"tagDefinitions": {
"1": {
"name": "PII",
"source": "Atlas",
"attributeDefs": [],
"id": 1,
"isEnabled": true,
"version": 1
}
},
"tags": {
"1": {
"type": "PII",
"owner": 0,
"attributes": {},
"options": {},
"validityPeriods": [],
"id": 1,
"isEnabled": true
}
},
"serviceResources": [
{
"serviceName": "test_hive",
"resourceElements": {
"database": {
"values": [
"default"
],
"isExcludes": false,
"isRecursive": false
},
"table": {
"values": [
"sample_07"
],
"isExcludes": false,
"isRecursive": false
}
},
"id": 1,
"isEnabled": true,
"version": 2
}
],
"resourceToTagIds": {
"1": [
1
]
},
"isDelta": false,
"tagsChangeExtent": "ALL",
"cachedTags": {}
} {code}
file test_hive_tag.json_0.json
{code:java}
{
"op": "add_or_update",
"serviceName": "test_hive",
"tagVersion": 4,
"tagDefinitions": {
"2": {
"id": 2,
"isEnabled": true,
"version": 1,
"name": "TEST_TAG",
"source": "Atlas",
"attributeDefs": []
}
},
"tags": {
"1": {
"id": 1,
"isEnabled": true,
"type": "PII",
"owner": 0,
"attributes": {},
"options": {},
"validityPeriods": []
},
"2": {
"id": 2,
"isEnabled": true,
"type": "TEST_TAG",
"owner": 0,
"attributes": {},
"options": {},
"validityPeriods": []
}
},
"serviceResources": [
{
"id": 1,
"isEnabled": true,
"version": 4,
"serviceName": "test_hive",
"resourceElements": {
"database": {
"values": [
"default"
],
"isExcludes": false,
"isRecursive": false
},
"table": {
"values": [
"sample_07"
],
"isExcludes": false,
"isRecursive": false
}
}
}
],
"resourceToTagIds": {
"1": [
1,
2
]
},
"isDelta": true,
"tagsCh

Review Request 74795: RANGER-4609: Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74795/
---

Review request for ranger, madhan, Madhan Neethiraj, Pradeep Agrawal, Ramesh 
Mani, and Velmurugan Periasamy.


Bugs: RANGER-4609
https://issues.apache.org/jira/browse/RANGER-4609


Repository: ranger


Description
---

As a part of test infrastructure, a file-based tag retriever class is created. 
When the TagEnricher is configured with this class, a plugin gets the tag from 
the configured file.

Please refer to the Service-definition for tag for tagRetrieverClassName in 
enricherOptions.

If the value of this option is set to 

org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever

then, the tags will be fetched for a file named by the value of the enricher 
option 

"serviceTagsFileName".

"contextEnrichers":[
{
"itemId": 1,
"name" : "TagEnricher",
"enricher" : "org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
"enricherOptions" : {
"tagRetrieverClassName": 
"org.apache.ranger.plugin.contextenricher.RangerAdminTagRetriever",
"tagRefresherPollingInterval": 6
}
}]
This enhancement supports specifying another enricher option "tagFileCount". 
When this is set to a value greater than 0, each successive call made to fetch 
tags will provide tags from the file name obtained by adding a suffix [0.. 
tagFileCount-1].json to the file named by the option "serviceTagsFileName". 
When tag-delta files are set up with appropriate suffixes, this simulates the 
fetching of successive tag-deltas for processing.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java
 448c665fc 


Diff: https://reviews.apache.org/r/74795/diff/1/


Testing
---

Compiled and ran all unit tests successfully


Thanks,

Abhay Kulkarni

[jira] [Created] (RANGER-4609) Support in File-based Tag Retriever to provide tag-deltas

2023-12-14 Thread Abhay Kulkarni (Jira) 
Abhay Kulkarni created RANGER-4609:
--

 Summary: Support in File-based Tag Retriever to provide tag-deltas
 Key: RANGER-4609
 URL: https://issues.apache.org/jira/browse/RANGER-4609
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Abhay Kulkarni
Assignee: Abhay Kulkarni


As a part of test infrastructure, a file-based tag retriever class is created. 
When the TagEnricher is configured with this class, a plugin gets the tag from 
the configured file.

Please refer to the Service-definition for tag for tagRetrieverClassName in 
enricherOptions.

If the value of this option is set to 

org.apache.ranger.plugin.contextenricher.RangerFileBasedTagRetriever

then, the tags will be fetched for a file named by the value of the enricher 
option 

"serviceTagsFileName".
{code:java}
"contextEnrichers":[
{
"itemId": 1,
"name" : "TagEnricher",
"enricher" : "org.apache.ranger.plugin.contextenricher.RangerTagEnricher",
"enricherOptions" : {
"tagRetrieverClassName": 
"org.apache.ranger.plugin.contextenricher.RangerAdminTagRetriever",
"tagRefresherPollingInterval": 6
}
}]{code}
This enhancement supports specifying another enricher option "tagFileCount". 
When this is set to a value greater than 0, each successive call made to fetch 
tags will provide tags from the file name obtained by adding a suffix [0.. 
tagFileCount-1].json to the file named by the option "serviceTagsFileName". 
When tag-delta files are set up with appropriate suffixes, this simulates the 
fetching of successive tag-deltas for processing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4608) Need to add ACL evaluation for get datashare by ID API

2023-12-14 Thread Madhan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated RANGER-4608:
-
Fix Version/s: 3.0.0

> Need to add ACL evaluation for get datashare by ID API 
> ---
>
> Key: RANGER-4608
> URL: https://issues.apache.org/jira/browse/RANGER-4608
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Prashant Satam
>Priority: Major
> Fix For: 3.0.0
>
>
> For GET API for datashare by ID need to add ACL evaluation 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74793: RANGER-4608:Need to add ACL evaluation for get datashare by ID API

2023-12-14 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74793/#review226052
---


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 14, 2023, 10:14 a.m., Prashant Satam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74793/
> ---
> 
> (Updated Dec. 14, 2023, 10:14 a.m.)
> 
> 
> Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan 
> Neethiraj, Monika Kachhadiya, Subhrat Chaudhary, and Vanita Ubale.
> 
> 
> Bugs: RANGER-4608
> https://issues.apache.org/jira/browse/RANGER-4608
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> For GET API for datashare by ID need to add ACL evaluation
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 
> af70daa9d 
> 
> 
> Diff: https://reviews.apache.org/r/74793/diff/1/
> 
> 
> Testing
> ---
> 
> Steps to Test
> 1)create a datashare 
> 2)Get the datashare by a user(this user should not be in ACL of 
> datashare)using GET API service/gds/datashare/{id} 
> 3)Will get Error as user has no permission on the datashare
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>

Re: Review Request 74794: RANGER-4283: UI for GDS : datashare tab in dataset detail view, and shared with tab in datashare detail view integration with summary api

2023-12-14 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74794/#review226051
---


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 14, 2023, 1:08 p.m., Anand Nadar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74794/
> ---
> 
> (Updated Dec. 14, 2023, 1:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, 
> Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-4283
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Datashare tab in dataset detail view, and shared with tab in datashare detail 
> view integration with summary api and filtered them according to shareStatus 
> and paginated them in UI.
> Removed specific conditions step from datashare creation flow
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx
>  e234979d0 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatashareInDatasetListComp.jsx
>  35bb1fb0f 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/MyDatasetListing.jsx
>  87d808ae4 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx
>  6f45b4ed8 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx
>  05baee319 
> 
> 
> Diff: https://reviews.apache.org/r/74794/diff/1/
> 
> 
> Testing
> ---
> 
> Validated listing/serach/delete in datashare tab of dataset detail view and 
> shared with tab of datashare detail view.
> Validated redirection to request detail and dataset/datashare detail page 
> from datashare tab and shared with tab.
> Validated creation of datashare.
> 
> 
> Thanks,
> 
> Anand Nadar
> 
>

Review Request 74794: RANGER-4283: UI for GDS : datashare tab in dataset detail view, and shared with tab in datashare detail view integration with summary api

2023-12-14 Thread Anand Nadar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74794/
---

Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, 
Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary.


Bugs: https://issues.apache.org/jira/browse/RANGER-4283

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283


Repository: ranger


Description
---

Datashare tab in dataset detail view, and shared with tab in datashare detail 
view integration with summary api and filtered them according to shareStatus 
and paginated them in UI.
Removed specific conditions step from datashare creation flow


Diffs
-

  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx
 e234979d0 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatashareInDatasetListComp.jsx
 35bb1fb0f 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/MyDatasetListing.jsx
 87d808ae4 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx
 6f45b4ed8 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx
 05baee319 


Diff: https://reviews.apache.org/r/74794/diff/1/


Testing
---

Validated listing/serach/delete in datashare tab of dataset detail view and 
shared with tab of datashare detail view.
Validated redirection to request detail and dataset/datashare detail page from 
datashare tab and shared with tab.
Validated creation of datashare.


Thanks,

Anand Nadar

Re: Review Request 74775: RANGER-4502 : Getting Error to load backbone.js latest UI.

2023-12-14 Thread Dhaval Rajpara 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74775/
---

(Updated Dec. 14, 2023, 10:42 a.m.)


Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, 
Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Pradeep 
Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-4502
https://issues.apache.org/jira/browse/RANGER-4502


Repository: ranger


Description
---

Step to reproduce:

1) Login to ranger admin UI
2) go to the profile drop-down
3) Click on Switch to latest UI

Result in "NO services found" page displayed. But we have services present in 
Backbone Classic UI.


Diffs
-

  
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js
 965c52c37 


Diff: https://reviews.apache.org/r/74775/diff/1/


Testing (updated)
---

Tested that with patch latest UI load properly and Validated below scenarios
1. Tested Resource Based/Tag Based/ KMS Service CRUD.
2. Tested Zone & Unzone policy CRUD.
3. Tested User/Group/ Role CRUD.
4. Tested Zone CRUD.
5. Tested Resource Based/Tag Based/ KMS Policy CRUD.
6. Tested reports/permissions/audits tab.
7. Tested Export and import feature.


Thanks,

Dhaval Rajpara

Re: Review Request 74728: RANGER-4513: Policy listing page experiences an reset to Access tab when attempting to filter the service and zone dropdown options.

2023-12-14 Thread Brijesh Bhalala 


> On Dec. 14, 2023, 5:53 a.m., Mugdha Varadkar wrote:
> > security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx
> > Line 218 (original), 218 (patched)
> > 
> >
> > We have below solutions to handle this,
> > 
> > 1) We can use hideSelectedOptions props of react-select to hide the 
> > selected option from the menu so that onChange is not triggered for the 
> > same value.
> > 
> > 2) Update the logic in onChange to check if the selected value does 
> > match the currently selected value, then simply do nothing

I have updated this in latest patch


- Brijesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74728/#review226049
---


On Dec. 14, 2023, 10:26 a.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74728/
> ---
> 
> (Updated Dec. 14, 2023, 10:26 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
> 
> 
> Bugs: RANGER-4513
> https://issues.apache.org/jira/browse/RANGER-4513
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The policy listing page experiences an unexpected reset when attempting to 
> filter the service and zone dropdown options. 
> 
> Steps to Reproduce:
>  1)Navigate to the "hive" policy listing page.
>  2)Goto  Masking tab 
>  3)Select the "Service" dropdown to filter policies based on a specific 
> service.
>  4)Select the "Zone" dropdown to filter policies based on  specific zone.
>  5)Observe that the page resets to the default "Access" tab
> 
> Expected Behavior:
> 
> The page should retain the selected tab when filtering the service and zone 
> dropdown.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx
>  7c6b1c19b 
>   security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 
> 860b1ab78 
> 
> 
> Diff: https://reviews.apache.org/r/74728/diff/2/
> 
> 
> Testing
> ---
> 
> Testing is in progress
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 74728: RANGER-4513: Policy listing page experiences an reset to Access tab when attempting to filter the service and zone dropdown options.

2023-12-14 Thread Brijesh Bhalala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74728/
---

(Updated Dec. 14, 2023, 10:26 a.m.)


Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.


Bugs: RANGER-4513
https://issues.apache.org/jira/browse/RANGER-4513


Repository: ranger


Description
---

The policy listing page experiences an unexpected reset when attempting to 
filter the service and zone dropdown options. 

Steps to Reproduce:
 1)Navigate to the "hive" policy listing page.
 2)Goto  Masking tab 
 3)Select the "Service" dropdown to filter policies based on a specific service.
 4)Select the "Zone" dropdown to filter policies based on  specific zone.
 5)Observe that the page resets to the default "Access" tab

Expected Behavior:

The page should retain the selected tab when filtering the service and zone 
dropdown.


Diffs (updated)
-

  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx
 7c6b1c19b 
  security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 
860b1ab78 


Diff: https://reviews.apache.org/r/74728/diff/2/

Changes: https://reviews.apache.org/r/74728/diff/1-2/


Testing
---

Testing is in progress


Thanks,

Brijesh Bhalala

[jira] [Updated] (RANGER-4513) Policy listing page experiences an reset to Access tab when attempting to filter the service and zone dropdown options.

2023-12-14 Thread Brijesh Bhalala (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4513:

Attachment: 0002-RANGER-4513.patch

> Policy listing page experiences an  reset to Access tab when attempting to 
> filter the service and zone dropdown options. 
> -
>
> Key: RANGER-4513
> URL: https://issues.apache.org/jira/browse/RANGER-4513
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Brijesh Bhalala
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4513.patch, 0002-RANGER-4513.patch
>
>
> The policy listing page experiences an unexpected reset when attempting to 
> filter the service and zone dropdown options. 
> *Steps to Reproduce:*
>  # Navigate to the "hive" policy listing page.
>  # Goto  Masking tab 
>  # Select the "Service" dropdown to filter policies based on a specific 
> service.
>  # Select the "Zone" dropdown to filter policies based on  specific zone.
>  # Observe that the page resets to the default "Access" tab
> *Expected Behavior:*
> The page should retain the selected tab when filtering the service and zone 
> dropdown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74793: RANGER-4608:Need to add ACL evaluation for get datashare by ID API

2023-12-14 Thread Prashant Satam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74793/
---

Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan 
Neethiraj, Monika Kachhadiya, Subhrat Chaudhary, and Vanita Ubale.


Bugs: RANGER-4608
https://issues.apache.org/jira/browse/RANGER-4608


Repository: ranger


Description
---

For GET API for datashare by ID need to add ACL evaluation


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java af70daa9d 


Diff: https://reviews.apache.org/r/74793/diff/1/


Testing
---

Steps to Test
1)create a datashare 
2)Get the datashare by a user(this user should not be in ACL of datashare)using 
GET API service/gds/datashare/{id} 
3)Will get Error as user has no permission on the datashare


Thanks,

Prashant Satam

[jira] [Updated] (RANGER-4608) Need to add ACL evaluation for get datashare by ID API

2023-12-14 Thread Prashant Satam (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4608:
---
Description: For GET API for datashare by ID need to add ACL evaluation   
(was: For GET API of datashare by ID need to add ACL evaluation )

> Need to add ACL evaluation for get datashare by ID API 
> ---
>
> Key: RANGER-4608
> URL: https://issues.apache.org/jira/browse/RANGER-4608
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Prashant Satam
>Priority: Major
>
> For GET API for datashare by ID need to add ACL evaluation 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4608) Need to add ACL evaluation for get datashare by ID API

2023-12-14 Thread Prashant Satam (Jira) 
Prashant Satam created RANGER-4608:
--

 Summary: Need to add ACL evaluation for get datashare by ID API 
 Key: RANGER-4608
 URL: https://issues.apache.org/jira/browse/RANGER-4608
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Prashant Satam


For GET API of datashare by ID need to add ACL evaluation 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)