Review Request 74807: RANGER-4629:We need ACL evaluation in GET API for shared-resource
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74807/ --- Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita Ubale. Bugs: RANGER-4629 https://issues.apache.org/jira/browse/RANGER-4629 Repository: ranger Description --- Currently there is no validation for GET API of shared-resource we need to add ACL evaluation (i.e respective dataShares ACL evaluation) for the GET API of shared resource Diffs - security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java e38d0d15c Diff: https://reviews.apache.org/r/74807/diff/1/ Testing --- Steps to check 1)We have enforced respective dataShare ACL for GET API of shared-resource Thanks, Prashant Satam
Review Request 74806: RANGER-4628: Need to add Validations for Security-Zone partial update API
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74806/
---
Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan
Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita
Ubale.
Bugs: RANGER-4628
https://issues.apache.org/jira/browse/RANGER-4628
Repository: ranger
Description
---
For Partial Update of Security-Zone API ===>
/service/public/v2/api/zones-v2/{id}/partial
1)We can add existing admins/auditors to the zone and still get 200 as response
2)We can add existing tagServices to the zone and still get 200 as response
3)While removing the existing resources in zone if we pass invalid serviceName
we still get 200 as response though the zone is not getting updated
Diffs
-
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java
72ec4a4c7
Diff: https://reviews.apache.org/r/74806/diff/1/
Testing
---
steps to check :
1)We get validation when adding existing admins/auditors to the zone
2)We get validation when adding existing tagServices to the zone
3)We get validation when pass invalid serviceName for removing existing
resources from zone
Thanks,
Prashant Satam
[jira] [Updated] (RANGER-4629) We need ACL evaluation in GET API for shared-resource
[ https://issues.apache.org/jira/browse/RANGER-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashant Satam updated RANGER-4629: --- Description: Currently there is no validation for GET API of shared-resource we need to add ACL evaluation (i.e respective dataShares ACL evaluation) for the GET API of shared resource > We need ACL evaluation in GET API for shared-resource > - > > Key: RANGER-4629 > URL: https://issues.apache.org/jira/browse/RANGER-4629 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Prashant Satam >Priority: Major > > Currently there is no validation for GET API of shared-resource we need to > add ACL evaluation (i.e respective dataShares ACL evaluation) for the GET API > of shared resource -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RANGER-4629) We need ACL evaluation in GET API for shared-resource
[ https://issues.apache.org/jira/browse/RANGER-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashant Satam reassigned RANGER-4629: -- Assignee: Prashant Satam > We need ACL evaluation in GET API for shared-resource > - > > Key: RANGER-4629 > URL: https://issues.apache.org/jira/browse/RANGER-4629 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Prashant Satam >Assignee: Prashant Satam >Priority: Major > > Currently there is no validation for GET API of shared-resource we need to > add ACL evaluation (i.e respective dataShares ACL evaluation) for the GET API > of shared resource -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (RANGER-4629) We need ACL evaluation in GET API for shared-resource
Prashant Satam created RANGER-4629: -- Summary: We need ACL evaluation in GET API for shared-resource Key: RANGER-4629 URL: https://issues.apache.org/jira/browse/RANGER-4629 Project: Ranger Issue Type: Bug Components: Ranger Reporter: Prashant Satam -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4628) Need to add Validations for Security-Zone partial update API
[
https://issues.apache.org/jira/browse/RANGER-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prashant Satam updated RANGER-4628:
---
Description:
For Partial Update of Security-Zone API ===>
/service/public/v2/api/zones-v2/\{id}/partial
1)We can add existing admins/auditors to the zone and still get 200 as response
2)We can add existing tagServices to the zone and still get 200 as response
3)While removing the existing resources in zone if we pass invalid serviceName
we still get 200 as response though the zone is not getting updated
> Need to add Validations for Security-Zone partial update API
>
>
> Key: RANGER-4628
> URL: https://issues.apache.org/jira/browse/RANGER-4628
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> For Partial Update of Security-Zone API ===>
> /service/public/v2/api/zones-v2/\{id}/partial
> 1)We can add existing admins/auditors to the zone and still get 200 as
> response
> 2)We can add existing tagServices to the zone and still get 200 as response
> 3)While removing the existing resources in zone if we pass invalid
> serviceName we still get 200 as response though the zone is not getting
> updated
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (RANGER-4628) Need to add Validations for Security-Zone partial update API
[ https://issues.apache.org/jira/browse/RANGER-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashant Satam reassigned RANGER-4628: -- Assignee: Prashant Satam > Need to add Validations for Security-Zone partial update API > > > Key: RANGER-4628 > URL: https://issues.apache.org/jira/browse/RANGER-4628 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Prashant Satam >Assignee: Prashant Satam >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (RANGER-4628) Need to add Validations for Security-Zone partial update API
Prashant Satam created RANGER-4628: -- Summary: Need to add Validations for Security-Zone partial update API Key: RANGER-4628 URL: https://issues.apache.org/jira/browse/RANGER-4628 Project: Ranger Issue Type: Bug Components: Ranger Reporter: Prashant Satam -- This message was sent by Atlassian Jira (v8.20.10#820010)
