[jira] [Assigned] (RANGER-4614) GDS : Need new apis to get audit history of dataset/datashare

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam reassigned RANGER-4614:
--

Assignee: Prashant Satam

> GDS : Need new apis to get audit history of dataset/datashare
> -
>
> Key: RANGER-4614
> URL: https://issues.apache.org/jira/browse/RANGER-4614
> Project: Ranger
>  Issue Type: Task
>  Components: admin
>Reporter: Anand Nadar
>Assignee: Prashant Satam
>Priority: Major
>
> Need api to get the audit log of a particular dataset/datashare.
> Dataset history should contain
>  1. Changes on dataset object
>  2. Change on dataset policy
>  3. Changes on DatashareInDataset object. 
> Datashare history should contain
>  1. Changes on Datashare object.
>  2. Changes on its SharedResources.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74841: RANGER-4662 : GdsVersion should update after deleting user, group

[Prashant Satam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74841/
---

Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan 
Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita 
Ubale.


Bugs: RANGER-4662
https://issues.apache.org/jira/browse/RANGER-4662


Repository: ranger


Description
---

Currently when we delete user,group which is referenced in gds policy then 
GdsVersion (can check by GET API /service/gds/download/{serviceName})is not 
updated after the action it needs to be updated.

Steps :

1)create a user and resource service 

2)create a dataset , and dataShare (with the resource service),and a 
sharedResource (with dataShare),also create mapping of dataset with dataShare 
as ACTIVE

3)create a GDS policy for the dataset

4)Update dataset policy and add created user to it for this actions the 
GdsVersion is updated we can check by (GET API 
/service/gds/download/{serviceName})

5)but when we delete the created user which is in Gds dataset policy then the 
GdsVersion is not updated we need to update it


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 287400259 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 
ce48c8279 


Diff: https://reviews.apache.org/r/74841/diff/1/


Testing
---

Steps to check :
1)create a user and resource service 

2)create a dataset , and dataShare (with the resource service),and a 
sharedResource (with dataShare),also create mapping of dataset with dataShare 
as ACTIVE

3)create a GDS policy for the dataset

4)Update dataset policy and add created user to it 

5)when we delete the created user then the GdsVersion is updated


Thanks,

Prashant Satam

[jira] [Updated] (RANGER-4662) GdsVersion should update after deleting user,group

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4662:
---
Description: 
Currently when we delete user,group which is referenced in gds policy then 
GdsVersion ()is not updated after the action it needs to be updated.

Steps :

1)create a user and resource service 

2)create a dataset , and dataShare (with the resource service),and a 
sharedResource (with dataShare),also create mapping of dataset with dataShare 
as ACTIVE

3)create a GDS policy for the dataset

4)Update dataset policy and add created user to it for this actions the 
GdsVersion is updated we can check by (GET API 
/service/gds/download/\{serviceName})

5)but when we delete the created user then the GdsVersion is not updated  we 
need to update it 

 

  was:
Currently when we delete user,group which is referenced in gds policy then 
GdsVersion ()is not updated after the action it needs to be updated.

Steps :

1)create a user and resource service 

2)create a dataset , and dataShare (with the resource service),and a 
sharedResource (with dataShare),also create mapping of dataset with dataShare 
as ACTIVE

3)create a GDS policy for the dataset

4)Update dataset policy and add created user to it for this actions the 
GdsVersion is updated we can check by (GET API 
/service/gds/download/\{serviceName})

5)but when we delete the created user then the GdsVersion is not updated

 


> GdsVersion should update after deleting user,group 
> ---
>
> Key: RANGER-4662
> URL: https://issues.apache.org/jira/browse/RANGER-4662
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> Currently when we delete user,group which is referenced in gds policy then 
> GdsVersion ()is not updated after the action it needs to be updated.
> Steps :
> 1)create a user and resource service 
> 2)create a dataset , and dataShare (with the resource service),and a 
> sharedResource (with dataShare),also create mapping of dataset with dataShare 
> as ACTIVE
> 3)create a GDS policy for the dataset
> 4)Update dataset policy and add created user to it for this actions the 
> GdsVersion is updated we can check by (GET API 
> /service/gds/download/\{serviceName})
> 5)but when we delete the created user then the GdsVersion is not updated  we 
> need to update it 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74842: RANGER-4651 : Need to update Gds objects ACL if ranger principal is deleted

[Prashant Satam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74842/
---

Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan 
Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita 
Ubale.


Bugs: RANGER-4651
https://issues.apache.org/jira/browse/RANGER-4651


Repository: ranger


Description
---

Currently if any principal i.e user/group/role stored in ranger is deleted the 
GdsObject ACLs still have this principals they dont  get removed from the ACL 
we need to remove this principals from gdsObject ACLs


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java a69647948 
  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java abf2b0c8c 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java d961bc50c 
  security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareDao.java 
8acca8f89 
  security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java 
5743ad702 
  security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectDao.java 
76bab8611 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 52ecf8a3e 


Diff: https://reviews.apache.org/r/74842/diff/1/


Testing
---

Steps to check 
1)create a user/group/role in ranger 
2)create a dataset and add the above created user/group/role in dataset ACL 
3)Delete the user/group/role from ranger 
4)The user/group/role will also be removed from ACL of the dataset as well


Thanks,

Prashant Satam

Re: [PR] RANGER-4640: Trino ranger plugin for 433 snapshot [ranger]

[via GitHub]

mneethiraj commented on PR #291:
URL: https://github.com/apache/ranger/pull/291#issuecomment-1896670319

   @shreyas-dview  - this PR includes binary file 
ranger-3.0.0-SNAPSHOT-trino-plugin.tar.gz. Can you please remove this file and 
update the PR?
   
   Would 17 be the minimum JDK version after this patch? Given many existing 
plugins require JDK8 support, it is critical to be able to build with earlier 
version JDK as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (RANGER-4657) Ozone resource lookup is not working due to "Service ID specified does not match with ozone.om.service.ids defined in the configuration."

[Fateh Singh (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fateh Singh resolved RANGER-4657.
-
Resolution: Fixed

Issue has been fixed: 
[https://github.com/apache/ranger/pull/297/commits/0a17fa59546121eabb457b5c2b603d17cb36439d]

[https://github.com/apache/ranger/pull/297/commits]

> Ozone resource lookup is not working due to "Service ID specified does not 
> match with ozone.om.service.ids defined in the configuration."
> -
>
> Key: RANGER-4657
> URL: https://issues.apache.org/jira/browse/RANGER-4657
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fateh Singh
>Assignee: Fateh Singh
>Priority: Major
>
> Ozone service id in ranger is [hard-coded to be 
> "ozone1"|https://github.infra.cloudera.com/CDH/ranger/blob/b90853027212628f3fd63c73aa8b017456a8cf8e/plugin-ozone/src/main/java/org/apache/ranger/services/ozone/client/OzoneClient.java#L57].
>  Because of that, if a different value is used for ozone.service.id in Ozone 
> configs, resource lookup won't work in Ranger.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] RANGER-4675: Using the ozone service id specified in the config instead of hardcoded value for resource lookup [ranger]

[via GitHub]

kumaab merged PR #297:
URL: https://github.com/apache/ranger/pull/297


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Review Request 74840: RANGER-4660: While creating service, ranger logs show error if service name does not have underscore ('_') in it.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74840/#review226141
---




security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
Line 4408 (original), 4408 (patched)


To avoid creation of one tag service per resource service, I suggest to use 
linkedServiceType as the tag service name. Consider replacing #4408 with the 
following:

 ret = (lastIndexOfSep != -1) ? resourceServiceName.substring(0, 
lastIndexOfSep) + SEP + linkedServiceType : linkedServiceType;


- Madhan Neethiraj


On Jan. 17, 2024, 11:27 a.m., Siddhesh Phatak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74840/
> ---
> 
> (Updated Jan. 17, 2024, 11:27 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, 
> Monika Kachhadiya, Prashant Satam, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4660
> https://issues.apache.org/jira/browse/RANGER-4660
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When we create a service, a linked tag service also gets created for the 
> same. While doing so, ranger generates a name for the tag service based on 
> the service name. In this, ranger replaces word after the last underscore 
> with 'tag'. If the name does not contain any underscore, it returns null. Due 
> to this, ranger tries to create a tag service with name null. This causes 
> errors and service creation takes lot of time because of this.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> f9fd4941e 
> 
> 
> Diff: https://reviews.apache.org/r/74840/diff/1/
> 
> 
> Testing
> ---
> 
> After the changes, created service mytestknox and a tag service 
> mytestknox_tag also got created successfully.
> Steps to check
> 1) On ranger UI, click on add new service.
> 2) Service should get created successfully.
> 3) Click on tag tab. A tag service associated with our created service will 
> be also creted.
> 
> 
> Thanks,
> 
> Siddhesh Phatak
> 
>

[jira] [Assigned] (RANGER-4662) GdsVersion should update after deleting user,group

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam reassigned RANGER-4662:
--

Assignee: Prashant Satam

> GdsVersion should update after deleting user,group 
> ---
>
> Key: RANGER-4662
> URL: https://issues.apache.org/jira/browse/RANGER-4662
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> Currently when we delete user,group which is referenced in gds policy then 
> GdsVersion ()is not updated after the action it needs to be updated.
> Steps :
> 1)create a user and resource service 
> 2)create a dataset , and dataShare (with the resource service),and a 
> sharedResource (with dataShare),also create mapping of dataset with dataShare 
> as ACTIVE
> 3)create a GDS policy for the dataset
> 4)Update dataset policy and add created user to it for this actions the 
> GdsVersion is updated we can check by (GET API 
> /service/gds/download/\{serviceName})
> 5)but when we delete the created user then the GdsVersion is not updated
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4662) GdsVersion should update after deleting user,group

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam updated RANGER-4662:
---
Description: 
Currently when we delete user,group which is referenced in gds policy then 
GdsVersion ()is not updated after the action it needs to be updated.

Steps :

1)create a user and resource service 

2)create a dataset , and dataShare (with the resource service),and a 
sharedResource (with dataShare),also create mapping of dataset with dataShare 
as ACTIVE

3)create a GDS policy for the dataset

4)Update dataset policy and add created user to it for this actions the 
GdsVersion is updated we can check by (GET API 
/service/gds/download/\{serviceName})

5)but when we delete the created user then the GdsVersion is not updated

 

> GdsVersion should update after deleting user,group 
> ---
>
> Key: RANGER-4662
> URL: https://issues.apache.org/jira/browse/RANGER-4662
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Prashant Satam
>Priority: Major
>
> Currently when we delete user,group which is referenced in gds policy then 
> GdsVersion ()is not updated after the action it needs to be updated.
> Steps :
> 1)create a user and resource service 
> 2)create a dataset , and dataShare (with the resource service),and a 
> sharedResource (with dataShare),also create mapping of dataset with dataShare 
> as ACTIVE
> 3)create a GDS policy for the dataset
> 4)Update dataset policy and add created user to it for this actions the 
> GdsVersion is updated we can check by (GET API 
> /service/gds/download/\{serviceName})
> 5)but when we delete the created user then the GdsVersion is not updated
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4662) GdsVersion should update after deleting user,group

[Prashant Satam (Jira)]

Prashant Satam created RANGER-4662:
--

 Summary: GdsVersion should update after deleting user,group 
 Key: RANGER-4662
 URL: https://issues.apache.org/jira/browse/RANGER-4662
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Prashant Satam






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4661) Multiple audits should be generated when access is granted by multiple policies.

[Dineshkumar Yadav (Jira)]

Dineshkumar Yadav created RANGER-4661:
-

 Summary: Multiple audits should be generated when access is 
granted by multiple policies.
 Key: RANGER-4661
 URL: https://issues.apache.org/jira/browse/RANGER-4661
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Dineshkumar Yadav
Assignee: Dineshkumar Yadav


Currently single audit is getting generated when access (multiple access in 
single request) is granted by multiple policies.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74840: RANGER-4660: While creating service, ranger logs show error if service name does not have underscore ('_') in it.

[Siddhesh Phatak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74840/
---

Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika 
Kachhadiya, Prashant Satam, and Subhrat Chaudhary.


Bugs: RANGER-4660
https://issues.apache.org/jira/browse/RANGER-4660


Repository: ranger


Description
---

When we create a service, a linked tag service also gets created for the same. 
While doing so, ranger generates a name for the tag service based on the 
service name. In this, ranger replaces word after the last underscore with 
'tag'. If the name does not contain any underscore, it returns null. Due to 
this, ranger tries to create a tag service with name null. This causes errors 
and service creation takes lot of time because of this.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
f9fd4941e 


Diff: https://reviews.apache.org/r/74840/diff/1/


Testing
---

After the changes, created service mytestknox and a tag service mytestknox_tag 
also got created successfully.
Steps to check
1) On ranger UI, click on add new service.
2) Service should get created successfully.
3) Click on tag tab. A tag service associated with our created service will be 
also creted.


Thanks,

Siddhesh Phatak

[jira] [Created] (RANGER-4660) While creating service, ranger logs show error if service name does not have underscore ('_') in it.

[Siddhesh Phatak (Jira)]

Siddhesh Phatak created RANGER-4660:
---

 Summary: While creating service, ranger logs show error if service 
name does not have underscore ('_') in it.
 Key: RANGER-4660
 URL: https://issues.apache.org/jira/browse/RANGER-4660
 Project: Ranger
  Issue Type: Bug
  Components: admin, Ranger
Reporter: Siddhesh Phatak
Assignee: Siddhesh Phatak


When we create a service, a linked tag service also gets created for the same. 
While doing so, ranger generates a name for the tag service based on the 
service name. In this, ranger replaces word after the last underscore with 
'tag'. If the name does not contain any underscore, it returns null. Due to 
this, ranger tries to create a tag service with name null. This causes errors 
and service creation takes lot of time because of this.

Following errors are seen in logs

ranger logs
2024-01-17 09:47:26,894 [http-nio-6080-exec-5] INFO [ServiceREST.java:4365] 
Successfully retrieved resource-service:[myhbase]
2024-01-17 09:47:27,862 [http-nio-6080-exec-5] INFO [ServiceREST.java:4381] 
creating service [null]
2024-01-17 09:47:33,440 [http-nio-6080-exec-5] INFO [ServiceREST.java:4365] 
Successfully retrieved resource-service:[myhbase]
2024-01-17 09:47:33,440 [http-nio-6080-exec-5] INFO [ServiceREST.java:4381] 
creating service [null]
2024-01-17 09:47:40,524 [http-nio-6080-exec-5] INFO [ServiceREST.java:4365] 
Successfully retrieved resource-service:[myhbase]
2024-01-17 09:47:40,525 [http-nio-6080-exec-5] INFO [ServiceREST.java:4381] 
creating service [null]

catalina log
[EL Warning]: 2024-01-17 09:45:15.324--ClientSession(1172639212)--Exception 
[EclipseLink-4002] (Eclipse Persistence Services - 
2.7.12.v20230209-e5c4074ef3): 
org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: java.sql.SQLIntegrityConstraintViolationException: Column 
'obj_name' cannot be null
Error Code: 1048
Call: INSERT INTO x_data_hist (action, content, CREATE_TIME, from_time, 
obj_class_type, obj_guid, obj_id, obj_name, to_time, UPDATE_TIME, version) 
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
bind => [11 parameters bound]
Query: ValueReadQuery(name="x_data_hist_SEQ" sql="SELECT LAST_INSERT_ID()")





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74825: RANGER-4638:Multiple Columns Revoke not generating policies with correct number of columns

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74825/
---

(Updated Jan. 17, 2024, 8:32 a.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Changes
---

Fixed review comments


Bugs: RANGER-4638
https://issues.apache.org/jira/browse/RANGER-4638


Repository: ranger


Description
---

RANGER-4638:Multiple Columns Revoke not generating policies with correct number 
of columns


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
 7fe2a2eb3 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
 0a14b387a 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
 f16157ce6 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceMatcher.java
 e1cd89b70 
  
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
 5eee8d11a 
  
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerResourceMatcher.java
 ec22e01bf 
  
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceisCompleteOrSomeMatchMatcher.java
 PRE-CREATION 
  
agents-common/src/test/resources/resourcematcher/test_defaultpolicyresource_isCompleteOrSomeMatch_matcher.json
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdmin.java 
15a1e7118 
  security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java 
84ee31ba2 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
cc9df27d6 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java 
60e34c0c7 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
a630e575b 


Diff: https://reviews.apache.org/r/74825/diff/2/

Changes: https://reviews.apache.org/r/74825/diff/1-2/


Testing (updated)
---

Impala / Hive beeline.

1) "grant select(col1, col2, col3)  on table demo.test  to role Role1"  => 
Create a Grant Policy for the given resource in Hadoop Sql
   

2) "grant select(col1, col2, col3, col4)  on table demo.test  to role Role1"  
=> updates the policy created in #1 with new col4 resource

 if  "revoke select(col1, col2, col3, col4) on table demo.test from role 
Role1" is done => Since all the columns are revoked for Select, we update the 
policy created in #1 with no policy Item for it.
 if  "revoke select(col1, col2, col3) on table demo.test from role Role1" 
is done => policy created in #1 will be updated to remove col1,col2,col3 from 
the policy to revoke the access.
 
3) If "revoke select(col1, col2, col3, col4) on table demo.test from role 
Role1" found 2 Matching polcies,  say 1st policy matched col1,col2,col3 and  
2nd Policy matched col4, then both the policies will be updated for revoking 
the corresponding column access.

4) When Multiple Premission are there on the policy and revoke is to remove one 
permission, then the policy will be updated by removing the revoked permission.
 Grant select on table demo.test  to role Role1
 Grant Alter on table demo.test  to role Role1
 Revoke alter table demo.test  to role Role1

 

HBASE shell

grant 'nifi', 'RWXCA', 'test'  => create policy with 'RWXCA' access for user 
nifi on table 'test'.


revoke 'nifi', 'test' => revoke access for user "nifi" on hbase table 'test'. 
Here policy will be removed.


Thanks,

Ramesh Mani