Re: Review Request 74831: RANGER-4641: Handling empty values while displaying ActivationTime & implementing Column Hide/Show functionality in Audit Plugin Status Module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74831/ --- (Updated Feb. 6, 2024, 7:19 a.m.) Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. Bugs: RANGER-4641 https://issues.apache.org/jira/browse/RANGER-4641 Repository: ranger Description --- Handling empty values while displaying ActivationTime & implementing Column Hide/Show functionality in Audit Plugin Status Module. 1)The empty values should be handle while displaying the Activation Time in Plugin Status table, when server sets the default value of ActivationTime to "0". 2)The Column Hide/Show Functionality should be added in Plugin Status Table. Diffs - security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx 1fca37866 security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx 71a33f1c7 security-admin/src/main/webapp/react-webapp/src/styles/style.css ed45e8636 security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js 842cb690e security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js d22ecfa7c security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js f834f9795 security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx 07ac391d9 security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx 53e50791b Diff: https://reviews.apache.org/r/74831/diff/2/ Testing (updated) --- Applied the patch on a cluster and tested the following UI scenarios :- 1)Tested column show/hide functionality for Plugin Status table. Thanks, Brijesh Bhalala
Re: [PR] RANGER-4640: Trino ranger plugin for 433 snapshot [ranger]
nil1729 commented on PR #291: URL: https://github.com/apache/ranger/pull/291#issuecomment-1928029729 Hi @tarekabouzeid, I built the ranger locally with the JDK version `openjdk-17.0.8` and maven version `3.6.3`. There was some error when building on MAC due to the `shadow.h` header file not being found. Then I have used those jars to build Dockerfile and tested `trino` with docker only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Review Request 74861: RANGER-4688 Display query information for show roles/databases/schemas/grant role commands on Ranger Admin UI
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74861/
---
Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj,
Mehul Parikh, Mugdha Varadkar, and Ramesh Mani.
Bugs: RANGER-4688
https://issues.apache.org/jira/browse/RANGER-4688
Repository: ranger
Description
---
Query information is present for 'show tables' command execution and not for
'show databases' or 'show schemas' command
Query information should be present for 'show databases' and 'show schemas'
commands.
Similarly, query information is missing for commands like show roles, grant
role commands.
Diffs
-
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx
8e12ec654
Diff: https://reviews.apache.org/r/74861/diff/1/
Testing
---
Applied the patch on a cluster, and tested the following scenarios :-
1. Ensured that the query information is displayed for show roles command
2. Ensured that the query information is displayed for show databases command
3. Ensured that the query information is displayed for "grant role to user
{username};" command
4. Ensured that the query information is displayed for "show schemas;" command
Thanks,
Abhishek Patil
[jira] [Updated] (RANGER-4688) Display query information for show roles/databases/schemas/grant role commands on Ranger Admin UI
[ https://issues.apache.org/jira/browse/RANGER-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek updated RANGER-4688: - Labels: ranger-react (was: ) > Display query information for show roles/databases/schemas/grant role > commands on Ranger Admin UI > - > > Key: RANGER-4688 > URL: https://issues.apache.org/jira/browse/RANGER-4688 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Abhishek >Priority: Minor > Labels: ranger-react > > STEPS TO REPRODUCE: > Connect to hive beeline > Execute command 'show databases' > Execute command 'show schemas' > Execute command 'show tables' > CURRENT BEHAVIOUR: > Query information is present for 'show tables' command execution and not for > 'show databases' or 'show schemas' command > EXPECTED BEHAVIOUR: > Query information should be present for 'show databases' and 'show schemas' > commands. > Similarly, query information is missing for commands like show roles, grant > role commands. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4688) Display query information for show roles/databases/schemas/grant role commands on Ranger Admin UI
[ https://issues.apache.org/jira/browse/RANGER-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek updated RANGER-4688: - Description: STEPS TO REPRODUCE: Connect to hive beeline Execute command 'show databases' Execute command 'show schemas' Execute command 'show tables' CURRENT BEHAVIOUR: Query information is present for 'show tables' command execution and not for 'show databases' or 'show schemas' command EXPECTED BEHAVIOUR: Query information should be present for 'show databases' and 'show schemas' commands. Similarly, query information is missing for commands like show roles, grant role commands. was: STEPS TO REPRODUCE: Connect to hive beeline Execute command 'show databases' Execute command 'show schemas' Execute command 'show tables' CURRENT BEHAVIOUR: Query information is present for 'show tables' command execution and not for 'show databases' or 'show schemas' command EXPECTED BEHAVIOUR: Query information should be present for 'show databases' and 'show schemas' commands > Display query information for show roles/databases/schemas/grant role > commands on Ranger Admin UI > - > > Key: RANGER-4688 > URL: https://issues.apache.org/jira/browse/RANGER-4688 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Abhishek >Priority: Minor > > STEPS TO REPRODUCE: > Connect to hive beeline > Execute command 'show databases' > Execute command 'show schemas' > Execute command 'show tables' > CURRENT BEHAVIOUR: > Query information is present for 'show tables' command execution and not for > 'show databases' or 'show schemas' command > EXPECTED BEHAVIOUR: > Query information should be present for 'show databases' and 'show schemas' > commands. > Similarly, query information is missing for commands like show roles, grant > role commands. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RANGER-4688) Display query information for show roles/databases/schemas/grant role commands on Ranger Admin UI
[ https://issues.apache.org/jira/browse/RANGER-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek updated RANGER-4688: - Summary: Display query information for show roles/databases/schemas/grant role commands on Ranger Admin UI (was: Display query information for Show databases/schemas command on Ranger Admin UI) > Display query information for show roles/databases/schemas/grant role > commands on Ranger Admin UI > - > > Key: RANGER-4688 > URL: https://issues.apache.org/jira/browse/RANGER-4688 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Abhishek >Priority: Minor > > STEPS TO REPRODUCE: > Connect to hive beeline > Execute command 'show databases' > Execute command 'show schemas' > Execute command 'show tables' > CURRENT BEHAVIOUR: > Query information is present for 'show tables' command execution and not for > 'show databases' or 'show schemas' command > EXPECTED BEHAVIOUR: > Query information should be present for 'show databases' and 'show schemas' > commands -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (RANGER-4689) Fix Ranger Javapatch failure even if service-defs do not exist in ranger DB
Pradeep Agrawal created RANGER-4689: --- Summary: Fix Ranger Javapatch failure even if service-defs do not exist in ranger DB Key: RANGER-4689 URL: https://issues.apache.org/jira/browse/RANGER-4689 Project: Ranger Issue Type: Bug Components: Ranger Affects Versions: 3.0.0 Reporter: Pradeep Agrawal Assignee: Pradeep Agrawal -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RANGER-4688) Display query information for Show databases/schemas command on Ranger Admin UI
[ https://issues.apache.org/jira/browse/RANGER-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek reassigned RANGER-4688: Assignee: Abhishek > Display query information for Show databases/schemas command on Ranger Admin > UI > --- > > Key: RANGER-4688 > URL: https://issues.apache.org/jira/browse/RANGER-4688 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: suja s >Assignee: Abhishek >Priority: Minor > > STEPS TO REPRODUCE: > Connect to hive beeline > Execute command 'show databases' > Execute command 'show schemas' > Execute command 'show tables' > CURRENT BEHAVIOUR: > Query information is present for 'show tables' command execution and not for > 'show databases' or 'show schemas' command > EXPECTED BEHAVIOUR: > Query information should be present for 'show databases' and 'show schemas' > commands -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (RANGER-4688) Display query information for Show databases/schemas command on Ranger Admin UI
suja s created RANGER-4688: -- Summary: Display query information for Show databases/schemas command on Ranger Admin UI Key: RANGER-4688 URL: https://issues.apache.org/jira/browse/RANGER-4688 Project: Ranger Issue Type: Bug Components: Ranger Reporter: suja s STEPS TO REPRODUCE: Connect to hive beeline Execute command 'show databases' Execute command 'show schemas' Execute command 'show tables' CURRENT BEHAVIOUR: Query information is present for 'show tables' command execution and not for 'show databases' or 'show schemas' command EXPECTED BEHAVIOUR: Query information should be present for 'show databases' and 'show schemas' commands -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RANGER-4668) Need to have new local storage item for column show hide functionality in plugin status table
[ https://issues.apache.org/jira/browse/RANGER-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814298#comment-17814298 ] Brijesh Bhalala commented on RANGER-4668: - commited to [Apache master|https://github.com/apache/ranger/commit/834c211c6d95b6c20399d21535dda5010740383e] branch > Need to have new local storage item for column show hide functionality in > plugin status table > -- > > Key: RANGER-4668 > URL: https://issues.apache.org/jira/browse/RANGER-4668 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Brijesh Bhalala >Assignee: Brijesh Bhalala >Priority: Major > Labels: ranger-react > Fix For: 3.0.0 > > Attachments: 0001-RANGER-4668.patch, 0002-RANGER-4668.patch > > > Need to have new local storage item for column show hide functionality in > plugin status table. > *Current Behaviour :-* > * The same local storage item is been used in both Access & Plugin Status > table for column show hide functionality , this causes regression in Access > Table column. > So need to make a new local storage item for column show hide functionality > in plugin status table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RANGER-4668) Need to have new local storage item for column show hide functionality in plugin status table
[ https://issues.apache.org/jira/browse/RANGER-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814295#comment-17814295 ] Dhaval Shah commented on RANGER-4668: - Committed in apache master branch https://github.com/apache/ranger/commit/834c211c6d95b6c20399d21535dda5010740383e > Need to have new local storage item for column show hide functionality in > plugin status table > -- > > Key: RANGER-4668 > URL: https://issues.apache.org/jira/browse/RANGER-4668 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Brijesh Bhalala >Assignee: Brijesh Bhalala >Priority: Major > Labels: ranger-react > Fix For: 3.0.0 > > Attachments: 0001-RANGER-4668.patch, 0002-RANGER-4668.patch > > > Need to have new local storage item for column show hide functionality in > plugin status table. > *Current Behaviour :-* > * The same local storage item is been used in both Access & Plugin Status > table for column show hide functionality , this causes regression in Access > Table column. > So need to make a new local storage item for column show hide functionality > in plugin status table. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74853: RANGER-4668: Need to have new local storage item for column show hide functionality in plugin status table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74853/#review226201 --- Ship it! Ship It! - Dhaval Shah On Feb. 5, 2024, 6:37 a.m., Brijesh Bhalala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74853/ > --- > > (Updated Feb. 5, 2024, 6:37 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dhaval Shah, Dineshkumar Yadav, > Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin > Galave. > > > Bugs: RANGER-4668 > https://issues.apache.org/jira/browse/RANGER-4668 > > > Repository: ranger > > > Description > --- > > Need to have new local storage item for column show hide functionality in > plugin status table. > > Current Behaviour :- > > The same local storage item is been used in both Access & Plugin Status > table for column show hide functionality , this causes regression in Access > Table column. > > So need to make a new local storage item for column show hide functionality > in plugin status table. > > > Diffs > - > > > security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx > d75315e04 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx > 310685348 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx > 32db07208 > > > Diff: https://reviews.apache.org/r/74853/diff/2/ > > > Testing > --- > > Applied the patch on a cluster and tested the following UI scenarios :- > 1)Access & Policy Listing page column show/hide functionality. > 2)Tested the localstorage for column show/hide functionality. > > > Thanks, > > Brijesh Bhalala > >
[jira] [Updated] (RANGER-4687) Updating the "Something went wrong" page in Ranger React UI
[ https://issues.apache.org/jira/browse/RANGER-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brijesh Bhalala updated RANGER-4687: Description: Updating the "Something went wrong" page in Ranger React UI *Current behaviour:-* * If there's an error or code break in Ranger react file, the "Something went wrong" page appears. * The error details, including stack traces, are only shown in UI, this makes the RANGER UI not available. The error details, shouldn't be display in UI, instead of it add the buttons for reloading and go to profile page. was: Updating the "Something went wrong" page in Ranger React UI *Current behaviour:-* * If their's an error or code break in Ranger react file, the "Something went wrong" page appears. * The error details, including stack traces, are only shown in UI, this makes the RANGER UI not available. The error details, shouldn't be display in UI, instead of it add the buttons for reloading and go to profile page. > Updating the "Something went wrong" page in Ranger React UI > > > Key: RANGER-4687 > URL: https://issues.apache.org/jira/browse/RANGER-4687 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Brijesh Bhalala >Assignee: Brijesh Bhalala >Priority: Major > Labels: ranger-react > Fix For: 3.0.0 > > > Updating the "Something went wrong" page in Ranger React UI > *Current behaviour:-* > * If there's an error or code break in Ranger react file, the "Something > went wrong" page appears. > * The error details, including stack traces, are only shown in UI, this > makes the RANGER UI not available. > The error details, shouldn't be display in UI, instead of it add the buttons > for reloading and go to profile page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74853: RANGER-4668: Need to have new local storage item for column show hide functionality in plugin status table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74853/#review226200 --- Ship it! Ship It! - Mugdha Varadkar On Feb. 5, 2024, 6:37 a.m., Brijesh Bhalala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74853/ > --- > > (Updated Feb. 5, 2024, 6:37 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dhaval Shah, Dineshkumar Yadav, > Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin > Galave. > > > Bugs: RANGER-4668 > https://issues.apache.org/jira/browse/RANGER-4668 > > > Repository: ranger > > > Description > --- > > Need to have new local storage item for column show hide functionality in > plugin status table. > > Current Behaviour :- > > The same local storage item is been used in both Access & Plugin Status > table for column show hide functionality , this causes regression in Access > Table column. > > So need to make a new local storage item for column show hide functionality > in plugin status table. > > > Diffs > - > > > security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx > d75315e04 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx > 310685348 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx > 32db07208 > > > Diff: https://reviews.apache.org/r/74853/diff/2/ > > > Testing > --- > > Applied the patch on a cluster and tested the following UI scenarios :- > 1)Access & Policy Listing page column show/hide functionality. > 2)Tested the localstorage for column show/hide functionality. > > > Thanks, > > Brijesh Bhalala > >
