Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

2024-03-09 Thread Ramesh Mani


> On March 9, 2024, 11:23 p.m., Ramesh Mani wrote:
> > Ship It!

Fix and Ship it.


- Ramesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226308
---


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

2024-03-09 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226308
---


Ship it!




Ship It!

- Ramesh Mani


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

2024-03-09 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226307
---




hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Lines 3159 (patched)


LOG.info() => Log.debug()


- Ramesh Mani


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



[PR] RANGER-4734: Trino Ranger Integration in Docker [ranger]

2024-03-09 Thread via GitHub


kumaab opened a new pull request, #299:
URL: https://github.com/apache/ranger/pull/299

   ## What changes were proposed in this pull request?
   
   Introduces Docker Image for Trino in Ranger
   
   ## How was this patch tested?
   - Bring up the containers
 - Build with JDK 11: `mvn clean package -DskipTests -P ranger-jdk11 -pl 
'!unixauthnative'`
 - `cp target/ranger-admin.tar.gz dev-support/ranger-docker/dist`
 - `cp target/ranger-trino-plugin.tar.gz dev-support/ranger-docker/dist/`
 - `cd dev-support/ranger-docker`
 - `docker-compose -f docker-compose.ranger.yml -f 
docker-compose.ranger-postgres.yml -f docker-compose.ranger-trino.yml build`
 - `docker-compose -f docker-compose.ranger.yml -f 
docker-compose.ranger-postgres.yml up -d`
 - `docker-compose -f docker-compose.ranger.yml -f 
docker-compose.ranger-postgres.yml -f docker-compose.ranger-trino.yml up -d`
   
   - Audits to Solr visible in Ranger UI for Trino
   https://github.com/apache/ranger/assets/16475454/5a6fe81f-ed54-4a97-9579-c1e4371c45c1;>
   
   - Policies synced to Plugin
   https://github.com/apache/ranger/assets/16475454/8a2eba6a-a45c-406f-abf1-a230d76dd53d;>
   
   - Configuring Ranger Policies for Trino and accessing via Trino CLI

   https://github.com/apache/ranger/assets/16475454/602817b0-2324-4591-a7cc-93f4d8a59597;>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org