[jira] [Commented] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1672#comment-1672 ] Csaba Koncz commented on RANGER-2255: - RANGER-2321 was merged. However, it does not exactly act as outlined above: the default is to execute JavaScript tests (just like Java tests are run by default). -DskipJSTests is needed to skip JavaScript tests (including PhantomJS downloading) -DskipTests skips both Java and JS tests. > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Koncz resolved RANGER-2255. - Resolution: Fixed > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-2321) Docker build fails due to PhantomJS dependency
[
https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741310#comment-16741310
]
Csaba Koncz commented on RANGER-2321:
-
Created review: https://reviews.apache.org/r/69731/
> Docker build fails due to PhantomJS dependency
> --
>
> Key: RANGER-2321
> URL: https://issues.apache.org/jira/browse/RANGER-2321
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
> Attachments:
> 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch
>
>
> Docker build fails in an early phase do to the PhantomJS dependency
> introduced in RANGER-2255. E.g. running
> {code:java}
> ./build_ranger_using_docker.sh mvn clean verify -am -pl security-admin{code}
> results in
> {code:java}
> [INFO] < org.apache.ranger:security-admin-web
> >
> [INFO] Building Security Admin Web Application 2.0.0-SNAPSHOT [7/7]
> [INFO] [ war
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) @ security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:resources (default-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 22 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ security-admin-web ---
> [INFO] Executing tasks
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and
> npm) @ security-admin-web ---
> [INFO] Installing node version v8.12.0
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/node/8.12.0/node-8.12.0-linux-x64.tar.gz
> into /ranger/security-admin/target/node/tmp
> [INFO] Copying node binary from
> /ranger/security-admin/target/node/tmp/node-v8.12.0-linux-x64/bin/node to
> /ranger/security-admin/target/node/node
> [INFO] Installed node locally.
> [INFO] Installing npm version 6.4.1
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/npm/6.4.1/npm-6.4.1.tar.gz
> into /ranger/security-admin/target/node/node_modules
> [INFO] Installed npm locally.
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ security-admin-web
> ---
> [INFO] Running 'npm install' in /ranger/security-admin/target
> [INFO]
> [INFO] > phantomjs-prebuilt@2.1.16 install
> /ranger/security-admin/target/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
> [INFO] > node install.js
> [INFO]
> [INFO] PhantomJS not found on PATH
> [INFO] Downloading
> https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Receiving...
> [INFO]
> [INFO] Received 22866K total.
> [INFO] Extracting tar contents (via spawned process)
> [ERROR] Error extracting archive
> [ERROR] Phantom installation failed { Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
> [ERROR] at ChildProcess.exithandler (child_process.js:276:12)
> [ERROR] at emitTwo (events.js:126:13)
> [ERROR] at ChildProcess.emit (events.js:214:7)
> [ERROR] at maybeClose (internal/child_process.js:915:16)
> [ERROR] at Socket.stream.socket.on (internal/child_process.js:336:11)
> [ERROR] at emitOne (events.js:116:13)
> [ERROR] at Socket.emit (events.js:211:7)
> [ERROR] at Pipe._handle.close [as _onclose] (net.js:561:12)
> [ERROR] killed: false,
> [ERROR] code: 2,
> [ERROR] signal: null,
> [ERROR] cmd: 'tar jxf /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2' }
> Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
>
[jira] [Commented] (RANGER-2321) Docker build fails due to PhantomJS dependency
[
https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740238#comment-16740238
]
Csaba Koncz commented on RANGER-2321:
-
The attached patch builds on RANGER-2319, which has not been merged yet.
It implements two changes:
# build_ranger_using_docker.sh adds bzip2 and fontconfig to the image being
built, so the build succeeds with the new image.
# JavaScript test execution can be switched of by passing -DskipJSTests to
Maven. This can be used when building outside Docker
> Docker build fails due to PhantomJS dependency
> --
>
> Key: RANGER-2321
> URL: https://issues.apache.org/jira/browse/RANGER-2321
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
> Attachments:
> 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch
>
>
> Docker build fails in an early phase do to the PhantomJS dependency
> introduced in RANGER-2255. E.g. running
> {code:java}
> ./build_ranger_using_docker.sh mvn clean verify -am -pl security-admin{code}
> results in
> {code:java}
> [INFO] < org.apache.ranger:security-admin-web
> >
> [INFO] Building Security Admin Web Application 2.0.0-SNAPSHOT [7/7]
> [INFO] [ war
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) @ security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:resources (default-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 22 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ security-admin-web ---
> [INFO] Executing tasks
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and
> npm) @ security-admin-web ---
> [INFO] Installing node version v8.12.0
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/node/8.12.0/node-8.12.0-linux-x64.tar.gz
> into /ranger/security-admin/target/node/tmp
> [INFO] Copying node binary from
> /ranger/security-admin/target/node/tmp/node-v8.12.0-linux-x64/bin/node to
> /ranger/security-admin/target/node/node
> [INFO] Installed node locally.
> [INFO] Installing npm version 6.4.1
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/npm/6.4.1/npm-6.4.1.tar.gz
> into /ranger/security-admin/target/node/node_modules
> [INFO] Installed npm locally.
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ security-admin-web
> ---
> [INFO] Running 'npm install' in /ranger/security-admin/target
> [INFO]
> [INFO] > phantomjs-prebuilt@2.1.16 install
> /ranger/security-admin/target/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
> [INFO] > node install.js
> [INFO]
> [INFO] PhantomJS not found on PATH
> [INFO] Downloading
> https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Receiving...
> [INFO]
> [INFO] Received 22866K total.
> [INFO] Extracting tar contents (via spawned process)
> [ERROR] Error extracting archive
> [ERROR] Phantom installation failed { Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
> [ERROR] at ChildProcess.exithandler (child_process.js:276:12)
> [ERROR] at emitTwo (events.js:126:13)
> [ERROR] at ChildProcess.emit (events.js:214:7)
> [ERROR] at maybeClose (internal/child_process.js:915:16)
> [ERROR] at Socket.stream.socket.on (internal/child_process.js:336:11)
> [ERROR] at emitOne (events.js:116:13)
> [ERROR] at Socket.emit (events.js:211:7)
> [ERROR] at Pipe._handle.close [as _onclose] (net.js:561:12)
> [ERROR] killed: false,
> [ERROR] code: 2,
> [ERROR] signal: null,
> [ERROR] cmd: 'tar jxf /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2' }
> Error:
[jira] [Updated] (RANGER-2321) Docker build fails due to PhantomJS dependency
[
https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Csaba Koncz updated RANGER-2321:
Attachment: 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch
> Docker build fails due to PhantomJS dependency
> --
>
> Key: RANGER-2321
> URL: https://issues.apache.org/jira/browse/RANGER-2321
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
> Attachments:
> 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch
>
>
> Docker build fails in an early phase do to the PhantomJS dependency
> introduced in RANGER-2255. E.g. running
> {code:java}
> ./build_ranger_using_docker.sh mvn clean verify -am -pl security-admin{code}
> results in
> {code:java}
> [INFO] < org.apache.ranger:security-admin-web
> >
> [INFO] Building Security Admin Web Application 2.0.0-SNAPSHOT [7/7]
> [INFO] [ war
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) @ security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:resources (default-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 22 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ security-admin-web ---
> [INFO] Executing tasks
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and
> npm) @ security-admin-web ---
> [INFO] Installing node version v8.12.0
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/node/8.12.0/node-8.12.0-linux-x64.tar.gz
> into /ranger/security-admin/target/node/tmp
> [INFO] Copying node binary from
> /ranger/security-admin/target/node/tmp/node-v8.12.0-linux-x64/bin/node to
> /ranger/security-admin/target/node/node
> [INFO] Installed node locally.
> [INFO] Installing npm version 6.4.1
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/npm/6.4.1/npm-6.4.1.tar.gz
> into /ranger/security-admin/target/node/node_modules
> [INFO] Installed npm locally.
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ security-admin-web
> ---
> [INFO] Running 'npm install' in /ranger/security-admin/target
> [INFO]
> [INFO] > phantomjs-prebuilt@2.1.16 install
> /ranger/security-admin/target/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
> [INFO] > node install.js
> [INFO]
> [INFO] PhantomJS not found on PATH
> [INFO] Downloading
> https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Receiving...
> [INFO]
> [INFO] Received 22866K total.
> [INFO] Extracting tar contents (via spawned process)
> [ERROR] Error extracting archive
> [ERROR] Phantom installation failed { Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
> [ERROR] at ChildProcess.exithandler (child_process.js:276:12)
> [ERROR] at emitTwo (events.js:126:13)
> [ERROR] at ChildProcess.emit (events.js:214:7)
> [ERROR] at maybeClose (internal/child_process.js:915:16)
> [ERROR] at Socket.stream.socket.on (internal/child_process.js:336:11)
> [ERROR] at emitOne (events.js:116:13)
> [ERROR] at Socket.emit (events.js:211:7)
> [ERROR] at Pipe._handle.close [as _onclose] (net.js:561:12)
> [ERROR] killed: false,
> [ERROR] code: 2,
> [ERROR] signal: null,
> [ERROR] cmd: 'tar jxf /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2' }
> Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
> [ERROR] at
[jira] [Comment Edited] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739227#comment-16739227 ] Csaba Koncz edited comment on RANGER-2255 at 1/10/19 9:10 AM: -- Reverted the patch belonging to RANGER-2319 to its original version (which only removes the deprecated package). Created a separate issue for the build failure: RANGER-2321 was (Author: koncz): Reverted the patch belonging to RANGER-2319 to its original version (which only removes the deprecated package). Created a separated issue for the build failure: RANGER-2321 > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739227#comment-16739227 ] Csaba Koncz edited comment on RANGER-2255 at 1/10/19 9:09 AM: -- Reverted the patch belonging to RANGER-2319 to its original version (which only removes the deprecated package). Created a separated issue for the build failure: RANGER-2321 was (Author: koncz): Reverted the patch belonging to RANGER-2319 to its original version (which only removes the deprecated packege). Created a separated issue for the build failure: RANGER-2321 > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739227#comment-16739227 ] Csaba Koncz commented on RANGER-2255: - Reverted the patch belonging to RANGER-2319 to its original version (which only removes the deprecated packege). Created a separated issue for the build failure: RANGER-2321 > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2321) Docker build fails due to PhantomJS dependency
Csaba Koncz created RANGER-2321:
---
Summary: Docker build fails due to PhantomJS dependency
Key: RANGER-2321
URL: https://issues.apache.org/jira/browse/RANGER-2321
Project: Ranger
Issue Type: Bug
Components: admin
Affects Versions: 2.0.0
Reporter: Csaba Koncz
Assignee: Csaba Koncz
Docker build fails in an early phase do to the PhantomJS dependency introduced
in RANGER-2255. E.g. running
{code:java}
./build_ranger_using_docker.sh mvn clean verify -am -pl security-admin{code}
results in
{code:java}
[INFO] < org.apache.ranger:security-admin-web >
[INFO] Building Security Admin Web Application 2.0.0-SNAPSHOT [7/7]
[INFO] [ war ]-
[INFO]
[INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ security-admin-web
---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
security-admin-web ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
security-admin-web ---
[INFO]
[INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @
security-admin-web ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles)
@ security-admin-web ---
[INFO]
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @
security-admin-web ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 22 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (default) @ security-admin-web ---
[INFO] Executing tasks
main:
[INFO] Executed tasks
[INFO]
[INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and
npm) @ security-admin-web ---
[INFO] Installing node version v8.12.0
[INFO] Unpacking
/home/builder/.m2/repository/com/github/eirslett/node/8.12.0/node-8.12.0-linux-x64.tar.gz
into /ranger/security-admin/target/node/tmp
[INFO] Copying node binary from
/ranger/security-admin/target/node/tmp/node-v8.12.0-linux-x64/bin/node to
/ranger/security-admin/target/node/node
[INFO] Installed node locally.
[INFO] Installing npm version 6.4.1
[INFO] Unpacking
/home/builder/.m2/repository/com/github/eirslett/npm/6.4.1/npm-6.4.1.tar.gz
into /ranger/security-admin/target/node/node_modules
[INFO] Installed npm locally.
[INFO]
[INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ security-admin-web ---
[INFO] Running 'npm install' in /ranger/security-admin/target
[INFO]
[INFO] > phantomjs-prebuilt@2.1.16 install
/ranger/security-admin/target/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
[INFO] > node install.js
[INFO]
[INFO] PhantomJS not found on PATH
[INFO] Downloading
https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
[INFO] Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
[INFO] Receiving...
[INFO]
[INFO] Received 22866K total.
[INFO] Extracting tar contents (via spawned process)
[ERROR] Error extracting archive
[ERROR] Phantom installation failed { Error: Command failed: tar jxf
/tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
[ERROR] tar (child): bzip2: Cannot exec: No such file or directory
[ERROR] tar (child): Error is not recoverable: exiting now
[ERROR] tar: Child returned status 2
[ERROR] tar: Error is not recoverable: exiting now
[ERROR]
[ERROR] at ChildProcess.exithandler (child_process.js:276:12)
[ERROR] at emitTwo (events.js:126:13)
[ERROR] at ChildProcess.emit (events.js:214:7)
[ERROR] at maybeClose (internal/child_process.js:915:16)
[ERROR] at Socket.stream.socket.on (internal/child_process.js:336:11)
[ERROR] at emitOne (events.js:116:13)
[ERROR] at Socket.emit (events.js:211:7)
[ERROR] at Pipe._handle.close [as _onclose] (net.js:561:12)
[ERROR] killed: false,
[ERROR] code: 2,
[ERROR] signal: null,
[ERROR] cmd: 'tar jxf /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2' }
Error: Command failed: tar jxf
/tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
[ERROR] tar (child): bzip2: Cannot exec: No such file or directory
[ERROR] tar (child): Error is not recoverable: exiting now
[ERROR] tar: Child returned status 2
[ERROR] tar: Error is not recoverable: exiting now
[ERROR]
[ERROR] at ChildProcess.exithandler (child_process.js:276:12)
[ERROR] at emitTwo (events.js:126:13)
[ERROR] at ChildProcess.emit (events.js:214:7)
[ERROR] at maybeClose (internal/child_process.js:915:16)
[ERROR] at Socket.stream.socket.on (internal/child_process.js:336:11)
[ERROR] at emitOne (events.js:116:13)
[ERROR] at Socket.emit (events.js:211:7)
[ERROR] at Pipe._handle.close [as _onclose] (net.js:561:12)
[WARNING] npm WARN security-admin@2.0.0 No description
[WARNING] npm WARN security-admin@2.0.0 No repository field.
[WARNING] npm WARN security-admin@2.0.0 No license
[jira] [Commented] (RANGER-2255) Add JavaScript unit tests
[
https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738293#comment-16738293
]
Csaba Koncz commented on RANGER-2255:
-
[~pradeep.agrawal]: updated the review at [https://reviews.apache.org/r/69693/]
so that JavaScript testing is not done unless explicitly requested.
I.e.
{code:java}
mvn clean verify -am pl security-admin{code}
will run only Java tests and will not try to install Karma, Mocha and PhantomJS.
The command to run JS tests is:
{code:java}
mvn clean verify -am pl security-admin -DskipJSTests=false{code}
(we might want to add this to the Travis config)
Is this acceptable?
> Add JavaScript unit tests
> -
>
> Key: RANGER-2255
> URL: https://issues.apache.org/jira/browse/RANGER-2255
> Project: Ranger
> Issue Type: Wish
> Components: admin
>Affects Versions: 0.7.0, 2.0.0, 1.2.1
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Minor
> Fix For: 2.0.0
>
>
> It would be nice if the admin-ui project would have JavaScript unit tests.
> As with RANGER-2220 JavaScript minification was introduced, that can lead to
> new type of loading errors that were not seen before.
> It would be nice if there was an automatic check that validates the minified
> output.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738135#comment-16738135 ] Csaba Koncz commented on RANGER-2255: - [~pradeep.agrawal]: my change does not add any functionality, so yes, it can be reverted. On the other hand I would like to have some minimal JavaScript testing, so can we try to save it? I ran npm in a clean CentOS container (centos:7.5.1804) and it failed for me, too. It turned out that I need to install bzip2 and fontconfig. (yum install bzip2 fontconfig). Fontconfig is not needed for installation, only for the PhantomJS binary itself. The situation is the same with Debian 9: `apt-get update; apt-get install bzip2 fontconfig` is needed. Additionally, I can make JavaScript test execution disabled by default and run it only when an extra system property is specified (.e.g. -Djstests=true). > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-2319) Remove deprecated phantomjs NPM package
[
https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737022#comment-16737022
]
Csaba Koncz commented on RANGER-2319:
-
https://reviews.apache.org/r/69693/
> Remove deprecated phantomjs NPM package
> ---
>
> Key: RANGER-2319
> URL: https://issues.apache.org/jira/browse/RANGER-2319
> Project: Ranger
> Issue Type: Wish
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
>
> [Phantomjs|https://github.com/apache/ranger/blob/e1b0105eee67bb73c56b66b2dda1c3424555ab3e/security-admin/src/main/webapp/package.json#L15]
> NPM package is deprecated.
> {code:java}
> $ npm show phantomjs
> phantomjs@2.1.7 | Apache-2.0 | deps: 8 | versions: 81
> Headless WebKit with JS API
> https://github.com/Medium/phantomjs
> DEPRECATED ⚠️ - Package renamed to phantomjs-prebuilt. Please update
> 'phantomjs' package references to 'phantomjs-prebuilt'{code}
> Worse, karma-phantomjs-launcher brings in its version as phantomjs-prebuilt
> which results in Phantomjs binaries being downloaded twice.
> Build would speed up if only one Phantomjs version is downloaded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RANGER-2255) Add JavaScript unit tests
[
https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737025#comment-16737025
]
Csaba Koncz commented on RANGER-2255:
-
[~pradeep.agrawal], I noticed that two Phantomjs versions are currently
downloaded by npm, one of which is deprecated.
Removed the deprecated one (RANGER-2319), but this probably will not fix your
issue, as on Linux it is still a BZIP archive that is downloaded.
I tested the installation with Docker image node:8.15.0-alpine, there it works:
{code:java}
# npm i
> phantomjs-prebuilt@2.1.16 install /root/csaba/node_modules/phantomjs-prebuilt
> node install.js
PhantomJS not found on PATH
Downloading
https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Receiving...
[] 100%
Received 22866K total.
Extracting tar contents (via spawned process)
Removing /root/csaba/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder
/tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1546944498271/phantomjs-2.1.1-linux-x86_64
-> /root/csaba/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at
/root/csaba/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
npm WARN security-admin@2.0.0 No description
npm WARN security-admin@2.0.0 No repository field.
npm WARN security-admin@2.0.0 No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4
(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for
fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current:
{"os":"linux","arch":"x64"})
added 349 packages from 1057 contributors and audited 2496 packages in 48.538s
found 0 vulnerabilities{code}
> Add JavaScript unit tests
> -
>
> Key: RANGER-2255
> URL: https://issues.apache.org/jira/browse/RANGER-2255
> Project: Ranger
> Issue Type: Wish
> Components: admin
>Affects Versions: 0.7.0, 2.0.0, 1.2.1
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Minor
> Fix For: 2.0.0
>
>
> It would be nice if the admin-ui project would have JavaScript unit tests.
> As with RANGER-2220 JavaScript minification was introduced, that can lead to
> new type of loading errors that were not seen before.
> It would be nice if there was an automatic check that validates the minified
> output.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (RANGER-2319) Remove deprecated phantomjs NPM package
[
https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Csaba Koncz reassigned RANGER-2319:
---
Assignee: Csaba Koncz
> Remove deprecated phantomjs NPM package
> ---
>
> Key: RANGER-2319
> URL: https://issues.apache.org/jira/browse/RANGER-2319
> Project: Ranger
> Issue Type: Wish
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
>
> [Phantomjs|https://github.com/apache/ranger/blob/e1b0105eee67bb73c56b66b2dda1c3424555ab3e/security-admin/src/main/webapp/package.json#L15]
> NPM package is deprecated.
> {code:java}
> $ npm show phantomjs
> phantomjs@2.1.7 | Apache-2.0 | deps: 8 | versions: 81
> Headless WebKit with JS API
> https://github.com/Medium/phantomjs
> DEPRECATED ⚠️ - Package renamed to phantomjs-prebuilt. Please update
> 'phantomjs' package references to 'phantomjs-prebuilt'{code}
> Worse, karma-phantomjs-launcher brings in its version as phantomjs-prebuilt
> which results in Phantomjs binaries being downloaded twice.
> Build would speed up if only one Phantomjs version is downloaded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RANGER-2319) Remove deprecated phantomjs NPM package
[
https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Csaba Koncz updated RANGER-2319:
Description:
[Phantomjs|https://github.com/apache/ranger/blob/e1b0105eee67bb73c56b66b2dda1c3424555ab3e/security-admin/src/main/webapp/package.json#L15]
NPM package is deprecated.
{code:java}
$ npm show phantomjs
phantomjs@2.1.7 | Apache-2.0 | deps: 8 | versions: 81
Headless WebKit with JS API
https://github.com/Medium/phantomjs
DEPRECATED ⚠️ - Package renamed to phantomjs-prebuilt. Please update
'phantomjs' package references to 'phantomjs-prebuilt'{code}
Worse, karma-phantomjs-launcher brings in its version as phantomjs-prebuilt
which results in Phantomjs binaries being downloaded twice.
Build would speed up if only one Phantomjs version is downloaded.
was:
[Phantomjs|https://github.com/apache/ranger/blob/e1b0105eee67bb73c56b66b2dda1c3424555ab3e/security-admin/src/main/webapp/package.json#L15]
NPM package is deprecated.
{{}}
{code:java}
$ npm show phantomjs
phantomjs@2.1.7 | Apache-2.0 | deps: 8 | versions: 81
Headless WebKit with JS API
https://github.com/Medium/phantomjs
DEPRECATED ⚠️ - Package renamed to phantomjs-prebuilt. Please update
'phantomjs' package references to 'phantomjs-prebuilt'{code}
Worse, karma-phantomjs-launcher brings in its version as phantomjs-prebuilt
which results in Phantomjs binaries being downloaded twice.
Build would speed up if only one Phantomjs version is downloaded.
> Remove deprecated phantomjs NPM package
> ---
>
> Key: RANGER-2319
> URL: https://issues.apache.org/jira/browse/RANGER-2319
> Project: Ranger
> Issue Type: Wish
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Priority: Major
>
> [Phantomjs|https://github.com/apache/ranger/blob/e1b0105eee67bb73c56b66b2dda1c3424555ab3e/security-admin/src/main/webapp/package.json#L15]
> NPM package is deprecated.
> {code:java}
> $ npm show phantomjs
> phantomjs@2.1.7 | Apache-2.0 | deps: 8 | versions: 81
> Headless WebKit with JS API
> https://github.com/Medium/phantomjs
> DEPRECATED ⚠️ - Package renamed to phantomjs-prebuilt. Please update
> 'phantomjs' package references to 'phantomjs-prebuilt'{code}
> Worse, karma-phantomjs-launcher brings in its version as phantomjs-prebuilt
> which results in Phantomjs binaries being downloaded twice.
> Build would speed up if only one Phantomjs version is downloaded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (RANGER-2319) Remove deprecated phantomjs NPM package
Csaba Koncz created RANGER-2319:
---
Summary: Remove deprecated phantomjs NPM package
Key: RANGER-2319
URL: https://issues.apache.org/jira/browse/RANGER-2319
Project: Ranger
Issue Type: Wish
Components: admin
Affects Versions: 2.0.0
Reporter: Csaba Koncz
[Phantomjs|https://github.com/apache/ranger/blob/e1b0105eee67bb73c56b66b2dda1c3424555ab3e/security-admin/src/main/webapp/package.json#L15]
NPM package is deprecated.
{{}}
{code:java}
$ npm show phantomjs
phantomjs@2.1.7 | Apache-2.0 | deps: 8 | versions: 81
Headless WebKit with JS API
https://github.com/Medium/phantomjs
DEPRECATED ⚠️ - Package renamed to phantomjs-prebuilt. Please update
'phantomjs' package references to 'phantomjs-prebuilt'{code}
Worse, karma-phantomjs-launcher brings in its version as phantomjs-prebuilt
which results in Phantomjs binaries being downloaded twice.
Build would speed up if only one Phantomjs version is downloaded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736938#comment-16736938 ] Csaba Koncz commented on RANGER-2255: - Sorry [~pradeep.agrawal], I was not aware of the dependency on bzip2. Others seem to have seen the same issue: [https://github.com/Medium/phantomjs/issues/92#issuecomment-22908035] Is it an option for you to install bzip2 to your machine? Unfortunately I have no other guesses right now (do not know if I can get npm download some other type of archive). Best regards, Csaba > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654137#comment-16654137 ] Csaba Koncz commented on RANGER-2255: - Added JavaScript testing infrastructure (Karma, Mocha, PhantomJS) and a minimal test that checks whether the JavaScript application can be (hopefully) loaded: [https://reviews.apache.org/r/69067/] This required two changes in the production code: # Main.js was converted to an AMD module (it did not have a define wrapper, now it has) # Main.js loading is triggered by a script tag in index.html. The production and development versions now differ only in how the JavaScript assets are loaded into the browser: ## by letting RequireJS know the asset locations in Init.js and then rely on the recursive download ## by inlining all resources via Main.min.js. No RequireJS configuration is needed in this case. The test execution does not use index.html but has two configurations that differ only in the JS module loading method. > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-2220) Admin UI loads slowly because of many small JavaScript files
[ https://issues.apache.org/jira/browse/RANGER-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621209#comment-16621209 ] Csaba Koncz commented on RANGER-2220: - Here is the promised patch: [https://reviews.apache.org/r/68770/] It is quite large as it includes RequireJS optimizer source. Unfortunately I could thoroughly test it only on version 0.7.0 (the one included in HDP 2.6.5). For the master branch I only loaded the UI and checked that there are no RequireJS errors (did not have a compatible backend to check the functionality). > Admin UI loads slowly because of many small JavaScript files > > > Key: RANGER-2220 > URL: https://issues.apache.org/jira/browse/RANGER-2220 > Project: Ranger > Issue Type: Bug > Components: admin >Affects Versions: 1.1.0 >Reporter: Csaba Koncz >Assignee: Dhaval Rajpara >Priority: Minor > > The Admin UI web page loads slowly after login (~10 seconds or more, > depending on network conditions) > This is due to the ~140 small JavaScript files that need to be downloaded > before the UI can be presented to the user. > Compressing/concatenating (=minifying) JS resources and downloading them in a > single step can improve the situation. > Prototyped a solution for version 0.7 (using RequireJS Optimizer), will try > to port it to the master version. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2220) Admin UI loads slowly because of many small JavaScript files
Csaba Koncz created RANGER-2220: --- Summary: Admin UI loads slowly because of many small JavaScript files Key: RANGER-2220 URL: https://issues.apache.org/jira/browse/RANGER-2220 Project: Ranger Issue Type: Bug Components: admin Affects Versions: 1.1.0 Reporter: Csaba Koncz The Admin UI web page loads slowly after login (~10 seconds or more, depending on network conditions) This is due to the ~140 small JavaScript files that need to be downloaded before the UI can be presented to the user. Compressing/concatenating (=minifying) JS resources and downloading them in a single step can improve the situation. Prototyped a solution for version 0.7 (using RequireJS Optimizer), will try to port it to the master version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
