Re: [PR] RANGER-4750: Optimizations in the docker image build process [ranger]
mneethiraj commented on code in PR #302:
URL: https://github.com/apache/ranger/pull/302#discussion_r1558348942
##
dev-support/ranger-docker/Dockerfile.ranger-hbase:
##
@@ -22,14 +22,15 @@ ARG HBASE_PLUGIN_VERSION
COPY ./dist/version
/home/ranger/dist/
COPY ./dist/ranger-${HBASE_PLUGIN_VERSION}-hbase-plugin.tar.gz
/home/ranger/dist/
-COPY ./downloads/hbase-${HBASE_VERSION}-bin.tar.gz
/home/ranger/dist/
-COPY ./scripts/ranger-hbase-setup.sh /home/ranger/scripts/
-COPY ./scripts/ranger-hbase.sh /home/ranger/scripts/
-COPY ./scripts/ranger-hbase-plugin-install.properties/home/ranger/scripts/
-COPY ./scripts/hbase-site.xml/home/ranger/scripts/
+COPY ./scripts/ranger-hbase-setup.sh
/home/ranger/scripts/
+COPY ./scripts/ranger-hbase.sh
/home/ranger/scripts/
+COPY ./scripts/ranger-hbase-plugin-install.properties
/home/ranger/scripts/
+COPY ./scripts/hbase-site.xml
/home/ranger/scripts/
-RUN tar xvfz /home/ranger/dist/hbase-${HBASE_VERSION}-bin.tar.gz
--directory=/opt/ && \
+RUN wget -O /home/ranger/dist/hbase-${HBASE_VERSION}-bin.tar.gz \
Review Comment:
files like hbase--bin.tar.gz could be large. It will help to avoid
downloading such files for every build. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] RANGER-4750: Optimizations in the docker image build process [ranger]
kumaab opened a new pull request, #302:
URL: https://github.com/apache/ranger/pull/302
## What changes were proposed in this pull request?
Restructure the downloads of service tarballs from `download-archives.sh` to
`Dockerfile.ranger-service` as part of the image build for respective services.
Key highlights:
- When building specific images (eg: ranger-hadoop, ranger-hive), only
hadoop and hive tarballs are downloaded bringing down the time taken to bring
up the containers effectively.
- Allows to take advantage of docker parallelization thereby allowing
parallel service tarball downloads. Currently, the service tarball downloads
happen in a sequential manner with `download-archives.sh`.
- Although subject to network speeds, this also has shown minor improvements
in overall build times for all images.
## How was this patch tested?
Command to bring up containers:
- `docker-compose -f docker-compose.ranger-base.yml -f
docker-compose.ranger.yml -f docker-compose.ranger-${RANGER_DB_TYPE}.yml -f
docker-compose.ranger-usersync.yml -f docker-compose.ranger-tagsync.yml -f
docker-compose.ranger-kms.yml -f docker-compose.ranger-hadoop.yml -f
docker-compose.ranger-hbase.yml -f docker-compose.ranger-kafka.yml -f
docker-compose.ranger-hive.yml -f docker-compose.ranger-trino.yml -f
docker-compose.ranger-knox.yml build`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
