Re: [PR] Update trino-plugin to be compatible with the latest Trino SPI (version 433) [ranger]
nghiabuilvb commented on PR #290: URL: https://github.com/apache/ranger/pull/290#issuecomment-1884448532 > @okayhooni can you share your maven build command for ranger and trino plugin? I tried to build your fork with JDK 17 but getting errors > > `[ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.6:exploded (prepare) on project security-admin-web: Execution prepare of goal org.apache.maven.plugins:maven-war-plugin:2.6:exploded failed: Unable to load the mojo 'exploded' in the plugin 'org.apache.maven.plugins:maven-war-plugin:2.6' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: null` > > I build by the following command: > > `mvn -DskipTests=true clean compile package install` You should build only trino plugin, you can try to run this command: mvn clean package -DskipTests -P ranger-trino-plugin,-linux -am -pl distro,plugin-trino,ranger-trino-plugin-shim,agents-installer,credentialbuilder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update trino-plugin to be compatible with the latest Trino SPI (version 433) [ranger]
deebify commented on PR #290: URL: https://github.com/apache/ranger/pull/290#issuecomment-1882389974 @okayhooni can you share your maven build command for ranger and trino plugin? I tried to build your fork with JDK 17 but getting errors `[ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.6:exploded (prepare) on project security-admin-web: Execution prepare of goal org.apache.maven.plugins:maven-war-plugin:2.6:exploded failed: Unable to load the mojo 'exploded' in the plugin 'org.apache.maven.plugins:maven-war-plugin:2.6' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: null` I build by the following command: `mvn -DskipTests=true clean compile package install` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update trino-plugin to be compatible with the latest Trino SPI (version 433) [ranger]
okayhooni commented on PR #290: URL: https://github.com/apache/ranger/pull/290#issuecomment-1868894879 @leeyh0216 Sorry for the late response..! - We built and tested all the packages of Trino and Ranger with JDK 17 - I already committed the fixes on the `ranger-trino-plugin-shim` on this MR (https://github.com/apache/ranger/pull/290/files#diff-afa003f80796be360546cf8a2827aaf0842ca3c6f296554e88ab87f5056107dc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update trino-plugin to be compatible with the latest Trino SPI (version 433) [ranger]
leeyh0216 commented on PR #290: URL: https://github.com/apache/ranger/pull/290#issuecomment-1862864010 Hello, @okayhooni Although we are not doing Ranger Contributing, we are using the same upgraded version of Trino internally. How did you test these changes? I remember that Trino Dependency built with JDK 17 could not be used on the Ranger Admin side (built with JDK8), so I was curious how you got it running. (In our case, Ranger Admin was also built based on JDK 17.) Additionally, there doesn't seem to be any code modification for `ranger-trino-plugin-shim`, but I think it needs to be modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
