[jira] [Commented] (RANGER-2229) Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-10-17 Thread bhavik patel (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653278#comment-16653278
 ] 

bhavik patel commented on RANGER-2229:
--

Commit link for 
[ranger-1|https://github.com/apache/ranger/commit/44f1652780ae6367b898b15156bf91cab093d689]
 , 
[ranger-1.1|https://github.com/apache/ranger/commit/634999e52fdaf497027b534173766cb9b9185882],
 
[ranger-1.2|https://github.com/apache/ranger/commit/25a46567857277f346d5aafc07de83111d8ac044]

> Perform graceful terminate with retries before doing forceful kill for 
> usersync and tagsync
> ---
>
> Key: RANGER-2229
> URL: https://issues.apache.org/jira/browse/RANGER-2229
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync, usersync
>Affects Versions: 1.1.0
>Reporter: suja s
>Assignee: bhavik patel
>Priority: Major
> Attachments: RANGER-2229-01.patch, RANGER-2229.patch
>
>
> In ranger usersync and tagsync scripts, stop of the process is done 
> forcefully using kill -9.
> Suggestion is to do a graceful shutdown with retries and do a force kill only 
> if graceful shutdown is not successful.
> Stop section from ranger-tagsync-services.sh and ranger-tusersync-services.sh
> {noformat}
> lif [ "${action}" == "STOP" ]; then
>  WAIT_TIME_FOR_SHUTDOWN=2
>  NR_ITER_FOR_SHUTDOWN_CHECK=15
>  if [ -f "$pidf" ] ; then
>  pid=`cat $pidf` > /dev/null 2>&1
>  echo "Found Apache Ranger TagSync Service with pid $pid, Stopping..."
>  kill -9 $pid > /dev/null 2>&1
>  sleep 1 #Give kill -9 sometime to "kill"
>  if ps -p $pid > /dev/null; then
>  echo "Wow, even kill -9 failed, giving up! Sorry.."
>  else
>  rm -f $pidf
>  echo "Apache Ranger Tagsync Service pid = ${pid} has been stopped."
>  fi
>  else
>  echo "Ranger Tagsync Service not running"
>  fi
>  exit;
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2229) Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-10-08 Thread bhavik patel (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642774#comment-16642774
 ] 

bhavik patel commented on RANGER-2229:
--

Commit link for master branch : 
https://github.com/apache/ranger/commit/f8aff4e14e8910e084c089eea8aedfa8ddfacc90

> Perform graceful terminate with retries before doing forceful kill for 
> usersync and tagsync
> ---
>
> Key: RANGER-2229
> URL: https://issues.apache.org/jira/browse/RANGER-2229
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync, usersync
>Affects Versions: 1.1.0
>Reporter: suja s
>Assignee: bhavik patel
>Priority: Major
> Attachments: RANGER-2229.patch
>
>
> In ranger usersync and tagsync scripts, stop of the process is done 
> forcefully using kill -9.
> Suggestion is to do a graceful shutdown with retries and do a force kill only 
> if graceful shutdown is not successful.
> Stop section from ranger-tagsync-services.sh and ranger-tusersync-services.sh
> {noformat}
> lif [ "${action}" == "STOP" ]; then
>  WAIT_TIME_FOR_SHUTDOWN=2
>  NR_ITER_FOR_SHUTDOWN_CHECK=15
>  if [ -f "$pidf" ] ; then
>  pid=`cat $pidf` > /dev/null 2>&1
>  echo "Found Apache Ranger TagSync Service with pid $pid, Stopping..."
>  kill -9 $pid > /dev/null 2>&1
>  sleep 1 #Give kill -9 sometime to "kill"
>  if ps -p $pid > /dev/null; then
>  echo "Wow, even kill -9 failed, giving up! Sorry.."
>  else
>  rm -f $pidf
>  echo "Apache Ranger Tagsync Service pid = ${pid} has been stopped."
>  fi
>  else
>  echo "Ranger Tagsync Service not running"
>  fi
>  exit;
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)