Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

[Velmurugan Periasamy]

> On March 15, 2018, 2:26 a.m., Velmurugan Periasamy wrote:
> > Ship It!

Please fix the comment before committing.


- Velmurugan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65978/#review199237
---


On March 8, 2018, 7:18 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65978/
> ---
> 
> (Updated March 8, 2018, 7:18 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2013
> https://issues.apache.org/jira/browse/RANGER-2013
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvise validation in user profile to handle retention of original user 
> source.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa 
> 
> 
> Diff: https://reviews.apache.org/r/65978/diff/3/
> 
> 
> Testing
> ---
> 
> Tested and validated the update user Api.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65978/#review199237
---


Ship it!




Ship It!

- Velmurugan Periasamy


On March 8, 2018, 7:18 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65978/
> ---
> 
> (Updated March 8, 2018, 7:18 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2013
> https://issues.apache.org/jira/browse/RANGER-2013
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvise validation in user profile to handle retention of original user 
> source.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa 
> 
> 
> Diff: https://reviews.apache.org/r/65978/diff/3/
> 
> 
> Testing
> ---
> 
> Tested and validated the update user Api.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

[Fatima Khan]

> On March 8, 2018, 11:12 a.m., Velmurugan Periasamy wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
> > Line 360 (original), 360 (patched)
> > 
> >
> > With this approach, update is not retricted, but actually succeeds. Any 
> > particular reason?

user sync source is of int datatype which shall have default value ‘0’. 
Whenever user is not sending user sync source but still want to update the 
other fields, in that case if existing sync source is 1 then we can’t know the 
new sync source value 0 is explicitly set by user or not. so because of this 
case if we want to fail then user need to know the existing sync source and 
sending of sync source shall be mandatory irrespective of whether he intend to 
update sync source or not.


- Fatima


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65978/#review198874
---


On March 8, 2018, 7:18 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65978/
> ---
> 
> (Updated March 8, 2018, 7:18 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2013
> https://issues.apache.org/jira/browse/RANGER-2013
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvise validation in user profile to handle retention of original user 
> source.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa 
> 
> 
> Diff: https://reviews.apache.org/r/65978/diff/3/
> 
> 
> Testing
> ---
> 
> Tested and validated the update user Api.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65978/#review198874
---




security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
Line 360 (original), 360 (patched)


With this approach, update is not retricted, but actually succeeds. Any 
particular reason?


- Velmurugan Periasamy


On March 8, 2018, 7:18 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65978/
> ---
> 
> (Updated March 8, 2018, 7:18 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2013
> https://issues.apache.org/jira/browse/RANGER-2013
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvise validation in user profile to handle retention of original user 
> source.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa 
> 
> 
> Diff: https://reviews.apache.org/r/65978/diff/3/
> 
> 
> Testing
> ---
> 
> Tested and validated the update user Api.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

[Pradeep Agrawal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65978/#review198872
---


Ship it!




Ship It!

- Pradeep Agrawal


On March 8, 2018, 7:18 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65978/
> ---
> 
> (Updated March 8, 2018, 7:18 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2013
> https://issues.apache.org/jira/browse/RANGER-2013
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvise validation in user profile to handle retention of original user 
> source.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa 
> 
> 
> Diff: https://reviews.apache.org/r/65978/diff/3/
> 
> 
> Testing
> ---
> 
> Tested and validated the update user Api.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

[Fatima Khan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65978/
---

(Updated March 8, 2018, 7:18 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
Sailaja Polavarapu.


Bugs: RANGER-2013
https://issues.apache.org/jira/browse/RANGER-2013


Repository: ranger


Description
---

Improvise validation in user profile to handle retention of original user 
source.


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa 


Diff: https://reviews.apache.org/r/65978/diff/3/

Changes: https://reviews.apache.org/r/65978/diff/2-3/


Testing
---

Tested and validated the update user Api.


Thanks,

Fatima Khan

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

[Fatima Khan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65978/
---

(Updated March 8, 2018, 6:54 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
Sailaja Polavarapu.


Bugs: RANGER-2013
https://issues.apache.org/jira/browse/RANGER-2013


Repository: ranger


Description
---

Improvise validation in user profile to handle retention of original user 
source.


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa 


Diff: https://reviews.apache.org/r/65978/diff/2/

Changes: https://reviews.apache.org/r/65978/diff/1-2/


Testing
---

Tested and validated the update user Api.


Thanks,

Fatima Khan