Re: Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-08 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/#review218129
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 8, 2019, 2 a.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71587/
> ---
> 
> (Updated Oct. 8, 2019, 2 a.m.)
> 
> 
> Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2606
> https://issues.apache.org/jira/browse/RANGER-2606
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added all modules to the sign-artifacts profile to fix this issue ...
> 
> 
> Diffs
> -
> 
>   pom.xml bb2e84728 
> 
> 
> Diff: https://reviews.apache.org/r/71587/diff/2/
> 
> 
> Testing
> ---
> 
> Ran it from v2.0 release codebase to check if it is able to upload as part of 
> the deployment. It works!
> * Also, fixed some of the TAB characters (replaced with SPACE to look nice)
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>

Re: Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-07 Thread Selvamohan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/
---

(Updated Oct. 7, 2019, 10 p.m.)


Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
and Velmurugan Periasamy.


Changes
---

uploaded the diff file for the master branch


Bugs: RANGER-2606
https://issues.apache.org/jira/browse/RANGER-2606


Repository: ranger


Description
---

Added all modules to the sign-artifacts profile to fix this issue ...


Diffs (updated)
-

  pom.xml bb2e84728 


Diff: https://reviews.apache.org/r/71587/diff/2/

Changes: https://reviews.apache.org/r/71587/diff/1-2/


Testing
---

Ran it from v2.0 release codebase to check if it is able to upload as part of 
the deployment. It works!
* Also, fixed some of the TAB characters (replaced with SPACE to look nice)


Thanks,

Selvamohan Neethiraj

Re: Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-07 Thread Selvamohan Neethiraj 


> On Oct. 7, 2019, 5:39 p.m., Velmurugan Periasamy wrote:
> >

Was this patch worked for 2.0 release?  I will send another patch for master 
branch ...


- Selvamohan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/#review218125
---


On Oct. 7, 2019, 5:24 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71587/
> ---
> 
> (Updated Oct. 7, 2019, 5:24 p.m.)
> 
> 
> Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added all modules to the sign-artifacts profile to fix this issue ...
> 
> 
> Diffs
> -
> 
>   pom.xml afc27d2cb 
> 
> 
> Diff: https://reviews.apache.org/r/71587/diff/1/
> 
> 
> Testing
> ---
> 
> Ran it from v2.0 release codebase to check if it is able to upload as part of 
> the deployment. It works!
> * Also, fixed some of the TAB characters (replaced with SPACE to look nice)
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>

Re: Review Request 71587: RANGER-2606: added module to sign-artifacts profile to enable publish of all modules

2019-10-07 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71587/#review218125
---




pom.xml
Line 183 (original), 183 (patched)


Can you please rebase it to master branch? Patch fails to apply.

```
$ git apply --check -v < 
~/Downloads/0001-RANGER-2606-added-module-to-sign-artifacts-profile-t.patch
Checking patch pom.xml...
Hunk #1 succeeded at 117 (offset 1 line).
error: while searching for:
1.7
3.4.14

3.1.4
5.0.3
2.9.9

0.0.2
5.2.0
5.2.0

0.178
2.0.0

error: patch failed: pom.xml:183
error: pom.xml: patch does not apply
```


- Velmurugan Periasamy


On Oct. 7, 2019, 9:24 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71587/
> ---
> 
> (Updated Oct. 7, 2019, 9:24 p.m.)
> 
> 
> Review request for ranger, Colm O hEigeartaigh, Abhay Kulkarni, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added all modules to the sign-artifacts profile to fix this issue ...
> 
> 
> Diffs
> -
> 
>   pom.xml afc27d2cb 
> 
> 
> Diff: https://reviews.apache.org/r/71587/diff/1/
> 
> 
> Testing
> ---
> 
> Ran it from v2.0 release codebase to check if it is able to upload as part of 
> the deployment. It works!
> * Also, fixed some of the TAB characters (replaced with SPACE to look nice)
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>