Re: Review Request 74356: RANGER-4144 : Fixing test suite for kafka plugin

2023-03-21 Thread Don Bosco Durai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74356/#review225291
---


Ship it!




Ship It!

- Don Bosco Durai


On March 20, 2023, 7:43 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74356/
> ---
> 
> (Updated March 20, 2023, 7:43 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4144
> https://issues.apache.org/jira/browse/RANGER-4144
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Changed version of curator test version from 2.12.0 to 5.4.0 & fixed Java 
> Autoboxing issues
> 
> 
> Diffs
> -
> 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
>  d24ee1e57 
>   pom.xml 1e77f5191 
> 
> 
> Diff: https://reviews.apache.org/r/74356/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Run Unit Test (as part of build) done on Linux Platform
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>

Re: Review Request 74356: RANGER-4144 : Fixing test suite for kafka plugin

2023-03-21 Thread Don Bosco Durai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74356/#review225290
---



Approved


plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
Lines 110 (patched)


Seems IOException will come only from line 105, this review comment is not 
valid. I am approving the changes


- Don Bosco Durai


On March 20, 2023, 7:43 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74356/
> ---
> 
> (Updated March 20, 2023, 7:43 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4144
> https://issues.apache.org/jira/browse/RANGER-4144
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Changed version of curator test version from 2.12.0 to 5.4.0 & fixed Java 
> Autoboxing issues
> 
> 
> Diffs
> -
> 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
>  d24ee1e57 
>   pom.xml 1e77f5191 
> 
> 
> Diff: https://reviews.apache.org/r/74356/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Run Unit Test (as part of build) done on Linux Platform
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>

Re: Review Request 74356: RANGER-4144 : Fixing test suite for kafka plugin

2023-03-21 Thread Selvamohan Neethiraj 


> On March 21, 2023, 6:21 p.m., Don Bosco Durai wrote:
> > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
> > Lines 110 (patched)
> > 
> >
> > Is this message misleading? Even line 106 will through exception. Would 
> > it be the same reason for port not available?

Bosco, Thanks for the review. The IOException Catch was to cover the exception 
from the Constructor of ServerSocket call (in line number 105) - where it will 
never reach the line 106. Line number 106 and 108 throws AssertionError (not an 
IOException) and is handled by JUNIT testing framework.


- Selvamohan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74356/#review225288
---


On March 20, 2023, 3:43 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74356/
> ---
> 
> (Updated March 20, 2023, 3:43 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4144
> https://issues.apache.org/jira/browse/RANGER-4144
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Changed version of curator test version from 2.12.0 to 5.4.0 & fixed Java 
> Autoboxing issues
> 
> 
> Diffs
> -
> 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
>  d24ee1e57 
>   pom.xml 1e77f5191 
> 
> 
> Diff: https://reviews.apache.org/r/74356/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Run Unit Test (as part of build) done on Linux Platform
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>

Re: Review Request 74356: RANGER-4144 : Fixing test suite for kafka plugin

2023-03-21 Thread Don Bosco Durai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74356/#review225288
---




plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
Lines 110 (patched)


Is this message misleading? Even line 106 will through exception. Would it 
be the same reason for port not available?


- Don Bosco Durai


On March 20, 2023, 7:43 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74356/
> ---
> 
> (Updated March 20, 2023, 7:43 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4144
> https://issues.apache.org/jira/browse/RANGER-4144
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Changed version of curator test version from 2.12.0 to 5.4.0 & fixed Java 
> Autoboxing issues
> 
> 
> Diffs
> -
> 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
>  d24ee1e57 
>   pom.xml 1e77f5191 
> 
> 
> Diff: https://reviews.apache.org/r/74356/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Run Unit Test (as part of build) done on Linux Platform
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>