Re: Review Request 74834: RANGER-4650: Hive plugin should make column-type available in masking expression

2024-04-25 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74834/#review226402
---


Ship it!




Ship It!

- Ramesh Mani


On Feb. 10, 2024, 5:17 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74834/
> ---
> 
> (Updated Feb. 10, 2024, 5:17 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, 
> Siddhesh Phatak, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4650
> https://issues.apache.org/jira/browse/RANGER-4650
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - in addition to {col} macro, Ranger Hive plugin now supports {colType} macro 
> as well, which will evaluate to the datatype of the column being masked
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  44c66dfd9 
> 
> 
> Diff: https://reviews.apache.org/r/74834/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that all existing tests pass successfully
> - verified with the following custom masking expression:
>   CASE WHEN '{colType}' == 'string' THEN mask_hash({col}) WHEN '{colType}' == 
> 'int' THEN mask({col}) ELSE NULL END
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74834: RANGER-4650: Hive plugin should make column-type available in masking expression

2024-04-25 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74834/#review226401
---


Ship it!




Ship It!

- Abhay Kulkarni


On Feb. 10, 2024, 5:17 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74834/
> ---
> 
> (Updated Feb. 10, 2024, 5:17 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, 
> Siddhesh Phatak, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4650
> https://issues.apache.org/jira/browse/RANGER-4650
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - in addition to {col} macro, Ranger Hive plugin now supports {colType} macro 
> as well, which will evaluate to the datatype of the column being masked
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  44c66dfd9 
> 
> 
> Diff: https://reviews.apache.org/r/74834/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that all existing tests pass successfully
> - verified with the following custom masking expression:
>   CASE WHEN '{colType}' == 'string' THEN mask_hash({col}) WHEN '{colType}' == 
> 'int' THEN mask({col}) ELSE NULL END
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74834: RANGER-4650: Hive plugin should make column-type available in masking expression

2024-02-09 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74834/
---

(Updated Feb. 10, 2024, 5:17 a.m.)


Review request for ranger, Anand Nadar, Asit Vadhavkar, Abhay Kulkarni, Mehul 
Parikh, Monika Kachhadiya, Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, 
Siddhesh Phatak, Subhrat Chaudhary, and Velmurugan Periasamy.


Bugs: RANGER-4650
https://issues.apache.org/jira/browse/RANGER-4650


Repository: ranger


Description
---

- in addition to {col} macro, Ranger Hive plugin now supports {colType} macro 
as well, which will evaluate to the datatype of the column being masked


Diffs
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 44c66dfd9 


Diff: https://reviews.apache.org/r/74834/diff/1/


Testing (updated)
---

- verified that all existing tests pass successfully
- verified with the following custome masking expression:
  CASE WHEN '{colType}' == 'string' THEN mask_hash({col}) WHEN '{colType}' == 
'int' THEN mask({col}) ELSE NULL END


Thanks,

Madhan Neethiraj