subject:"Re\: Review Request 74926\: RANGER\-4076\: Support Java 17 for build and runtime"

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-05-10 Thread bhavik patel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226427
---




pom.xml
Line 122 (original), 122 (patched)


any specific reason to downgrade the graalvm version?



pom.xml
Lines 374 (patched)


enunciate version depends on jdk?


- bhavik patel


On May 9, 2024, 3:03 p.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated May 9, 2024, 3:03 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
>  6eb192270 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
>  4a0081579 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
>  0059bef88 
>   dev-support/ranger-docker/.env 91613e5ec 
>   dev-support/ranger-docker/Dockerfile.ranger-base 72a850482 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
>   dev-support/ranger-docker/scripts/ranger-hadoop-setup.sh 10f04acd9 
>   dev-support/ranger-docker/scripts/ranger-hbase-setup.sh 95a1bdf21 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
>   distro/src/main/assembly/hdfs-agent.xml 349badfd2 
>   distro/src/main/assembly/hive-agent.xml 5bae92ac5 
>   distro/src/main/assembly/knox-agent.xml 3fa867150 
>   distro/src/main/assembly/plugin-atlas.xml c389282fc 
>   distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
>   distro/src/main/assembly/plugin-kms.xml 7c6a16330 
>   distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
>   distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
>   distro/src/main/assembly/plugin-presto.xml d50edf2d9 
>   distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
>   distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
>   distro/src/main/assembly/plugin-yarn.xml 5db884710 
>   distro/src/main/assembly/storm-agent.xml a334e247c 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml bfac6424a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   knox-agent/pom.xml 4387efb5c 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml efd152040 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/4/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> ### JDK 8 maven build successfully
> mvn clean compile package install
> 
> ### JDK 11 maven build successfully
> mvn clean compile package install
> 
> ### JDK 17 maven build successfully
> mvn clean compile package install -Pranger-all-modules-jdk17
> 
> ### Validated policy enforcement for below scenario :
> ## Scenario 1:
> Successfully validated policy enforcement(policy-condition) for HDFS, HBase 
> and Hive services using Ranger with JDK 8 for both build and runtime 
> environments.
> ## Scenario 2:
> Successfully validated policy

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-05-09 Thread Rakesh Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/
---

(Updated May 9, 2024, 3:03 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket 
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4076
https://issues.apache.org/jira/browse/RANGER-4076


Repository: ranger


Description
---

Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version of 
Java and adding support would modernize our Java version support.

This patch enables manual and Docker-based build of Apache Ranger. It ensures 
compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
environments.


Diffs
-

  agents-common/pom.xml 12e093f78 
  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
 6eb192270 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
 512d8d3ca 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
 4a0081579 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
 db620df92 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java 
8d76c1d81 
  
agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
 0059bef88 
  dev-support/ranger-docker/.env 91613e5ec 
  dev-support/ranger-docker/Dockerfile.ranger-base 72a850482 
  dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
  dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
  dev-support/ranger-docker/scripts/ranger-hadoop-setup.sh 10f04acd9 
  dev-support/ranger-docker/scripts/ranger-hbase-setup.sh 95a1bdf21 
  distro/src/main/assembly/admin-web.xml 245d9ca09 
  distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
  distro/src/main/assembly/hdfs-agent.xml 349badfd2 
  distro/src/main/assembly/hive-agent.xml 5bae92ac5 
  distro/src/main/assembly/knox-agent.xml 3fa867150 
  distro/src/main/assembly/plugin-atlas.xml c389282fc 
  distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
  distro/src/main/assembly/plugin-kms.xml 7c6a16330 
  distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
  distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
  distro/src/main/assembly/plugin-presto.xml d50edf2d9 
  distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
  distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
  distro/src/main/assembly/plugin-yarn.xml 5db884710 
  distro/src/main/assembly/storm-agent.xml a334e247c 
  docs/src/site/resources/index.js bb876f28d 
  hdfs-agent/pom.xml dece8f46f 
  kms/pom.xml bfac6424a 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java b6fc32950 
  knox-agent/pom.xml 4387efb5c 
  plugin-nestedstructure/pom.xml 0e208f99c 
  
plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
 77767767c 
  
plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
 9cb161b8d 
  pom.xml efd152040 
  security-admin/pom.xml fc59287d0 


Diff: https://reviews.apache.org/r/74926/diff/4/


Testing (updated)
---

This patch has been successfully tested and verified with Java versions 8, 11, 
and 17. The verification process included both manual and Docker setup. Now we 
are able to build and run on same jdk.

### JDK 8 maven build successfully
mvn clean compile package install

### JDK 11 maven build successfully
mvn clean compile package install

### JDK 17 maven build successfully
mvn clean compile package install -Pranger-all-modules-jdk17

### Validated policy enforcement for below scenario :
## Scenario 1:
Successfully validated policy enforcement(policy-condition) for HDFS, HBase and 
Hive services using Ranger with JDK 8 for both build and runtime environments.
## Scenario 2:
Successfully validated policy enforcement(policy-condition) for HDFS, HBase 
services using Ranger with JDK 17 for both build and runtime environments.


Thanks,

Rakesh Gupta

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-05-09 Thread Rakesh Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/
---

(Updated May 9, 2024, 3:02 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket 
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4076
https://issues.apache.org/jira/browse/RANGER-4076


Repository: ranger


Description
---

Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version of 
Java and adding support would modernize our Java version support.

This patch enables manual and Docker-based build of Apache Ranger. It ensures 
compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
environments.


Diffs (updated)
-

  agents-common/pom.xml 12e093f78 
  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
 6eb192270 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
 512d8d3ca 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
 4a0081579 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
 db620df92 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java 
8d76c1d81 
  
agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
 0059bef88 
  dev-support/ranger-docker/.env 91613e5ec 
  dev-support/ranger-docker/Dockerfile.ranger-base 72a850482 
  dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
  dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
  dev-support/ranger-docker/scripts/ranger-hadoop-setup.sh 10f04acd9 
  dev-support/ranger-docker/scripts/ranger-hbase-setup.sh 95a1bdf21 
  distro/src/main/assembly/admin-web.xml 245d9ca09 
  distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
  distro/src/main/assembly/hdfs-agent.xml 349badfd2 
  distro/src/main/assembly/hive-agent.xml 5bae92ac5 
  distro/src/main/assembly/knox-agent.xml 3fa867150 
  distro/src/main/assembly/plugin-atlas.xml c389282fc 
  distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
  distro/src/main/assembly/plugin-kms.xml 7c6a16330 
  distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
  distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
  distro/src/main/assembly/plugin-presto.xml d50edf2d9 
  distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
  distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
  distro/src/main/assembly/plugin-yarn.xml 5db884710 
  distro/src/main/assembly/storm-agent.xml a334e247c 
  docs/src/site/resources/index.js bb876f28d 
  hdfs-agent/pom.xml dece8f46f 
  kms/pom.xml bfac6424a 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java b6fc32950 
  knox-agent/pom.xml 4387efb5c 
  plugin-nestedstructure/pom.xml 0e208f99c 
  
plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
 77767767c 
  
plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
 9cb161b8d 
  pom.xml efd152040 
  security-admin/pom.xml fc59287d0 


Diff: https://reviews.apache.org/r/74926/diff/4/

Changes: https://reviews.apache.org/r/74926/diff/3-4/


Testing (updated)
---

This patch has been successfully tested and verified with Java versions 8, 11, 
and 17. The verification process included both manual and Docker setup. Now we 
are able to build and run on same jdk.

### JDK 8 maven build successfully
mvn clean compile package install

### JDK 11 maven build successfully
mvn clean compile package install

### JDK 17 maven build successfully
mvn clean compile package install -Pranger-all-modules-jdk17

Validated policy enforcement for below scenario :
## Scenario 1:
Successfully validated policy enforcement(policy-condition) for HDFS, HBase and 
Hive services using Ranger with JDK 8 for both build and runtime environments.
## Scenario 2:
Successfully validated policy enforcement(policy-condition) for HDFS, HBase 
services using Ranger with JDK 17 for both build and runtime environments.


Thanks,

Rakesh Gupta

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-05-09 Thread Rakesh Gupta



> On April 23, 2024, 3:29 p.m., bhavik patel wrote:
> > Have you validated the policy enforcement for any plugin?

Validated policy enforcement for below plugin :
Scenario 1:
Successfully validated policy enforcement(policy-condition) for HDFS, HBase, 
and Hive services using Ranger with JDK 8 for both build and runtime 
environments.
Scenario 2:
Successfully validated policy enforcement(policy-condition) for HDFS, HBase 
services using Ranger with JDK 17 for both build and runtime environments.


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226395
---


On April 23, 2024, 12:32 p.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated April 23, 2024, 12:32 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
>  6eb192270 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
>  4a0081579 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
>  0059bef88 
>   dev-support/ranger-docker/.env 91613e5ec 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
>   distro/src/main/assembly/hdfs-agent.xml 349badfd2 
>   distro/src/main/assembly/hive-agent.xml 5bae92ac5 
>   distro/src/main/assembly/knox-agent.xml 3fa867150 
>   distro/src/main/assembly/plugin-atlas.xml c389282fc 
>   distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
>   distro/src/main/assembly/plugin-kms.xml 7c6a16330 
>   distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
>   distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
>   distro/src/main/assembly/plugin-presto.xml d50edf2d9 
>   distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
>   distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
>   distro/src/main/assembly/plugin-yarn.xml 5db884710 
>   distro/src/main/assembly/storm-agent.xml a334e247c 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 0b37ce52d 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   knox-agent/pom.xml 4387efb5c 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml efd152040 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/3/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> ### JDK 8 maven build successfully
> mvn clean compile package install
> 
> ### JDK 11 maven build successfully
> mvn clean compile package install
> 
> ### JDK 17 maven build successfully
> mvn clean compile package install -Pranger-all-modules-jdk17
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-04-23 Thread bhavik patel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226395
---



Have you validated the policy enforcement for any plugin?

- bhavik patel


On April 23, 2024, 12:32 p.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated April 23, 2024, 12:32 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
>  6eb192270 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
>  4a0081579 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
>  0059bef88 
>   dev-support/ranger-docker/.env 91613e5ec 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
>   distro/src/main/assembly/hdfs-agent.xml 349badfd2 
>   distro/src/main/assembly/hive-agent.xml 5bae92ac5 
>   distro/src/main/assembly/knox-agent.xml 3fa867150 
>   distro/src/main/assembly/plugin-atlas.xml c389282fc 
>   distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
>   distro/src/main/assembly/plugin-kms.xml 7c6a16330 
>   distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
>   distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
>   distro/src/main/assembly/plugin-presto.xml d50edf2d9 
>   distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
>   distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
>   distro/src/main/assembly/plugin-yarn.xml 5db884710 
>   distro/src/main/assembly/storm-agent.xml a334e247c 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 0b37ce52d 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   knox-agent/pom.xml 4387efb5c 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml efd152040 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/3/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> ### JDK 8 maven build successfully
> mvn clean compile package install
> 
> ### JDK 11 maven build successfully
> mvn clean compile package install
> 
> ### JDK 17 maven build successfully
> mvn clean compile package install -Pranger-all-modules-jdk17
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-04-23 Thread Rakesh Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/
---

(Updated April 23, 2024, 12:32 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket 
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4076
https://issues.apache.org/jira/browse/RANGER-4076


Repository: ranger


Description
---

Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version of 
Java and adding support would modernize our Java version support.

This patch enables manual and Docker-based build of Apache Ranger. It ensures 
compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
environments.


Diffs (updated)
-

  agents-common/pom.xml 12e093f78 
  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
 6eb192270 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
 512d8d3ca 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
 4a0081579 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
 db620df92 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java 
8d76c1d81 
  
agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
 0059bef88 
  dev-support/ranger-docker/.env 91613e5ec 
  dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
  dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
  distro/src/main/assembly/admin-web.xml 245d9ca09 
  distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
  distro/src/main/assembly/hdfs-agent.xml 349badfd2 
  distro/src/main/assembly/hive-agent.xml 5bae92ac5 
  distro/src/main/assembly/knox-agent.xml 3fa867150 
  distro/src/main/assembly/plugin-atlas.xml c389282fc 
  distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
  distro/src/main/assembly/plugin-kms.xml 7c6a16330 
  distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
  distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
  distro/src/main/assembly/plugin-presto.xml d50edf2d9 
  distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
  distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
  distro/src/main/assembly/plugin-yarn.xml 5db884710 
  distro/src/main/assembly/storm-agent.xml a334e247c 
  docs/src/site/resources/index.js bb876f28d 
  hdfs-agent/pom.xml dece8f46f 
  kms/pom.xml 0b37ce52d 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java b6fc32950 
  knox-agent/pom.xml 4387efb5c 
  plugin-nestedstructure/pom.xml 0e208f99c 
  
plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
 77767767c 
  
plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
 9cb161b8d 
  pom.xml efd152040 
  security-admin/pom.xml fc59287d0 


Diff: https://reviews.apache.org/r/74926/diff/3/

Changes: https://reviews.apache.org/r/74926/diff/2-3/


Testing (updated)
---

This patch has been successfully tested and verified with Java versions 8, 11, 
and 17. The verification process included both manual and Docker setup. Now we 
are able to build and run on same jdk.

### JDK 8 maven build successfully
mvn clean compile package install

### JDK 11 maven build successfully
mvn clean compile package install

### JDK 17 maven build successfully
mvn clean compile package install -Pranger-all-modules-jdk17


Thanks,

Rakesh Gupta

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-04-23 Thread Rakesh Gupta



> On March 6, 2024, 3:28 p.m., bhavik patel wrote:
> > After starting the server have checked the catalina and ranger admin login 
> > file?
> 
> Rakesh Gupta wrote:
> After starting the server, I checked the Catalina error log, which is 
> being handled by Jira ticket RANGER-4744. However, the Ranger admin log does 
> not appear, and this will also be handled by Jira ticket RANGER-4743.
> 
> bhavik patel wrote:
> it's better as a part of current jira only basic functionality should 
> work.

ok, I have handled it in the current patch


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226292
---


On April 19, 2024, 3:19 p.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated April 19, 2024, 3:19 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
>  4a0081579 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
>  0059bef88 
>   dev-support/ranger-docker/.env 91613e5ec 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
>   distro/src/main/assembly/hdfs-agent.xml 349badfd2 
>   distro/src/main/assembly/hive-agent.xml 5bae92ac5 
>   distro/src/main/assembly/knox-agent.xml 3fa867150 
>   distro/src/main/assembly/plugin-atlas.xml c389282fc 
>   distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
>   distro/src/main/assembly/plugin-kms.xml 7c6a16330 
>   distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
>   distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
>   distro/src/main/assembly/plugin-presto.xml d50edf2d9 
>   distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
>   distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
>   distro/src/main/assembly/plugin-yarn.xml 5db884710 
>   distro/src/main/assembly/storm-agent.xml a334e247c 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 0b37ce52d 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   knox-agent/pom.xml 4387efb5c 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml efd152040 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/2/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> ### JDK 8 build successfully
> mvn clean compile package install
> 
> ### JDK 11 build successfully
> mvn clean compile package install
> 
> ### JDK 17 build successfully
> mvn clean compile package install -Pranger-all-modules-jdk17
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-04-19 Thread Rakesh Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/
---

(Updated April 19, 2024, 3:19 p.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket 
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
---

Review comment handle


Bugs: RANGER-4076
https://issues.apache.org/jira/browse/RANGER-4076


Repository: ranger


Description (updated)
---

Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version of 
Java and adding support would modernize our Java version support.

This patch enables manual and Docker-based build of Apache Ranger. It ensures 
compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
environments.


Diffs (updated)
-

  agents-common/pom.xml 12e093f78 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
 512d8d3ca 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEngineCreator.java
 4a0081579 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
 db620df92 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java 
8d76c1d81 
  
agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
 0059bef88 
  dev-support/ranger-docker/.env 91613e5ec 
  dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
  dev-support/ranger-docker/docker-compose.ranger-build.yml c8760aab5 
  distro/src/main/assembly/admin-web.xml 245d9ca09 
  distro/src/main/assembly/hbase-agent.xml ffb1de0c5 
  distro/src/main/assembly/hdfs-agent.xml 349badfd2 
  distro/src/main/assembly/hive-agent.xml 5bae92ac5 
  distro/src/main/assembly/knox-agent.xml 3fa867150 
  distro/src/main/assembly/plugin-atlas.xml c389282fc 
  distro/src/main/assembly/plugin-kafka.xml 4ffbdd611 
  distro/src/main/assembly/plugin-kms.xml 7c6a16330 
  distro/src/main/assembly/plugin-kylin.xml 9aefa49d4 
  distro/src/main/assembly/plugin-ozone.xml 294e5b9ef 
  distro/src/main/assembly/plugin-presto.xml d50edf2d9 
  distro/src/main/assembly/plugin-solr.xml bcb24c0fc 
  distro/src/main/assembly/plugin-sqoop.xml adc2a9c26 
  distro/src/main/assembly/plugin-yarn.xml 5db884710 
  distro/src/main/assembly/storm-agent.xml a334e247c 
  docs/src/site/resources/index.js bb876f28d 
  hdfs-agent/pom.xml dece8f46f 
  kms/pom.xml 0b37ce52d 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java b6fc32950 
  knox-agent/pom.xml 4387efb5c 
  plugin-nestedstructure/pom.xml 0e208f99c 
  
plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
 77767767c 
  
plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
 9cb161b8d 
  pom.xml efd152040 
  security-admin/pom.xml fc59287d0 


Diff: https://reviews.apache.org/r/74926/diff/2/

Changes: https://reviews.apache.org/r/74926/diff/1-2/


Testing (updated)
---

This patch has been successfully tested and verified with Java versions 8, 11, 
and 17. The verification process included both manual and Docker setup. Now we 
are able to build and run on same jdk.

### JDK 8 build successfully
mvn clean compile package install

### JDK 11 build successfully
mvn clean compile package install

### JDK 17 build successfully
mvn clean compile package install -Pranger-all-modules-jdk17


Thanks,

Rakesh Gupta

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-04-19 Thread Rakesh Gupta



> On March 6, 2024, 6:28 a.m., Kishor Gollapalliwar wrote:
> > plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
> > Line 59 (original), 62 (patched)
> > 
> >
> > Will this break backword compatibility. If a older setup is using 
> > Scripts (compatible with Nashorm), will they need to update ?

No, backward compatibility won't be affected


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226288
---


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-28 Thread bhavik patel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226358
---



Can you verify the Usersync, Tagsync and Ranger KMS as well?

- bhavik patel


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-28 Thread bhavik patel



> On March 6, 2024, 3:28 p.m., bhavik patel wrote:
> > After starting the server have checked the catalina and ranger admin login 
> > file?
> 
> Rakesh Gupta wrote:
> After starting the server, I checked the Catalina error log, which is 
> being handled by Jira ticket RANGER-4744. However, the Ranger admin log does 
> not appear, and this will also be handled by Jira ticket RANGER-4743.

it's better as a part of current jira only basic functionality should work.


- bhavik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226292
---


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-22 Thread Abhishek Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226345
---




pom.xml
Lines 412 (patched)


Building the full repo is not advisable unless changes have been tested 
with JDK 17 at runtime. Please take a look at ranger-jdk11 profile and try to 
see if it can be used here.


- Abhishek  Kumar


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-18 Thread Rakesh Gupta



> On March 6, 2024, 3:28 p.m., bhavik patel wrote:
> > After starting the server have checked the catalina and ranger admin login 
> > file?

After starting the server, I checked the Catalina error log, which is being 
handled by Jira ticket RANGER-4744. However, the Ranger admin log does not 
appear, and this will also be handled by Jira ticket RANGER-4743.


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226292
---


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-12 Thread Rakesh Gupta



> On March 6, 2024, 6:30 a.m., Kishor Gollapalliwar wrote:
> > pom.xml
> > Lines 428 (patched)
> > 
> >
> > Are we planning to make changes in this class later to support build, 
> > if not instead of skipping class, shouldn't we remove it ?
> 
> Rakesh Gupta wrote:
> Yes, I have create separate task Jira(RANGER-4692) to handle.

Mistakenly shared another jira in above comment, the correct jira id is 
RANGER-4739.


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226290
---


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-07 Thread Rakesh Gupta



> On March 6, 2024, 6:30 a.m., Kishor Gollapalliwar wrote:
> > pom.xml
> > Lines 428 (patched)
> > 
> >
> > Are we planning to make changes in this class later to support build, 
> > if not instead of skipping class, shouldn't we remove it ?

Yes, I have create separate task Jira(RANGER-4692) to handle.


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226290
---


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-06 Thread bhavik patel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226292
---



After starting the server have checked the catalina and ranger admin login file?

- bhavik patel


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-05 Thread Kishor Gollapalliwar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226290
---




pom.xml
Lines 428 (patched)


Are we planning to make changes in this class later to support build, if 
not instead of skipping class, shouldn't we remove it ?


- Kishor Gollapalliwar


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

2024-03-05 Thread Kishor Gollapalliwar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74926/#review226288
---




plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
Line 59 (original), 62 (patched)


Will this break backword compatibility. If a older setup is using Scripts 
(compatible with Nashorm), will they need to update ?



pom.xml
Line 1007 (original), 1100 (patched)


Why we need DEBUG logging ?


- Kishor Gollapalliwar


On March 5, 2024, 7:10 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74926/
> ---
> 
> (Updated March 5, 2024, 7:10 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4076
> https://issues.apache.org/jira/browse/RANGER-4076
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently only Java 8 and 11 are supported.  Java 17 is a major LTS version 
> of Java and adding support would modernize our Java version support.
> 
> This patch enables manual and Docker-based build of Apache Ranger. It ensures 
> compatibility with Java 8, Java 11, and Java 17 for both build and runtime 
> environments.
> (I encountered a TestCase Failure in the KnoxRangerTest class, so currently I 
> had excluded that class from jdk17 build)
> 
> 
> Diffs
> -
> 
>   agents-common/pom.xml 12e093f78 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java
>  512d8d3ca 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/NashornScriptEngineCreator.java
>  db620df92 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java
>  8d76c1d81 
>   dev-support/ranger-docker/.env 60bc4a9f2 
>   dev-support/ranger-docker/Dockerfile.ranger-build 9a192f152 
>   dev-support/ranger-docker/docker-compose.ranger-build.yml 3dd4a4a06 
>   distro/src/main/assembly/admin-web.xml 245d9ca09 
>   docs/src/site/resources/index.js bb876f28d 
>   hdfs-agent/pom.xml dece8f46f 
>   kms/pom.xml 2739bb81a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 
> 7188b19b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> b6fc32950 
>   plugin-nestedstructure/pom.xml 0e208f99c 
>   
> plugin-nestedstructure/src/main/java/org/apache/ranger/authorization/nestedstructure/authorizer/RecordFilterJavaScript.java
>  77767767c 
>   
> plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/TestRecordFilterJavaScript.java
>  9cb161b8d 
>   pom.xml cec2390f2 
>   ranger-tools/pom.xml cac8d7ba3 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml fc59287d0 
> 
> 
> Diff: https://reviews.apache.org/r/74926/diff/1/
> 
> 
> Testing
> ---
> 
> This patch has been successfully tested and verified with Java versions 8, 
> 11, and 17. The verification process included both manual and Docker setup. 
> Now we are able to build and run on same jdk.
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

Re: Review Request 74926: RANGER-4076: Support Java 17 for build and runtime

18 matches

Site Navigation

Mail list logo

Footer information