Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/
---

(Updated March 10, 2024, 6:28 p.m.)


Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
Subhrat Chaudhary.


Changes
---

addressed the review comments.


Bugs: RANGER-4741
https://issues.apache.org/jira/browse/RANGER-4741


Repository: ranger


Description
---

updated Ranger Hive authorizer to get owner of a table only once per query


Diffs (updated)
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 9b25e2b8a 


Diff: https://reviews.apache.org/r/74929/diff/3/

Changes: https://reviews.apache.org/r/74929/diff/2-3/


Testing
---

- verified that the optimization results in significantly reduced time to 
authorize access to tables with large number of columns. For a table with 4000 
columns, the time taked reduced from 100 seconds to 1.5 seconds
- verified that all existing tests pass successfully


Thanks,

Madhan Neethiraj

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Kishor Gollapalliwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226311
---




hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Lines 3181 (patched)


LOG.info() ==> LOG.debug()


- Kishor Gollapalliwar


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Kishor Gollapalliwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226310
---


Ship it!




Ship It!

- Kishor Gollapalliwar


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Ramesh Mani]

> On March 9, 2024, 11:23 p.m., Ramesh Mani wrote:
> > Ship It!

Fix and Ship it.


- Ramesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226308
---


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226308
---


Ship it!




Ship It!

- Ramesh Mani


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226307
---




hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Lines 3159 (patched)


LOG.info() => Log.debug()


- Ramesh Mani


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/
---

(Updated March 8, 2024, 11:10 p.m.)


Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
Subhrat Chaudhary.


Changes
---

adressed the suggestion in review comment


Bugs: RANGER-4741
https://issues.apache.org/jira/browse/RANGER-4741


Repository: ranger


Description
---

updated Ranger Hive authorizer to get owner of a table only once per query


Diffs (updated)
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 9b25e2b8a 


Diff: https://reviews.apache.org/r/74929/diff/2/

Changes: https://reviews.apache.org/r/74929/diff/1-2/


Testing
---

- verified that the optimization results in significantly reduced time to 
authorize access to tables with large number of columns. For a table with 4000 
columns, the time taked reduced from 100 seconds to 1.5 seconds
- verified that all existing tests pass successfully


Thanks,

Madhan Neethiraj

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Asit Vadhavkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226302
---




hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Lines 3178 (patched)


Can this move to debug log ? It might flood the info log if the number of 
columns are more.


- Asit Vadhavkar


On March 7, 2024, 9:55 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 7, 2024, 9:55 a.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>