Re: Review Request 58961: reducing the highest time stamp value to pick all the users syncd during sync cycle

[Ayub Pathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58961/#review173764
---


Ship it!




Ship It!

- Ayub Pathan


On May 3, 2017, 12:50 p.m., deepak sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58961/
> ---
> 
> (Updated May 3, 2017, 12:50 p.m.)
> 
> 
> Review request for ranger and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-1475
> https://issues.apache.org/jira/browse/RANGER-1475
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> currently we increase the deltaSyncUserTimeStamp by 1 minute, in order to 
> avoid search record repetition for next sync cycle, but if there is a new 
> user added within a minute of last sync cycle then it does not sync, so 
> reducing the increament time from 1min to 1sec to avoid this issue.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
>  d65ba52 
> 
> 
> Diff: https://reviews.apache.org/r/58961/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> deepak sharma
> 
>

Re: Review Request 58961: reducing the highest time stamp value to pick all the users syncd during sync cycle

[Sailaja Polavarapu]

> On May 3, 2017, 1:19 p.m., Ayub Pathan wrote:
> > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
> > Line 550 (original), 550 (patched)
> > 
> >
> > With the current fix, search record frequency is set to 1sec. Do you 
> > think, this might impact the server as the delta sync will happen for every 
> > 1 second now, as oppossed to 1 min?
> > 
> > We need to understand the frequency where the users are added within a 
> > minute of last sync cycle. Also, the impact if the newly added user is 
> > available after 1 min delay.
> 
> Sailaja Polavarapu wrote:
> Any users added after 1 min delay will be synced in next sync cycle.

One more point to note - The change is not to the sync interval. It is just the 
timestamp to keep track on already synced users. For every sync cycle, after 
usersync syncs the users, usersync will increment the timestamp by 1sec. And 
this incremented timestamp is sent as part of the sync request for the next 
sync so that the server can send the changes after that timestamp.


- Sailaja


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58961/#review173729
---


On May 3, 2017, 12:50 p.m., deepak sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58961/
> ---
> 
> (Updated May 3, 2017, 12:50 p.m.)
> 
> 
> Review request for ranger and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-1475
> https://issues.apache.org/jira/browse/RANGER-1475
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> currently we increase the deltaSyncUserTimeStamp by 1 minute, in order to 
> avoid search record repetition for next sync cycle, but if there is a new 
> user added within a minute of last sync cycle then it does not sync, so 
> reducing the increament time from 1min to 1sec to avoid this issue.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
>  d65ba52 
> 
> 
> Diff: https://reviews.apache.org/r/58961/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> deepak sharma
> 
>

Re: Review Request 58961: reducing the highest time stamp value to pick all the users syncd during sync cycle

[Ayub Pathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58961/#review173729
---




ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
Line 550 (original), 550 (patched)


With the current fix, search record frequency is set to 1sec. Do you think, 
this might impact the server as the delta sync will happen for every 1 second 
now, as oppossed to 1 min?

We need to understand the frequency where the users are added within a 
minute of last sync cycle. Also, the impact if the newly added user is 
available after 1 min delay.


- Ayub Pathan


On May 3, 2017, 12:50 p.m., deepak sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58961/
> ---
> 
> (Updated May 3, 2017, 12:50 p.m.)
> 
> 
> Review request for ranger and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-1475
> https://issues.apache.org/jira/browse/RANGER-1475
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> currently we increase the deltaSyncUserTimeStamp by 1 minute, in order to 
> avoid search record repetition for next sync cycle, but if there is a new 
> user added within a minute of last sync cycle then it does not sync, so 
> reducing the increament time from 1min to 1sec to avoid this issue.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
>  d65ba52 
> 
> 
> Diff: https://reviews.apache.org/r/58961/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> deepak sharma
> 
>

Review Request 58961: reducing the highest time stamp value to pick all the users syncd during sync cycle

[deepak sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58961/
---

Review request for ranger and Sailaja Polavarapu.


Bugs: RANGER-1475
https://issues.apache.org/jira/browse/RANGER-1475


Repository: ranger


Description
---

currently we increase the deltaSyncUserTimeStamp by 1 minute, in order to avoid 
search record repetition for next sync cycle, but if there is a new user added 
within a minute of last sync cycle then it does not sync, so reducing the 
increament time from 1min to 1sec to avoid this issue.


Diffs
-

  
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
 d65ba52 


Diff: https://reviews.apache.org/r/58961/diff/1/


Testing
---


Thanks,

deepak sharma