Re: Review Request 59227: RANGER-1576: Show attribute values to tags column in audit log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59227/#review174884 --- Ship it! Ship It! - Gautam Borad On May 12, 2017, 12:02 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59227/ > --- > > (Updated May 12, 2017, 12:02 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and > Velmurugan Periasamy. > > > Bugs: RANGER-1576 > https://issues.apache.org/jira/browse/RANGER-1576 > > > Repository: ranger > > > Description > --- > > Currently in the access audit log record (Audit Menu-> admin tab), the tags > column is populated when the accessed resource has any tags associated with > it. > However, if the tag has any attributes, their values are not shown in the > audit log record. As authorization decision may be based on the > attribute-value(s) as well as tag-type (such as in the case of expiry_date > attribute’s value for EXPIRES_ON tag-type), they too need to be populated and > displayed on audit log record. > > > Diffs > - > > security-admin/src/main/webapp/scripts/utils/XAUtils.js > 08aa95acc14d0b3e2e73b3b9ef8d9406af4f980f > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js > b98e2cc96cfe4b683ac2929546e1951633c1bb94 > security-admin/src/main/webapp/styles/xa.css > 06ef1d0b4b74717c6c4723a18b4ac7a53dcc7079 > > > Diff: https://reviews.apache.org/r/59227/diff/1/ > > > Testing > --- > > Tested that on the Audits page, all records that has tag attributes are shown > as hyper link and on clicking on these the attritubes are shown. > > > Thanks, > > Gautam Borad > >
Re: Review Request 59227: RANGER-1576: Show attribute values to tags column in audit log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59227/#review174782 --- Ship it! Ship It! - Velmurugan Periasamy On May 12, 2017, 12:02 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59227/ > --- > > (Updated May 12, 2017, 12:02 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and > Velmurugan Periasamy. > > > Bugs: RANGER-1576 > https://issues.apache.org/jira/browse/RANGER-1576 > > > Repository: ranger > > > Description > --- > > Currently in the access audit log record (Audit Menu-> admin tab), the tags > column is populated when the accessed resource has any tags associated with > it. > However, if the tag has any attributes, their values are not shown in the > audit log record. As authorization decision may be based on the > attribute-value(s) as well as tag-type (such as in the case of expiry_date > attribute’s value for EXPIRES_ON tag-type), they too need to be populated and > displayed on audit log record. > > > Diffs > - > > security-admin/src/main/webapp/scripts/utils/XAUtils.js > 08aa95acc14d0b3e2e73b3b9ef8d9406af4f980f > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js > b98e2cc96cfe4b683ac2929546e1951633c1bb94 > security-admin/src/main/webapp/styles/xa.css > 06ef1d0b4b74717c6c4723a18b4ac7a53dcc7079 > > > Diff: https://reviews.apache.org/r/59227/diff/1/ > > > Testing > --- > > Tested that on the Audits page, all records that has tag attributes are shown > as hyper link and on clicking on these the attritubes are shown. > > > Thanks, > > Gautam Borad > >
Review Request 59227: RANGER-1576: Show attribute values to tags column in audit log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59227/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-1576 https://issues.apache.org/jira/browse/RANGER-1576 Repository: ranger Description --- Currently in the access audit log record (Audit Menu-> admin tab), the tags column is populated when the accessed resource has any tags associated with it. However, if the tag has any attributes, their values are not shown in the audit log record. As authorization decision may be based on the attribute-value(s) as well as tag-type (such as in the case of expiry_date attribute’s value for EXPIRES_ON tag-type), they too need to be populated and displayed on audit log record. Diffs - security-admin/src/main/webapp/scripts/utils/XAUtils.js 08aa95acc14d0b3e2e73b3b9ef8d9406af4f980f security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b98e2cc96cfe4b683ac2929546e1951633c1bb94 security-admin/src/main/webapp/styles/xa.css 06ef1d0b4b74717c6c4723a18b4ac7a53dcc7079 Diff: https://reviews.apache.org/r/59227/diff/1/ Testing --- Tested that on the Audits page, all records that has tag attributes are shown as hyper link and on clicking on these the attritubes are shown. Thanks, Gautam Borad
