Re: Review Request 62567: RANGER-1727 : Ranger allows user to change an external user's password with 'null' old password

2017-09-27 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62567/#review186450
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 26, 2017, 11:56 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62567/
> ---
> 
> (Updated Sept. 26, 2017, 11:56 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
> Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1727
> https://issues.apache.org/jira/browse/RANGER-1727
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger allows user to change an external user's password with 'null' old 
> password
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java cc81029 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 447aebb 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 
> d0fb3dc 
> 
> 
> Diff: https://reviews.apache.org/r/62567/diff/1/
> 
> 
> Testing
> ---
> 
> 1.External user is not able to change the password using ranger Api's (same 
> as ui).
> 2.Verified all the existing unit tests are passing.
> 3.Verified password change feature for internal users.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>



Re: Review Request 62567: RANGER-1727 : Ranger allows user to change an external user's password with 'null' old password

2017-09-27 Thread Velmurugan Periasamy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62567/#review186417
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 26, 2017, 11:56 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62567/
> ---
> 
> (Updated Sept. 26, 2017, 11:56 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
> Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1727
> https://issues.apache.org/jira/browse/RANGER-1727
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger allows user to change an external user's password with 'null' old 
> password
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java cc81029 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 447aebb 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 
> d0fb3dc 
> 
> 
> Diff: https://reviews.apache.org/r/62567/diff/1/
> 
> 
> Testing
> ---
> 
> 1.External user is not able to change the password using ranger Api's (same 
> as ui).
> 2.Verified all the existing unit tests are passing.
> 3.Verified password change feature for internal users.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>



Review Request 62567: RANGER-1727 : Ranger allows user to change an external user's password with 'null' old password

2017-09-26 Thread Fatima Khan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62567/
---

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1727
https://issues.apache.org/jira/browse/RANGER-1727


Repository: ranger


Description
---

Ranger allows user to change an external user's password with 'null' old 
password


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java cc81029 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 447aebb 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java d0fb3dc 


Diff: https://reviews.apache.org/r/62567/diff/1/


Testing
---

1.External user is not able to change the password using ranger Api's (same as 
ui).
2.Verified all the existing unit tests are passing.
3.Verified password change feature for internal users.


Thanks,

Fatima Khan