Re: Review Request 63405: RANGER-1864: Resources are not rendering correctly in policy create/edit page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63405/#review189690 --- Ship it! Ship It! - Gautam Borad On Oct. 30, 2017, 12:56 p.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63405/ > --- > > (Updated Oct. 30, 2017, 12:56 p.m.) > > > Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, and > Velmurugan Periasamy. > > > Bugs: RANGER-1864 > https://issues.apache.org/jira/browse/RANGER-1864 > > > Repository: ranger > > > Description > --- > > UI not rendering correctly if we provide resources at the same level with > different parent resources in the service definitions. > Looks like Ranger UI uses only levels in the service definitions' resource > property. It should use level as well as parent check to render resources > level hierarchies. > > > Diffs > - > > security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js > 3f8697e > > > Diff: https://reviews.apache.org/r/63405/diff/1/ > > > Testing > --- > > Tested above scenario and also visited exisitng policy pages. > > > Thanks, > > Nitin Galave > >
Re: Review Request 63405: RANGER-1864: Resources are not rendering correctly in policy create/edit page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63405/#review189634 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 30, 2017, 12:56 p.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63405/ > --- > > (Updated Oct. 30, 2017, 12:56 p.m.) > > > Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, and > Velmurugan Periasamy. > > > Bugs: RANGER-1864 > https://issues.apache.org/jira/browse/RANGER-1864 > > > Repository: ranger > > > Description > --- > > UI not rendering correctly if we provide resources at the same level with > different parent resources in the service definitions. > Looks like Ranger UI uses only levels in the service definitions' resource > property. It should use level as well as parent check to render resources > level hierarchies. > > > Diffs > - > > security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js > 3f8697e > > > Diff: https://reviews.apache.org/r/63405/diff/1/ > > > Testing > --- > > Tested above scenario and also visited exisitng policy pages. > > > Thanks, > > Nitin Galave > >
Review Request 63405: RANGER-1864: Resources are not rendering correctly in policy create/edit page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63405/ --- Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy. Bugs: RANGER-1864 https://issues.apache.org/jira/browse/RANGER-1864 Repository: ranger Description --- UI not rendering correctly if we provide resources at the same level with different parent resources in the service definitions. Looks like Ranger UI uses only levels in the service definitions' resource property. It should use level as well as parent check to render resources level hierarchies. Diffs - security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js 3f8697e Diff: https://reviews.apache.org/r/63405/diff/1/ Testing --- Tested above scenario and also visited exisitng policy pages. Thanks, Nitin Galave
