Re: Review Request 63659: The exception infomation print error for RangerPolicyServiceBase.java

2017-12-25 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63659/#review194502
---


Ship it!




Ship It!

- pengjianhua


On 十一月 8, 2017, 8:29 a.m., wang yuan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63659/
> ---
> 
> (Updated 十一月 8, 2017, 8:29 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1878
> https://issues.apache.org/jira/browse/RANGER-1878
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The exception infomation print error for RangerPolicyServiceBase.java?
> 
> {code:title=RangerPolicyServiceBase.java|borderStyle=solid}
> 
> @Override
>   protected T mapViewToEntityBean(V vObj, T xObj, int OPERATION_CONTEXT) {
>   ... ..
>   XXService xService = 
> daoMgr.getXXService().findByName(vObj.getService());
>   if (xService == null) {
>   throw restErrorUtil.createRESTException("No 
> corresponding service found for policyName: " + vObj.getName()
>   + "Service Not Found : " + 
> vObj.getName(), MessageEnums.INVALID_INPUT_DATA);
>... ...
>//should be:"Service Not Found : " + vObj.getService(), 
>   }
> {code}
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
>  0195c72a 
> 
> 
> Diff: https://reviews.apache.org/r/63659/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> wang yuan
> 
>



Review Request 63659: The exception infomation print error for RangerPolicyServiceBase.java

2017-11-08 Thread wang yuan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63659/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1878
https://issues.apache.org/jira/browse/RANGER-1878


Repository: ranger


Description
---

The exception infomation print error for RangerPolicyServiceBase.java?

{code:title=RangerPolicyServiceBase.java|borderStyle=solid}

@Override
protected T mapViewToEntityBean(V vObj, T xObj, int OPERATION_CONTEXT) {
... ..
XXService xService = 
daoMgr.getXXService().findByName(vObj.getService());
if (xService == null) {
throw restErrorUtil.createRESTException("No 
corresponding service found for policyName: " + vObj.getName()
+ "Service Not Found : " + 
vObj.getName(), MessageEnums.INVALID_INPUT_DATA);
   ... ...
   //should be:"Service Not Found : " + vObj.getService(), 
}
{code}


Diffs
-

  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
 0195c72a 


Diff: https://reviews.apache.org/r/63659/diff/1/


Testing
---


Thanks,

wang yuan