Re: Review Request 64375: RANGER-1917 - Remove solr dependency from Kafka + Sqoop modules

2017-12-06 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64375/#review193084
---


Ship it!




Ship It!

- Ramesh Mani


On Dec. 6, 2017, 12:37 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64375/
> ---
> 
> (Updated Dec. 6, 2017, 12:37 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1917
> https://issues.apache.org/jira/browse/RANGER-1917
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to remove the solr dependency from the Kafka + Sqoop modules, as 
> it is picked up on the classpath from the audit module instead. No changes to 
> the distribution jars - also tested Solr auditing as a sanity test for both.
> 
> 
> Diffs
> -
> 
>   plugin-kafka/pom.xml 3a8a1d37 
>   plugin-sqoop/pom.xml 58d10a44 
> 
> 
> Diff: https://reviews.apache.org/r/64375/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Solr auditing works correctly.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 64375: RANGER-1917 - Remove solr dependency from Kafka + Sqoop modules

2017-12-06 Thread Qiang Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64375/#review193075
---


Ship it!




Ship It!

- Qiang Zhang


On Dec. 6, 2017, 12:37 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64375/
> ---
> 
> (Updated Dec. 6, 2017, 12:37 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1917
> https://issues.apache.org/jira/browse/RANGER-1917
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to remove the solr dependency from the Kafka + Sqoop modules, as 
> it is picked up on the classpath from the audit module instead. No changes to 
> the distribution jars - also tested Solr auditing as a sanity test for both.
> 
> 
> Diffs
> -
> 
>   plugin-kafka/pom.xml 3a8a1d37 
>   plugin-sqoop/pom.xml 58d10a44 
> 
> 
> Diff: https://reviews.apache.org/r/64375/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Solr auditing works correctly.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 64375: RANGER-1917 - Remove solr dependency from Kafka + Sqoop modules

2017-12-06 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64375/#review193069
---


Ship it!




Ship It!

- pengjianhua


On 十二月 6, 2017, 12:37 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64375/
> ---
> 
> (Updated 十二月 6, 2017, 12:37 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1917
> https://issues.apache.org/jira/browse/RANGER-1917
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to remove the solr dependency from the Kafka + Sqoop modules, as 
> it is picked up on the classpath from the audit module instead. No changes to 
> the distribution jars - also tested Solr auditing as a sanity test for both.
> 
> 
> Diffs
> -
> 
>   plugin-kafka/pom.xml 3a8a1d37 
>   plugin-sqoop/pom.xml 58d10a44 
> 
> 
> Diff: https://reviews.apache.org/r/64375/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Solr auditing works correctly.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Review Request 64375: RANGER-1917 - Remove solr dependency from Kafka + Sqoop modules

2017-12-06 Thread Colm O hEigeartaigh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64375/
---

Review request for ranger.


Bugs: RANGER-1917
https://issues.apache.org/jira/browse/RANGER-1917


Repository: ranger


Description
---

This task is to remove the solr dependency from the Kafka + Sqoop modules, as 
it is picked up on the classpath from the audit module instead. No changes to 
the distribution jars - also tested Solr auditing as a sanity test for both.


Diffs
-

  plugin-kafka/pom.xml 3a8a1d37 
  plugin-sqoop/pom.xml 58d10a44 


Diff: https://reviews.apache.org/r/64375/diff/1/


Testing
---

Tested Solr auditing works correctly.


Thanks,

Colm O hEigeartaigh