Re: Review Request 64862: RANGER-1944: Action filter for Admin Audit is not working

2018-01-04 Thread Gautam Borad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64862/#review194746
---


Ship it!




Ship It!

- Gautam Borad


On Jan. 2, 2018, 5:35 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64862/
> ---
> 
> (Updated Jan. 2, 2018, 5:35 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-1944
> https://issues.apache.org/jira/browse/RANGER-1944
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Action filter for Admin Audit is not working for Oracle database.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/utils/XAGlobals.js d16e5de 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 76a8aa5 
> 
> 
> Diff: https://reviews.apache.org/r/64862/diff/2/
> 
> 
> Testing
> ---
> 
> Action filter is working fine for all database flavour (mysql/oracle) and 
> also revisited other filter options.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Re: Review Request 64862: RANGER-1944: Action filter for Admin Audit is not working

2018-01-01 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64862/
---

(Updated Jan. 2, 2018, 5:35 a.m.)


Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.


Changes
---

Moved action list to global file instead of enum file.


Bugs: RANGER-1944
https://issues.apache.org/jira/browse/RANGER-1944


Repository: ranger


Description
---

Action filter for Admin Audit is not working for Oracle database.


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/utils/XAGlobals.js d16e5de 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 76a8aa5 


Diff: https://reviews.apache.org/r/64862/diff/2/

Changes: https://reviews.apache.org/r/64862/diff/1-2/


Testing
---

Action filter is working fine for all database flavour (mysql/oracle) and also 
revisited other filter options.


Thanks,

Nitin Galave



Re: Review Request 64862: RANGER-1944: Action filter for Admin Audit is not working

2017-12-28 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64862/#review194576
---


Ship it!




Ship It!

- Mehul Parikh


On Dec. 28, 2017, 12:32 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64862/
> ---
> 
> (Updated Dec. 28, 2017, 12:32 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-1944
> https://issues.apache.org/jira/browse/RANGER-1944
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Action filter for Admin Audit is not working for Oracle database.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 76a8aa5 
> 
> 
> Diff: https://reviews.apache.org/r/64862/diff/1/
> 
> 
> Testing
> ---
> 
> Action filter is working fine for all database flavour (mysql/oracle) and 
> also revisited other filter options.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Re: Review Request 64862: RANGER-1944: Action filter for Admin Audit is not working

2017-12-28 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64862/
---

(Updated Dec. 28, 2017, 12:32 p.m.)


Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-1944
https://issues.apache.org/jira/browse/RANGER-1944


Repository: ranger


Description
---

Action filter for Admin Audit is not working for Oracle database.


Diffs
-

  security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 76a8aa5 


Diff: https://reviews.apache.org/r/64862/diff/1/


Testing (updated)
---

Action filter is working fine for all database flavour (mysql/oracle) and also 
revisited other filter options.


Thanks,

Nitin Galave



Review Request 64862: RANGER-1944: Action filter for Admin Audit is not working

2017-12-28 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64862/
---

Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-1944
https://issues.apache.org/jira/browse/RANGER-1944


Repository: ranger


Description
---

Action filter for Admin Audit is not working for Oracle database.


Diffs
-

  security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 76a8aa5 


Diff: https://reviews.apache.org/r/64862/diff/1/


Testing
---

Action filter is working fine for all database flavour (mysql/oracle) and 
revisited other filter options.


Thanks,

Nitin Galave