Re: Review Request 65387: RANGER-1965 - Prevent NPE on decrypting a null password
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65387/#review196506 --- Ship it! Ship It! - pengjianhua On 一月 29, 2018, 4:19 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65387/ > --- > > (Updated 一月 29, 2018, 4:19 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1965 > https://issues.apache.org/jira/browse/RANGER-1965 > > > Repository: ranger > > > Description > --- > > If no password is specified, the logs show a NPE: > > java.lang.NullPointerException > at com.sun.jersey.core.util.Base64.decode(Base64.java:324) > at > org.apache.ranger.plugin.util.PasswordUtils.decrypt(PasswordUtils.java:126) > at > org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:120) > at org.apache.ranger.plugin.client.BaseClient.login(BaseClient.java:108) > at org.apache.ranger.plugin.client.BaseClient.(BaseClient.java:61) > at > org.apache.ranger.services.sqoop.client.SqoopClient.(SqoopClient.java:74) > at > org.apache.ranger.services.sqoop.client.SqoopClient.getSqoopClient(SqoopClient.java:357) > at > org.apache.ranger.services.sqoop.client.SqoopClient.connectionTest(SqoopClient.java:321) > > Instead, we should only try to decrypt the password if it's not null. > > > Diffs > - > > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > cb170c2c > > > Diff: https://reviews.apache.org/r/65387/diff/1/ > > > Testing > --- > > > Thanks, > > Colm O hEigeartaigh > >
Re: Review Request 65387: RANGER-1965 - Prevent NPE on decrypting a null password
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65387/#review196505 --- Ship it! Ship It! - Qiang Zhang On 一月 29, 2018, 4:19 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65387/ > --- > > (Updated 一月 29, 2018, 4:19 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1965 > https://issues.apache.org/jira/browse/RANGER-1965 > > > Repository: ranger > > > Description > --- > > If no password is specified, the logs show a NPE: > > java.lang.NullPointerException > at com.sun.jersey.core.util.Base64.decode(Base64.java:324) > at > org.apache.ranger.plugin.util.PasswordUtils.decrypt(PasswordUtils.java:126) > at > org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:120) > at org.apache.ranger.plugin.client.BaseClient.login(BaseClient.java:108) > at org.apache.ranger.plugin.client.BaseClient.(BaseClient.java:61) > at > org.apache.ranger.services.sqoop.client.SqoopClient.(SqoopClient.java:74) > at > org.apache.ranger.services.sqoop.client.SqoopClient.getSqoopClient(SqoopClient.java:357) > at > org.apache.ranger.services.sqoop.client.SqoopClient.connectionTest(SqoopClient.java:321) > > Instead, we should only try to decrypt the password if it's not null. > > > Diffs > - > > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > cb170c2c > > > Diff: https://reviews.apache.org/r/65387/diff/1/ > > > Testing > --- > > > Thanks, > > Colm O hEigeartaigh > >
Re: Review Request 65387: RANGER-1965 - Prevent NPE on decrypting a null password
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65387/#review196436 --- Ship it! Ship It! - Ramesh Mani On Jan. 29, 2018, 4:19 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65387/ > --- > > (Updated Jan. 29, 2018, 4:19 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1965 > https://issues.apache.org/jira/browse/RANGER-1965 > > > Repository: ranger > > > Description > --- > > If no password is specified, the logs show a NPE: > > java.lang.NullPointerException > at com.sun.jersey.core.util.Base64.decode(Base64.java:324) > at > org.apache.ranger.plugin.util.PasswordUtils.decrypt(PasswordUtils.java:126) > at > org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:120) > at org.apache.ranger.plugin.client.BaseClient.login(BaseClient.java:108) > at org.apache.ranger.plugin.client.BaseClient.(BaseClient.java:61) > at > org.apache.ranger.services.sqoop.client.SqoopClient.(SqoopClient.java:74) > at > org.apache.ranger.services.sqoop.client.SqoopClient.getSqoopClient(SqoopClient.java:357) > at > org.apache.ranger.services.sqoop.client.SqoopClient.connectionTest(SqoopClient.java:321) > > Instead, we should only try to decrypt the password if it's not null. > > > Diffs > - > > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > cb170c2c > > > Diff: https://reviews.apache.org/r/65387/diff/1/ > > > Testing > --- > > > Thanks, > > Colm O hEigeartaigh > >
Review Request 65387: RANGER-1965 - Prevent NPE on decrypting a null password
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65387/ --- Review request for ranger. Bugs: RANGER-1965 https://issues.apache.org/jira/browse/RANGER-1965 Repository: ranger Description --- If no password is specified, the logs show a NPE: java.lang.NullPointerException at com.sun.jersey.core.util.Base64.decode(Base64.java:324) at org.apache.ranger.plugin.util.PasswordUtils.decrypt(PasswordUtils.java:126) at org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:120) at org.apache.ranger.plugin.client.BaseClient.login(BaseClient.java:108) at org.apache.ranger.plugin.client.BaseClient.(BaseClient.java:61) at org.apache.ranger.services.sqoop.client.SqoopClient.(SqoopClient.java:74) at org.apache.ranger.services.sqoop.client.SqoopClient.getSqoopClient(SqoopClient.java:357) at org.apache.ranger.services.sqoop.client.SqoopClient.connectionTest(SqoopClient.java:321) Instead, we should only try to decrypt the password if it's not null. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java cb170c2c Diff: https://reviews.apache.org/r/65387/diff/1/ Testing --- Thanks, Colm O hEigeartaigh
