Re: Review Request 65924: RANGER-2011: Level 20 resource value is not set on UI in Ranger Edit Policy.

2018-03-06 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65924/#review198763
---


Ship it!




Ship It!

- Mehul Parikh


On March 6, 2018, 2:08 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65924/
> ---
> 
> (Updated March 6, 2018, 2:08 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Nixon Rodrigues, 
> Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2011
> https://issues.apache.org/jira/browse/RANGER-2011
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Service definitions resource Level 20 value is not set on UI in Ranger Edit 
> Policy.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js 
> 5c06ad9 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> c4eef7a 
>   
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html
>  fec2535 
> 
> 
> Diff: https://reviews.apache.org/r/65924/diff/1/
> 
> 
> Testing
> ---
> 
> Tested :
> 1.By changing the parent and child resources.
> 2.By adding/atlering restricted access types for the resources.
> 3.By adding/altering new access types for the resources.
> 4.By adding new child level resources.
> 5.Tested that the old policy are not affected.
> 6.Tested that access types changes based on resources.
> And also verified policy CRUD for all specified scenario.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Re: Review Request 65924: RANGER-2011: Level 20 resource value is not set on UI in Ranger Edit Policy.

2018-03-06 Thread Velmurugan Periasamy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65924/#review198700
---


Ship it!




Ship It!

- Velmurugan Periasamy


On March 6, 2018, 2:08 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65924/
> ---
> 
> (Updated March 6, 2018, 2:08 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Nixon Rodrigues, 
> Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2011
> https://issues.apache.org/jira/browse/RANGER-2011
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Service definitions resource Level 20 value is not set on UI in Ranger Edit 
> Policy.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js 
> 5c06ad9 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> c4eef7a 
>   
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html
>  fec2535 
> 
> 
> Diff: https://reviews.apache.org/r/65924/diff/1/
> 
> 
> Testing
> ---
> 
> Tested :
> 1.By changing the parent and child resources.
> 2.By adding/atlering restricted access types for the resources.
> 3.By adding/altering new access types for the resources.
> 4.By adding new child level resources.
> 5.Tested that the old policy are not affected.
> 6.Tested that access types changes based on resources.
> And also verified policy CRUD for all specified scenario.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Review Request 65924: RANGER-2011: Level 20 resource value is not set on UI in Ranger Edit Policy.

2018-03-06 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65924/
---

Review request for ranger, Gautam Borad, Mehul Parikh, Nixon Rodrigues, Pradeep 
Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2011
https://issues.apache.org/jira/browse/RANGER-2011


Repository: ranger


Description
---

Service definitions resource Level 20 value is not set on UI in Ranger Edit 
Policy.


Diffs
-

  security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js 5c06ad9 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
c4eef7a 
  
security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html 
fec2535 


Diff: https://reviews.apache.org/r/65924/diff/1/


Testing
---

Tested :
1.By changing the parent and child resources.
2.By adding/atlering restricted access types for the resources.
3.By adding/altering new access types for the resources.
4.By adding new child level resources.
5.Tested that the old policy are not affected.
6.Tested that access types changes based on resources.
And also verified policy CRUD for all specified scenario.


Thanks,

Nitin Galave