Re: Review Request 66298: Fix execute sql failure in db_setup.py file of the admin.

2018-03-28 Thread Qiang Zhang 


> On March 27, 2018, 9:03 a.m., Zsombor Gegesy wrote:
> > security-admin/scripts/db_setup.py
> > Line 83 (original), 77 (patched)
> > 
> >
> > Any reason not to remove the whole line ? Commented out code seems 
> > scary/unfinished
> 
> Qiang Zhang wrote:
> The library_path variable was not used. So the whole line is a redundant 
> and invalid line.
> 
> Zsombor Gegesy wrote:
> So you can remove it, if I understand you correctly

Ok. Thanks!


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66298/#review200038
---


On March 27, 2018, 6:37 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66298/
> ---
> 
> (Updated March 27, 2018, 6:37 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2044
> https://issues.apache.org/jira/browse/RANGER-2044
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix execute sql failure in db_setup.py file.
> The reason is that the contributors copied the code and did not modify the 
> related variables.
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/db_setup.py 1689e5d 
> 
> 
> Diff: https://reviews.apache.org/r/66298/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 66298: Fix execute sql failure in db_setup.py file of the admin.

2018-03-28 Thread Zsombor Gegesy 


> On March 27, 2018, 9:03 a.m., Zsombor Gegesy wrote:
> > security-admin/scripts/db_setup.py
> > Line 83 (original), 77 (patched)
> > 
> >
> > Any reason not to remove the whole line ? Commented out code seems 
> > scary/unfinished
> 
> Qiang Zhang wrote:
> The library_path variable was not used. So the whole line is a redundant 
> and invalid line.

So you can remove it, if I understand you correctly


- Zsombor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66298/#review200038
---


On March 27, 2018, 6:37 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66298/
> ---
> 
> (Updated March 27, 2018, 6:37 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2044
> https://issues.apache.org/jira/browse/RANGER-2044
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix execute sql failure in db_setup.py file.
> The reason is that the contributors copied the code and did not modify the 
> related variables.
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/db_setup.py 1689e5d 
> 
> 
> Diff: https://reviews.apache.org/r/66298/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 66298: Fix execute sql failure in db_setup.py file of the admin.

2018-03-27 Thread Qiang Zhang 


> On March 27, 2018, 9:03 a.m., Zsombor Gegesy wrote:
> > security-admin/scripts/db_setup.py
> > Line 83 (original), 77 (patched)
> > 
> >
> > Any reason not to remove the whole line ? Commented out code seems 
> > scary/unfinished

The library_path variable was not used. So the whole line is a redundant and 
invalid line.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66298/#review200038
---


On March 27, 2018, 6:37 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66298/
> ---
> 
> (Updated March 27, 2018, 6:37 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2044
> https://issues.apache.org/jira/browse/RANGER-2044
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix execute sql failure in db_setup.py file.
> The reason is that the contributors copied the code and did not modify the 
> related variables.
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/db_setup.py 1689e5d 
> 
> 
> Diff: https://reviews.apache.org/r/66298/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 66298: Fix execute sql failure in db_setup.py file of the admin.

2018-03-27 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66298/#review200038
---




security-admin/scripts/db_setup.py
Line 83 (original), 77 (patched)


Any reason not to remove the whole line ? Commented out code seems 
scary/unfinished


- Zsombor Gegesy


On March 27, 2018, 6:37 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66298/
> ---
> 
> (Updated March 27, 2018, 6:37 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2044
> https://issues.apache.org/jira/browse/RANGER-2044
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix execute sql failure in db_setup.py file.
> The reason is that the contributors copied the code and did not modify the 
> related variables.
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/db_setup.py 1689e5d 
> 
> 
> Diff: https://reviews.apache.org/r/66298/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 66298: Fix execute sql failure in db_setup.py file of the admin.

2018-03-27 Thread pengjianhua 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66298/#review200032
---


Ship it!




Ship It!

- pengjianhua


On 三月 27, 2018, 6:37 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66298/
> ---
> 
> (Updated 三月 27, 2018, 6:37 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2044
> https://issues.apache.org/jira/browse/RANGER-2044
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix execute sql failure in db_setup.py file.
> The reason is that the contributors copied the code and did not modify the 
> related variables.
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/db_setup.py 1689e5d 
> 
> 
> Diff: https://reviews.apache.org/r/66298/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Review Request 66298: Fix execute sql failure in db_setup.py file of the admin.

2018-03-26 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66298/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, 
sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Bugs: RANGER-2044
https://issues.apache.org/jira/browse/RANGER-2044


Repository: ranger


Description
---

Fix execute sql failure in db_setup.py file.
The reason is that the contributors copied the code and did not modify the 
related variables.


Diffs
-

  security-admin/scripts/db_setup.py 1689e5d 


Diff: https://reviews.apache.org/r/66298/diff/1/


Testing
---


Thanks,

Qiang Zhang