Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201394
---


Ship it!




Ship It!

- Ramesh Mani


On April 18, 2018, 6:05 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 18, 2018, 6:05 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
>   kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java
>  PRE-CREATION 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java
>  PRE-CREATION 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/5/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201391
---


Ship it!




Ship It!

- Qiang Zhang


On April 18, 2018, 6:05 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 18, 2018, 6:05 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
>   kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java
>  PRE-CREATION 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java
>  PRE-CREATION 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/5/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread pengjianhua 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201392
---


Ship it!




Ship It!

- pengjianhua


On 四月 18, 2018, 6:05 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated 四月 18, 2018, 6:05 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
>   kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java
>  PRE-CREATION 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java
>  PRE-CREATION 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/5/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread bhavik patel 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/
---

(Updated April 18, 2018, 6:05 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
---

added missing file.


Bugs: RANGER-2043
https://issues.apache.org/jira/browse/RANGER-2043


Repository: ranger


Description
---

Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.


Diffs (updated)
-

  kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
  kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
b9d948f 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 
PRE-CREATION 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java 
PRE-CREATION 
  src/main/assembly/kms.xml 68512ef 


Diff: https://reviews.apache.org/r/66598/diff/5/

Changes: https://reviews.apache.org/r/66598/diff/4-5/


Testing
---

1. Verified Ranger Kms is working as expected.


Thanks,

bhavik patel

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread bhavik patel 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/
---

(Updated April 18, 2018, 5:50 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2043
https://issues.apache.org/jira/browse/RANGER-2043


Repository: ranger


Description
---

Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.


Diffs (updated)
-

  kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
  kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
b9d948f 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 
PRE-CREATION 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66598/diff/4/

Changes: https://reviews.apache.org/r/66598/diff/3-4/


Testing
---

1. Verified Ranger Kms is working as expected.


Thanks,

bhavik patel

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201388
---



These warning still exist. You should update the error patch.  Please update 
the patch again.

- Qiang Zhang


On April 18, 2018, 4:06 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 18, 2018, 4:06 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
>   kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java
>  PRE-CREATION 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/3/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread bhavik patel 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/
---

(Updated April 18, 2018, 4:06 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2043
https://issues.apache.org/jira/browse/RANGER-2043


Repository: ranger


Description
---

Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.


Diffs (updated)
-

  kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
  kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
b9d948f 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 
PRE-CREATION 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66598/diff/3/

Changes: https://reviews.apache.org/r/66598/diff/2-3/


Testing
---

1. Verified Ranger Kms is working as expected.


Thanks,

bhavik patel

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201376
---



Please fix warning message.
Applying: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have 
more debug logs
.git/rebase-apply/patch:109: space before tab in indent.
if (logger.isDebugEnabled()) {
.git/rebase-apply/patch:110: space before tab in indent.
logger.debug("==> RangerKeyStore.engineGetKey()");
.git/rebase-apply/patch:111: space before tab in indent.
}
.git/rebase-apply/patch:131: space before tab in indent.
if (logger.isDebugEnabled()) {
.git/rebase-apply/patch:132: space before tab in indent.
logger.debug("==> RangerKeyStore.addKeyEntry()");
warning: squelched 67 whitespace errors
warning: 72 lines add whitespace errors.

- Qiang Zhang


On April 16, 2018, 5:57 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 16, 2018, 5:57 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
>   kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java
>  PRE-CREATION 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java
>  PRE-CREATION 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201328
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 16, 2018, 5:57 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 16, 2018, 5:57 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
>   kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java
>  PRE-CREATION 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java
>  PRE-CREATION 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-15 Thread bhavik patel 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/
---

(Updated April 16, 2018, 5:57 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2043
https://issues.apache.org/jira/browse/RANGER-2043


Repository: ranger


Description
---

Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.


Diffs (updated)
-

  kms/scripts/VerifyIsDBMasterkeyCorrect.sh PRE-CREATION 
  kms/scripts/VerifyIsHSMMasterkeyCorrect.sh PRE-CREATION 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
b9d948f 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 
PRE-CREATION 
  
kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java 
PRE-CREATION 
  src/main/assembly/kms.xml 68512ef 


Diff: https://reviews.apache.org/r/66598/diff/2/

Changes: https://reviews.apache.org/r/66598/diff/1-2/


Testing
---

1. Verified Ranger Kms is working as expected.


Thanks,

bhavik patel

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201089
---




kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java
Lines 151 (patched)


I feel only debug message is need not Info.



kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java
Lines 370 (patched)


Do we need to Info level logs? We don't a log of Info logs, debug logs are 
fine.
basically we want to avoid lot of info messages for KMS when you need debug 
we can put.



kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java
Lines 408 (patched)


please consider doing 
logger.error("Keystore was tampered with, or password was incorrect.", 
t.getMessage());
for getting the entire stack trace into the kms.log file. Please review all 
the occurance like this where + e.getMessage() is used



kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java
Line 452 (original), 471 (patched)


do we need to do this printStackTraces? Just leave in log file. Also do 
Logger.error("==>RangerKeyStore.dbOperationLoad() error, e);



kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java
Lines 212 (patched)


Do we need the info level log for the all the decrypts done?


- Ramesh Mani


On April 13, 2018, 5:14 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 13, 2018, 5:14 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread Qiang Zhang 


> On April 13, 2018, 5:28 a.m., Qiang Zhang wrote:
> > Added logs will reduce program performance.
> 
> bhavik patel wrote:
> Currently if we get any error message then it will be very difficult to 
> debug so it will be helpful to debug the code at the time of any error.

if(logger.isDebugEnabled()) {
logger.debug("“);
}
You can add the above code segment.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201086
---


On April 13, 2018, 5:14 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 13, 2018, 5:14 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread bhavik patel 


> On April 13, 2018, 5:28 a.m., Qiang Zhang wrote:
> > Added logs will reduce program performance.

Currently if we get any error message then it will be very difficult to debug 
so it will be helpful to debug the code at the time of any error.


- bhavik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201086
---


On April 13, 2018, 5:14 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 13, 2018, 5:14 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/#review201086
---



Added logs will reduce program performance.

- Qiang Zhang


On April 13, 2018, 5:14 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66598/
> ---
> 
> (Updated April 13, 2018, 5:14 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2043
> https://issues.apache.org/jira/browse/RANGER-2043
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> b9d948f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
>   src/main/assembly/kms.xml 68512ef 
> 
> 
> Diff: https://reviews.apache.org/r/66598/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread bhavik patel 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66598/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2043
https://issues.apache.org/jira/browse/RANGER-2043


Repository: ranger


Description
---

Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs.


Diffs
-

  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 00dc069 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java e73b6d3 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
b9d948f 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 6cfd37e 
  src/main/assembly/kms.xml 68512ef 


Diff: https://reviews.apache.org/r/66598/diff/1/


Testing
---

1. Verified Ranger Kms is working as expected.


Thanks,

bhavik patel