Re: Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

2018-04-19 Thread Mehul Parikh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66684/#review201609
---


Ship it!




Ship It!

- Mehul Parikh


On April 19, 2018, 2:34 p.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66684/
> ---
> 
> (Updated April 19, 2018, 2:34 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2070
> https://issues.apache.org/jira/browse/RANGER-2070
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In latest ranger when tried to enable plugin for Storm, ranger service 
> creation fails. 
> Found below in Ranger-Admin logs.
> 
> 2018-04-07 09:48:53,132 [http-bio-6080-exec-4] INFO  
> apache.ranger.security.web.filter.RangerKRBAuthenticationFilter 
> (RangerKRBAuthenticationFilter.java:220) - Logged into Ranger as = 
> storm-rangerstorm
> 2018-04-07 09:48:53,136 [http-bio-6080-exec-4] INFO  
> org.apache.ranger.common.RESTErrorUtil (RESTErrorUtil.java:84) - Request 
> failed. loginId=null, logMessage=Bad Credentials
> javax.ws.rs.WebApplicationException
> at 
> org.apache.ranger.common.RESTErrorUtil.generateRESTException(RESTErrorUtil.java:77)
> at 
> org.apache.ranger.biz.RangerBizUtil.blockAuditorRoleUser(RangerBizUtil.java:1637)
> at org.apache.ranger.biz.UserMgr.addUserRole(UserMgr.java:981)
> at org.apache.ranger.biz.UserMgr.createUser(UserMgr.java:167)
> at 
> org.apache.ranger.biz.UserMgr$$FastClassBySpringCGLIB$$3bbcf0cf.invoke()
> at 
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:669)
> at 
> org.apache.ranger.biz.UserMgr$$EnhancerBySpringCGLIB$$f11ad8ab.createUser()
> at 
> org.apache.ranger.biz.XUserMgr.createServiceConfigUser(XUserMgr.java:2225)
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java acdfd2e 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java ad806fb 
>   security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 307f435 
> 
> 
> Diff: https://reviews.apache.org/r/66684/diff/2/
> 
> 
> Testing
> ---
> 
> 1.Storm Service is getting created
> 2.Auditor and KMS Auditor Role user are blocked from the respective Api's
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

2018-04-19 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66684/#review201526
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 19, 2018, 2:34 p.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66684/
> ---
> 
> (Updated April 19, 2018, 2:34 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2070
> https://issues.apache.org/jira/browse/RANGER-2070
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In latest ranger when tried to enable plugin for Storm, ranger service 
> creation fails. 
> Found below in Ranger-Admin logs.
> 
> 2018-04-07 09:48:53,132 [http-bio-6080-exec-4] INFO  
> apache.ranger.security.web.filter.RangerKRBAuthenticationFilter 
> (RangerKRBAuthenticationFilter.java:220) - Logged into Ranger as = 
> storm-rangerstorm
> 2018-04-07 09:48:53,136 [http-bio-6080-exec-4] INFO  
> org.apache.ranger.common.RESTErrorUtil (RESTErrorUtil.java:84) - Request 
> failed. loginId=null, logMessage=Bad Credentials
> javax.ws.rs.WebApplicationException
> at 
> org.apache.ranger.common.RESTErrorUtil.generateRESTException(RESTErrorUtil.java:77)
> at 
> org.apache.ranger.biz.RangerBizUtil.blockAuditorRoleUser(RangerBizUtil.java:1637)
> at org.apache.ranger.biz.UserMgr.addUserRole(UserMgr.java:981)
> at org.apache.ranger.biz.UserMgr.createUser(UserMgr.java:167)
> at 
> org.apache.ranger.biz.UserMgr$$FastClassBySpringCGLIB$$3bbcf0cf.invoke()
> at 
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:669)
> at 
> org.apache.ranger.biz.UserMgr$$EnhancerBySpringCGLIB$$f11ad8ab.createUser()
> at 
> org.apache.ranger.biz.XUserMgr.createServiceConfigUser(XUserMgr.java:2225)
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java acdfd2e 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java ad806fb 
>   security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 307f435 
> 
> 
> Diff: https://reviews.apache.org/r/66684/diff/2/
> 
> 
> Testing
> ---
> 
> 1.Storm Service is getting created
> 2.Auditor and KMS Auditor Role user are blocked from the respective Api's
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

2018-04-19 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66684/
---

(Updated April 19, 2018, 2:34 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
Sailaja Polavarapu.


Bugs: RANGER-2070
https://issues.apache.org/jira/browse/RANGER-2070


Repository: ranger


Description
---

In latest ranger when tried to enable plugin for Storm, ranger service creation 
fails. 
Found below in Ranger-Admin logs.

2018-04-07 09:48:53,132 [http-bio-6080-exec-4] INFO  
apache.ranger.security.web.filter.RangerKRBAuthenticationFilter 
(RangerKRBAuthenticationFilter.java:220) - Logged into Ranger as = 
storm-rangerstorm
2018-04-07 09:48:53,136 [http-bio-6080-exec-4] INFO  
org.apache.ranger.common.RESTErrorUtil (RESTErrorUtil.java:84) - Request 
failed. loginId=null, logMessage=Bad Credentials
javax.ws.rs.WebApplicationException
at 
org.apache.ranger.common.RESTErrorUtil.generateRESTException(RESTErrorUtil.java:77)
at 
org.apache.ranger.biz.RangerBizUtil.blockAuditorRoleUser(RangerBizUtil.java:1637)
at org.apache.ranger.biz.UserMgr.addUserRole(UserMgr.java:981)
at org.apache.ranger.biz.UserMgr.createUser(UserMgr.java:167)
at 
org.apache.ranger.biz.UserMgr$$FastClassBySpringCGLIB$$3bbcf0cf.invoke()
at 
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:669)
at 
org.apache.ranger.biz.UserMgr$$EnhancerBySpringCGLIB$$f11ad8ab.createUser()
at 
org.apache.ranger.biz.XUserMgr.createServiceConfigUser(XUserMgr.java:2225)


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java acdfd2e 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java ad806fb 
  security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 307f435 


Diff: https://reviews.apache.org/r/66684/diff/2/

Changes: https://reviews.apache.org/r/66684/diff/1-2/


Testing
---

1.Storm Service is getting created
2.Auditor and KMS Auditor Role user are blocked from the respective Api's


Thanks,

Fatima Khan

Re: Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

2018-04-18 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66684/#review201428
---




security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java
Line 961 (original)


Can you fix the test failures? 

```
Tests run: 24, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.375 sec 
<<< FAILURE! - in org.apache.ranger.biz.TestUserMgr
unnecessary Mockito stubbings(org.apache.ranger.biz.TestUserMgr)  Time 
elapsed: 0.018 sec  <<< ERROR!
org.mockito.exceptions.misusing.UnnecessaryStubbingException:
Unnecessary stubbings detected in test class: TestUserMgr
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of 
code):
  1. -> at 
org.apache.ranger.biz.TestUserMgr.test28DeleteUserRole(TestUserMgr.java:912)
Please remove unnecessary stubbings or use 'silent' option. More info: 
javadoc for UnnecessaryStubbingException class.
at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:49)
at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:161)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
```


- Velmurugan Periasamy


On April 18, 2018, 1:38 p.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66684/
> ---
> 
> (Updated April 18, 2018, 1:38 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2070
> https://issues.apache.org/jira/browse/RANGER-2070
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In latest ranger when tried to enable plugin for Storm, ranger service 
> creation fails. 
> Found below in Ranger-Admin logs.
> 
> 2018-04-07 09:48:53,132 [http-bio-6080-exec-4] INFO  
> apache.ranger.security.web.filter.RangerKRBAuthenticationFilter 
> (RangerKRBAuthenticationFilter.java:220) - Logged into Ranger as = 
> storm-rangerstorm
> 2018-04-07 09:48:53,136 [http-bio-6080-exec-4] INFO  
> org.apache.ranger.common.RESTErrorUtil (RESTErrorUtil.java:84) - Request 
> failed. loginId=null, logMessage=Bad Credentials
> javax.ws.rs.WebApplicationException
> at 
> org.apache.ranger.common.RESTErrorUtil.generateRESTException(RESTErrorUtil.java:77)
> at 
> org.apache.ranger.biz.RangerBizUtil.blockAuditorRoleUser(RangerBizUtil.java:1637)
> at org.apache.ranger.biz.UserMgr.addUserRole(UserMgr.java:981)
> at org.apache.ranger.biz.UserMgr.createUser(UserMgr.java:167)
> at 
> org.apache.ranger.biz.UserMgr$$FastClassBySpringCGLIB$$3bbcf0cf.invoke()
> at 
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:669)
> at 
> org.apache.ranger.biz.UserMgr$$EnhancerBySpringCGLIB$$f11ad8ab.createUser()
> at 
> org.apache.ranger.biz.XUserMgr.createServiceConfigUser(XUserMgr.java:2225)
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java acdfd2e 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java ad806fb 
> 
> 
> Diff: https://reviews.apache.org/r/66684/diff/1/
> 
> 
> Testing
> ---
> 
> 1.Storm Service is getting created
> 2.Auditor and KMS Auditor Role user are blocked from the respective Api's
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

2018-04-18 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66684/
---

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
Sailaja Polavarapu.


Bugs: RANGER-2070
https://issues.apache.org/jira/browse/RANGER-2070


Repository: ranger


Description
---

In latest ranger when tried to enable plugin for Storm, ranger service creation 
fails. 
Found below in Ranger-Admin logs.

2018-04-07 09:48:53,132 [http-bio-6080-exec-4] INFO  
apache.ranger.security.web.filter.RangerKRBAuthenticationFilter 
(RangerKRBAuthenticationFilter.java:220) - Logged into Ranger as = 
storm-rangerstorm
2018-04-07 09:48:53,136 [http-bio-6080-exec-4] INFO  
org.apache.ranger.common.RESTErrorUtil (RESTErrorUtil.java:84) - Request 
failed. loginId=null, logMessage=Bad Credentials
javax.ws.rs.WebApplicationException
at 
org.apache.ranger.common.RESTErrorUtil.generateRESTException(RESTErrorUtil.java:77)
at 
org.apache.ranger.biz.RangerBizUtil.blockAuditorRoleUser(RangerBizUtil.java:1637)
at org.apache.ranger.biz.UserMgr.addUserRole(UserMgr.java:981)
at org.apache.ranger.biz.UserMgr.createUser(UserMgr.java:167)
at 
org.apache.ranger.biz.UserMgr$$FastClassBySpringCGLIB$$3bbcf0cf.invoke()
at 
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:669)
at 
org.apache.ranger.biz.UserMgr$$EnhancerBySpringCGLIB$$f11ad8ab.createUser()
at 
org.apache.ranger.biz.XUserMgr.createServiceConfigUser(XUserMgr.java:2225)


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java acdfd2e 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java ad806fb 


Diff: https://reviews.apache.org/r/66684/diff/1/


Testing
---

1.Storm Service is getting created
2.Auditor and KMS Auditor Role user are blocked from the respective Api's


Thanks,

Fatima Khan