Re: Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

2018-09-19 Thread pengjianhua

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68423/#review208791
---


Ship it!




Ship It!

- pengjianhua


On 八月 18, 2018, 5:48 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68423/
> ---
> 
> (Updated 八月 18, 2018, 5:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat 
> Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2193
> https://issues.apache.org/jira/browse/RANGER-2193
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Form validation during testconnection should be consistent with service 
> creation/editing
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 
> 7c2c778c1 
> 
> 
> Diff: https://reviews.apache.org/r/68423/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>



Re: Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

2018-09-19 Thread navi ramesh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68423/#review208783
---


Ship it!




Ship It!

- navi ramesh


On 八月 18, 2018, 5:48 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68423/
> ---
> 
> (Updated 八月 18, 2018, 5:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2193
> https://issues.apache.org/jira/browse/RANGER-2193
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Form validation during testconnection should be consistent with service 
> creation/editing
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 
> 7c2c778c1 
> 
> 
> Diff: https://reviews.apache.org/r/68423/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>



Re: Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

2018-09-06 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68423/#review208440
---


Ship it!




Ship It!

- Nitin Galave


On Aug. 18, 2018, 5:48 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68423/
> ---
> 
> (Updated Aug. 18, 2018, 5:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2193
> https://issues.apache.org/jira/browse/RANGER-2193
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Form validation during testconnection should be consistent with service 
> creation/editing
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 
> 7c2c778c1 
> 
> 
> Diff: https://reviews.apache.org/r/68423/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>



Review Request 68423: RANGER-2193 Form validation during testconnection should be consistent with service creation/editing

2018-08-17 Thread Qiang Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68423/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, 
sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Bugs: RANGER-2193
https://issues.apache.org/jira/browse/RANGER-2193


Repository: ranger


Description
---

Form validation during testconnection should be consistent with service 
creation/editing


Diffs
-

  security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 
7c2c778c1 


Diff: https://reviews.apache.org/r/68423/diff/1/


Testing
---


Thanks,

Qiang Zhang