Re: Review Request 68849: RANGER-2235 Modify the login session detail page as a modal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68849/#review209163 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 26, 2018, 9:01 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68849/ > --- > > (Updated Sept. 26, 2018, 9:01 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat > Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-2235 > https://issues.apache.org/jira/browse/RANGER-2235 > > > Repository: ranger > > > Description > --- > > On the Audit Admin tab page, if the user clicks to view the session details, > it will jump to a new page, user cannot return to previous page. We need to > click again to enter the Audit Admin tab page, and reselect the filter > condition and the page number. > Audit Login Sessions tab page has the same problem. > > Modify the login session detail page as a modal?the user can continue to view > the current page after close the modal. > > > Diffs > - > > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js > 697d33d9c > security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js > e92929a93 > > security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html > b11fa83fb > > > Diff: https://reviews.apache.org/r/68849/diff/1/ > > > Testing > --- > > > Thanks, > > Qiang Zhang > >
Re: Review Request 68849: RANGER-2235 Modify the login session detail page as a modal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68849/#review209063 --- Ship it! Ship It! - pengjianhua On 九月 26, 2018, 9:01 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68849/ > --- > > (Updated 九月 26, 2018, 9:01 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat > Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-2235 > https://issues.apache.org/jira/browse/RANGER-2235 > > > Repository: ranger > > > Description > --- > > On the Audit Admin tab page, if the user clicks to view the session details, > it will jump to a new page, user cannot return to previous page. We need to > click again to enter the Audit Admin tab page, and reselect the filter > condition and the page number. > Audit Login Sessions tab page has the same problem. > > Modify the login session detail page as a modal?the user can continue to view > the current page after close the modal. > > > Diffs > - > > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js > 697d33d9c > security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js > e92929a93 > > security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html > b11fa83fb > > > Diff: https://reviews.apache.org/r/68849/diff/1/ > > > Testing > --- > > > Thanks, > > Qiang Zhang > >
Re: Review Request 68849: RANGER-2235 Modify the login session detail page as a modal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68849/#review209018 --- Ship it! - Nitin Galave On Sept. 26, 2018, 9:01 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68849/ > --- > > (Updated Sept. 26, 2018, 9:01 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat > Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-2235 > https://issues.apache.org/jira/browse/RANGER-2235 > > > Repository: ranger > > > Description > --- > > On the Audit Admin tab page, if the user clicks to view the session details, > it will jump to a new page, user cannot return to previous page. We need to > click again to enter the Audit Admin tab page, and reselect the filter > condition and the page number. > Audit Login Sessions tab page has the same problem. > > Modify the login session detail page as a modal?the user can continue to view > the current page after close the modal. > > > Diffs > - > > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js > 697d33d9c > security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js > e92929a93 > > security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html > b11fa83fb > > > Diff: https://reviews.apache.org/r/68849/diff/1/ > > > Testing > --- > > > Thanks, > > Qiang Zhang > >
Review Request 68849: RANGER-2235 Modify the login session detail page as a modal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68849/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy. Bugs: RANGER-2235 https://issues.apache.org/jira/browse/RANGER-2235 Repository: ranger Description --- On the Audit Admin tab page, if the user clicks to view the session details, it will jump to a new page, user cannot return to previous page. We need to click again to enter the Audit Admin tab page, and reselect the filter condition and the page number. Audit Login Sessions tab page has the same problem. Modify the login session detail page as a modal?the user can continue to view the current page after close the modal. Diffs - security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 697d33d9c security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js e92929a93 security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html b11fa83fb Diff: https://reviews.apache.org/r/68849/diff/1/ Testing --- Thanks, Qiang Zhang
